Re: [Django] #18305: force_update/force_insert not passed up the inheritance chain in .save()

[Django]

#18305: force_update/force_insert not passed up the inheritance chain in .save()
-+-
 Reporter:  Anssi Kääriäinen |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fixed in 6b4834952dcce0db5cbc1534635c00ff8573a6d8.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0b684f2c98eaa1957abec4ef1dbc6b4e%40djangoproject.com.

Re: [Django] #18305: force_update/force_insert not passed up the inheritance chain in .save()

[Django]

#18305: force_update/force_insert not passed up the inheritance chain in .save()
-+-
 Reporter:  Anssi Kääriäinen |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Abhijeet Viswa):

 I believe this can be closed since from Django 1.5, `save()` does an
 update and on failure does an insert. At least for default UUIDs (#29260,
 #29129) force_insert is honored for both classes. (I vaguely remember it
 to be the same for AutoField in PostgreSQL as well).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a98f5d19e1914431058505a3453a1ba0%40djangoproject.com.

Re: [Django] #18305: force_update/force_insert not passed up the inheritance chain in .save()

[Django]

#18305: force_update/force_insert not passed up the inheritance chain in .save()
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Alex):

 * stage:  Design decision needed => Accepted


Comment:

 Marking as accpted, at least 50% of this is an obvious bug ;)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18305: force_update/force_insert not passed up the inheritance chain in .save()

[Django]

#18305: force_update/force_insert not passed up the inheritance chain in .save()
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:   |  decision needed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akaariai):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Design decision needed


Comment:

 Patches for force_update and force_insert fixes available at:
 https://github.com/akaariai/django/tree/ticket_18305 (just force_update)
 and https://github.com/akaariai/django/tree/ticket_18305_both (contains
 also force_insert).

 I am marking this DDN, as I am not sure if fixing the force_insert can be
 considered backwards compatible. If there were a way to save only the
 child model (the restaurant), then this would be easier to accept, as we
 could add "do this instead:" to the release notes.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.