Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  exonian
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => fixed


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.af8d0b19a2344229d89146d4e8acbbf7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  exonian
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"8654c6a7329c06133b6c4b32f05e606132a338e5" 8654c6a7]:
 {{{
 #!CommitTicketReference repository=""
 revision="8654c6a7329c06133b6c4b32f05e606132a338e5"
 Refs #18586 -- Split up tests.m2m_through_regress
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0d9fe096668c02ef2da6ce4a6d400f12%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  exonian
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by exonian):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/4377

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.013d8e0f582bbc08f4dcbcb684e7c1cf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  exonian
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by exonian):

 * status:  new => assigned
 * owner:   => exonian


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2d0c8801142d155c83029f74204e14e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by bmispelon):

 * owner:  alainivars =>
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.35e530d651a87d83a2b6f24af5e759ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  alainivars
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by bmispelon:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `tests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:
> ~~tests.basic.ModelTest.test_lookup~~
> ~~tests.basic.ModelTest.test_object_creation~~
> ~~tests.custom_columns.CustomColumnsTests.test_db_column~~
> ~~tests.custom_managers.CustomManagerTests.test_manager~~
> ~~tests.custom_pk.CustomPKTests.test_custom_pk~~
> ~~tests.defer.DeferTests.test_defer~~
> ~~tests.expressions.ExpressionsTests.test_filter~~
> ~~tests.field_subclassing.CustomField.test_custom_field~~ (deprecated)
> ~~tests.get_or_create.GetOrCreateTests.test_get_or_create~~
> ~~tests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~
> `tests.m2m_signals.ManyToManySignalsTest`
> ~~tests.m2m_through.M2mThroughTests~~
> `tests.m2m_through_regress.M2MThroughTestCase`
> ~~tests.model_inheritance.ModelInheritanceTests~~
> ~~tests.model_package.ModelPackageTests.test_model_packages~~
> ~~tests.order_with_respect_to.OrderWithRespectToTests.test_basic~~
> ~~tests.signals.SignalTests.test_basic~~
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `tests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:
 ~~tests.basic.ModelTest.test_lookup~~
 ~~tests.basic.ModelTest.test_object_creation~~
 ~~tests.custom_columns.CustomColumnsTests.test_db_column~~
 ~~tests.custom_managers.CustomManagerTests.test_manager~~
 ~~tests.custom_pk.CustomPKTests.test_custom_pk~~
 ~~tests.defer.DeferTests.test_defer~~
 ~~tests.expressions.ExpressionsTests.test_filter~~
 ~~tests.field_subclassing.CustomField.test_custom_field~~ (deprecated)
 ~~tests.get_or_create.GetOrCreateTests.test_get_or_create~~
 ~~tests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~
 ~~tests.m2m_signals.ManyToManySignalsTest~~
 ~~tests.m2m_through.M2mThroughTests~~
 `tests.m2m_through_regress.M2MThroughTestCase`
 ~~tests.model_inheritance.ModelInheritanceTests~~
 ~~tests.model_package.ModelPackageTests.test_model_packages~~
 ~~tests.order_with_respect_to.OrderWithRespectToTests.test_basic~~
 ~~tests.signals.SignalTests.test_basic~~

 This ticket is meant to track all of them; each time a test is updated, we
 can strike it out in the list above and once there is no item left, we can
 close this. The point is to make the test suite help developers as much as
 possible.

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  alainivars
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Baptiste Mispelon ):

 In [changeset:"82ec05fcc96121d7b23cc07c2c0ad3c0546bac35" 82ec05f]:
 {{{
 #!CommitTicketReference repository=""
 revision="82ec05fcc96121d7b23cc07c2c0ad3c0546bac35"
 Refs #18586 -- Split up tests/m2m_signals
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f19d8a2ab4303074e6ee94ca38e7b1d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  alainivars
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by alainivars):

 * owner:   => alainivars
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4597fe2d82f30c0b14a8f84afc26e70c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timgraham):

 * owner:  alainivars =>
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5317552b305a2c7046ac32c053b89b72%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  alainivars
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by alainivars):

 * owner:  ChillarAnand => alainivars
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8624203170df35a0f1c81dda200f186a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by wearp:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `tests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:
> ~~tests.basic.ModelTest.test_lookup~~
> ~~tests.basic.ModelTest.test_object_creation~~
> ~~tests.custom_columns.CustomColumnsTests.test_db_column~~
> ~~tests.custom_managers.CustomManagerTests.test_manager~~
> ~~tests.custom_pk.CustomPKTests.test_custom_pk~~
> `tests.defer.DeferTests.test_defer`
> ~~tests.expressions.ExpressionsTests.test_filter~~
> ~~tests.field_subclassing.CustomField.test_custom_field~~ (deprecated)
> ~~tests.get_or_create.GetOrCreateTests.test_get_or_create~~
> ~~tests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~
> `tests.m2m_signals.ManyToManySignalsTest`
> ~~tests.m2m_through.M2mThroughTests~~
> `tests.m2m_through_regress.M2MThroughTestCase`
> ~~tests.model_inheritance.ModelInheritanceTests~~
> ~~tests.model_package.ModelPackageTests.test_model_packages~~
> ~~tests.order_with_respect_to.OrderWithRespectToTests.test_basic~~
> ~~tests.signals.SignalTests.test_basic~~
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `tests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:
 ~~tests.basic.ModelTest.test_lookup~~
 ~~tests.basic.ModelTest.test_object_creation~~
 ~~tests.custom_columns.CustomColumnsTests.test_db_column~~
 ~~tests.custom_managers.CustomManagerTests.test_manager~~
 ~~tests.custom_pk.CustomPKTests.test_custom_pk~~
 ~~tests.defer.DeferTests.test_defer~~
 ~~tests.expressions.ExpressionsTests.test_filter~~
 ~~tests.field_subclassing.CustomField.test_custom_field~~ (deprecated)
 ~~tests.get_or_create.GetOrCreateTests.test_get_or_create~~
 ~~tests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~
 `tests.m2m_signals.ManyToManySignalsTest`
 ~~tests.m2m_through.M2mThroughTests~~
 `tests.m2m_through_regress.M2MThroughTestCase`
 ~~tests.model_inheritance.ModelInheritanceTests~~
 ~~tests.model_package.ModelPackageTests.test_model_packages~~
 ~~tests.order_with_respect_to.OrderWithRespectToTests.test_basic~~
 ~~tests.signals.SignalTests.test_basic~~

 This ticket is meant to track all of them; each time a test is updated, we
 can strike it out in the list above and once there is no item left, we can
 close this. The point is to make the test suite help developers as much as
 possible.

--

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"89527576980ff14309990c152e5904ddd5ca3df7"]:
 {{{
 #!CommitTicketReference repository=""
 revision="89527576980ff14309990c152e5904ddd5ca3df7"
 Refs #18586 -- Split up tests.defer.DeferTests.test_defer
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1fbc16033d0dede9e0ff93353d46e469%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by AmiZya):

 * cc: amizya@… (added)


Comment:

 I'll work on `m2m_signals` and `m2m_through_regress`

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a26072f6b50b87dc94b10d5adbdf6f8a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by wearp):

 I am going to start working on DeferTests.test_defer.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0a0e0917fd15ee046ccd99370e4dcfb4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"43041ee48c802418ec935a2ece59f876f5888c40"]:
 {{{
 #!CommitTicketReference repository=""
 revision="43041ee48c802418ec935a2ece59f876f5888c40"
 Refs #18586 -- Refactored expressions tests.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.812b489d28a1fc6f24ec47b24b08f3a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"6db122c7aba5738aad92aa20c9bbf2dea6d3308e"]:
 {{{
 #!CommitTicketReference repository=""
 revision="6db122c7aba5738aad92aa20c9bbf2dea6d3308e"
 Refs #18586 -- Split custom manager tests.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7cf209f70cd281ed34a924e270cbfcc2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"f66d9a2300f8fcb82d2bb21c43dc0e658c49086a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="f66d9a2300f8fcb82d2bb21c43dc0e658c49086a"
 Refs #18586 -- Split custom_pk test.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8596eb25f533f6be4378d0d99f3b53c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"7daf00679d2848fdb6f5618009817b56486fce1b"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7daf00679d2848fdb6f5618009817b56486fce1b"
 Refs #18586 -- Split up order_with_respect_to tests
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9cc581cde650751dd0d72b3ab0ca765c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by berkerpeksag):

 [https://github.com/django/django/pull/3638 PR #3638] LGTM. (I added a
 couple of minor comments on GitHub)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.686c5060775f49170921dc45231c214f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by timgraham:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
> ~~`modeltests.basic.ModelTest.test_object_creation`~~[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> ~~modeltests.custom_managers.CustomManagerTests.test_manager~~[[BR]]
> ~~modeltests.custom_pk.CustomPKTests.test_custom_pk~~[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
> `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> ~~`modeltests.signals.SignalTests.test_basic`~~
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `tests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:
 ~~tests.basic.ModelTest.test_lookup~~
 ~~tests.basic.ModelTest.test_object_creation~~
 ~~tests.custom_columns.CustomColumnsTests.test_db_column~~
 ~~tests.custom_managers.CustomManagerTests.test_manager~~
 ~~tests.custom_pk.CustomPKTests.test_custom_pk~~
 `tests.defer.DeferTests.test_defer`
 ~~tests.expressions.ExpressionsTests.test_filter~~
 ~~tests.field_subclassing.CustomField.test_custom_field~~ (deprecated)
 ~~tests.get_or_create.GetOrCreateTests.test_get_or_create~~
 ~~tests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~
 `tests.m2m_signals.ManyToManySignalsTest`
 ~~tests.m2m_through.M2mThroughTests~~
 `tests.m2m_through_regress.M2MThroughTestCase`
 ~~tests.model_inheritance.ModelInheritanceTests~~
 ~~tests.model_package.ModelPackageTests.test_model_packages~~
 ~~tests.order_with_respect_to.OrderWithRespectToTests.test_basic~~
 ~~tests.signals.SignalTests.test_basic~~

 This ticket is meant to track all of them; each time a test is updated, we
 can strike it out in the list above and once there is no item left, we can
 close this. The point is to make the test suite help developers as much as
 possible.

--

--
Ticket URL: 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"2cd19f3738b9c4a6861c007bf22f72a386cba07f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="2cd19f3738b9c4a6861c007bf22f72a386cba07f"
 Refs #18586 -- Split up model_inheritance.ModelInheritanceTest
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7009c413854b4696addf3321ac949270%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by alexanderad):

 PR for model_inheritance.ModelInheritanceTests
 https://github.com/django/django/pull/3658.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.86e8b5337ad44a1b238b51348ecddcae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  new
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Woops, should have been "refs #" in the commit message of that last one so
 this didn't get closed as there is still more work to do in the other
 tests.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ef270f2ed608e4fe12a074749c8d5f51%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e1513a7960399054d6686efb287f3887ad84b73f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e1513a7960399054d6686efb287f3887ad84b73f"
 Fixed #18586 -- Split up model_package.ModelPackageTests.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f4f52db549a1f41f8acec7d97c56e04d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by alexanderad):

 PR for model_package.ModelPackageTests.test_models_packages:
 https://github.com/django/django/pull/3657

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.28ab07d5859eb2029b404d5e426937e6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by helenst):

 PR for order_with_respect_to:
 https://github.com/django/django/pull/3638

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.be541dd2657ff0371eb285dad0bfd538%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by timgraham:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> ~~modeltests.custom_managers.CustomManagerTests.test_manager~~[[BR]]
> ~~modeltests.custom_pk.CustomPKTests.test_custom_pk~~[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
> `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
 ~~`modeltests.basic.ModelTest.test_object_creation`~~[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 ~~modeltests.custom_managers.CustomManagerTests.test_manager~~[[BR]]
 ~~modeltests.custom_pk.CustomPKTests.test_custom_pk~~[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
 `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by agiliq:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> ~~modeltests.custom_pk.CustomPKTests.test_custom_pk~~[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
> `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 ~~modeltests.custom_managers.CustomManagerTests.test_manager~~[[BR]]
 ~~modeltests.custom_pk.CustomPKTests.test_custom_pk~~[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
 `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by agiliq):

 Opened PR for custom_managers here:
 https://github.com/django/django/pull/3491

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.55992344656b36a90bf784a6de28c633%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by agiliq:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
> `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 ~~modeltests.custom_pk.CustomPKTests.test_custom_pk~~[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
 `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by agiliq):

 Opened PR for custom pks here:
 https://github.com/django/django/pull/3483

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.6865cd75604dda5a8b655ab8ff3a8a16%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by browniebroke:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> `modeltests.basic.ModelTest.test_lookup`[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
> `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
 `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"d1e87aebf70dd035c98a0b0f0162c0a2c398598c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d1e87aebf70dd035c98a0b0f0162c0a2c398598c"
 Refactored model lookup tests; refs #18586.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.09066d3232c15a5e76c4c5f03639b355%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by browniebroke):

 Patch for ModelTest.test_lookup:
 https://github.com/django/django/pull/3306

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d6c24ae387946fa49658dc1a9cb6f752%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by davide-ceretti:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> `modeltests.basic.ModelTest.test_lookup`[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> `modeltests.m2m_through.M2mThroughTests`[[BR]]
> `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 `modeltests.basic.ModelTest.test_lookup`[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 ~~modeltests.m2m_through.M2mThroughTests~~[[BR]]
 `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Loic Bistuer ):

 In [changeset:"d8e157d5ab1648a509b25d5ec571572ae936de79"]:
 {{{
 #!CommitTicketReference repository=""
 revision="d8e157d5ab1648a509b25d5ec571572ae936de79"
 Refactored m2m_through tests. Refs #18586

 Refactored old tests that were rewritten 1:1 from doctests.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d8798c3b2ba7dabfc89974f59a5dfa0a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by davide-ceretti:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> `modeltests.basic.ModelTest.test_lookup`[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> `modeltests.m2m_through.M2mThroughTests`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 `modeltests.basic.ModelTest.test_lookup`[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 `modeltests.m2m_through.M2mThroughTests`[[BR]]
 `modeltests.m2m_through_regress.M2MThroughTestCase`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by davide-ceretti):

 Patch for M2mThroughTests refactor is at
 https://github.com/django/django/pull/3273

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.17c520ad417964aabeb127b13ecd903a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by davide-ceretti):

 I am going to start working on M2mThroughTests

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a93937bb0c13d9b0fa29168a0506244d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:
 Type:   |  ChillarAnand
  Cleanup/optimization   |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  unit tests   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by ChillarAnand):

 * owner:   => ChillarAnand
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4d3cc548b574c746b817d8740782be13%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timo):

 * status:  assigned => new
 * owner:  judy2k =>


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0e2e279d5457e3e654a866e1c1a2b892%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by timo):

 * has_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.af4d7c9f85b6e842ffc26393eccfb056%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"7e2c804c9417617934cd731a4537719a1bd8d985"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7e2c804c9417617934cd731a4537719a1bd8d985"
 Split tests.basic.ModelTests in several tests; refs #18586.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4a6874fa628bef2f6b72693bae5e5c12%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"7b064e539009b4845ca31bd4a3dd5a9b913d1a0e"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7b064e539009b4845ca31bd4a3dd5a9b913d1a0e"
 Split GenericRelationsTests.test_generic_relations into several tests;
 refs #18586.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7ad9b6fa06455e6fadea7bb58875f6b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by jose):

 I have committed a pull request for the first reported unit test
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`.
 You can check [https://github.com/django/django/pull/2693 the PR in
 Github].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.386eab13da75f3af5544a13f594892a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by zsoldosp):

 * cc: zsoldosp (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.57f54b171f53d7b1bb1a060ec0593241%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by zsoldosp):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d50ecadd1303913dccea5458b7132644%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by zsoldosp):

 I'm at the DjangoCon Europe Sprint and working on splitting up {{{
 modeltests.basic.ModelTest.test_object_creation }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e173baff701421365ad37180f6cd3a1c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Description changed by julien:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> `modeltests.basic.ModelTest.test_lookup`[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> `modeltests.get_or_create.GetOrCreateTests.test_get_or_create`[[BR]]
> ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> `modeltests.m2m_through.M2mThroughTests`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 `modeltests.basic.ModelTest.test_lookup`[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 ~~modeltests.get_or_create.GetOrCreateTests.test_get_or_create~~[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 `modeltests.m2m_through.M2mThroughTests`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
 `modeltests.signals.SignalTests.test_basic`

 I only went through modeltests/*/tests.py; I might have overlooked a few
 tests.

 This ticket is 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by bsilverberg):

 I am going to start working on modeltests.basic.ModelTest.test_lookup

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ac1b4970e4af6068266b12bfb86c63cf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Liav3000):

 Hi. I just created https://github.com/liavkoren-
 vmfarms/djangoDev/tree/ticket_18586 which refactors
 modeltests.get_or_create.GetOrCreateTests.test_get_or_create into smaller
 units and changes comments over to docstrings. I'd be happy to continue
 crunching through the tests in this ticket if everything is okay with that
 first set of changes.

 Thanks, Liav.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5f927a44192b78b6aeb6283ea336aaec%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Description changed by julien:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> `modeltests.basic.ModelTest.test_lookup`[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> `modeltests.get_or_create.GetOrCreateTests.test_get_or_create`[[BR]]
> `modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m`[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> `modeltests.m2m_through.M2mThroughTests`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 `modeltests.basic.ModelTest.test_lookup`[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 `modeltests.get_or_create.GetOrCreateTests.test_get_or_create`[[BR]]
 ~~modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m~~[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 `modeltests.m2m_through.M2mThroughTests`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
 `modeltests.signals.SignalTests.test_basic`

 I only went through modeltests/*/tests.py; I might have overlooked a few
 tests.

 This ticket is 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"0d98422b1365ae1e75051036936aab31248d5ee1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="0d98422b1365ae1e75051036936aab31248d5ee1"
 Refactored RecursiveM2MTests into smaller pieces, refs #18586.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.85f0e83c4cd0ad02e4b322e929bc6312%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by claudep):

 Carl, I guess we're also entering personal style here.
 For example in that commit, I would have regrouped
 `test_get_first_name`/`test_filter_first_name` and probably also the 3
 last
 
(`test_get_all_authors_for_an_article`/`test_get_all_articles_for_an_author`/`test_get_author_m2m_relation`),
 particularly as they are only querying data.
 But once again, this is just me, and I can understand others have
 different approaches.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by carljm):

 @claudep If you want to look over the initial PR I just committed and
 comment on whether you think these tests are split up too finely, I'd like
 to make sure we have consensus on the right level of test granularity
 before @modi.konark moves forward with more PRs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Description changed by carljm:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> `modeltests.custom_columns.CustomColumnsTests.test_db_column`[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> `modeltests.get_or_create.GetOrCreateTests.test_get_or_create`[[BR]]
> `modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m`[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> `modeltests.m2m_through.M2mThroughTests`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 `modeltests.basic.ModelTest.test_lookup`[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 ~~modeltests.custom_columns.CustomColumnsTests.test_db_column~~[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 `modeltests.get_or_create.GetOrCreateTests.test_get_or_create`[[BR]]
 `modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m`[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 `modeltests.m2m_through.M2mThroughTests`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
 `modeltests.signals.SignalTests.test_basic`

 I only went through modeltests/*/tests.py; I might have overlooked a few
 tests.

 This ticket is meant 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Description changed by carljm:

Old description:

> There's quite a lot of unit tests that have been rewritten 1:1 from
> doctests. These tests tend to verify all aspects of a certain feature at
> once, they modify the state of the database throughout the whole test and
> by the end of the test no one really knows what the database state is
> supposed to be.
>
> For example,
> `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
> walks through most of the features supported by `GenericForeignKeys`, it
> is 130 lines long and in case the last assertion fails, you'll have to
> spend ridiculous amounts of time figuring out what happened.
>
> A likely incomplete list of similar tests:[[BR]]
> `modeltests.basic.ModelTest.test_lookup`[[BR]]
> `modeltests.basic.ModelTest.test_object_creation`[[BR]]
> `modeltests.custom_columns.CustomColumnsTests.test_db_column`[[BR]]
> `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
> `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
> `modeltests.defer.DeferTests.test_defer`[[BR]]
> `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
> `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
> `modeltests.files.FileStorageTests.test_files`[[BR]]
> `modeltests.get_or_create.GetOrCreateTests.test_get_or_create`[[BR]]
> `modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m`[[BR]]
> `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
> `modeltests.m2m_through.M2mThroughTests`[[BR]]
> `modeltests.model_formsets.ModelFormsetTests`[[BR]]
> `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
> more than 500 lines!)[[BR]]
> `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
> `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
> `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
> `modeltests.signals.SignalTests.test_basic`
>
> I only went through modeltests/*/tests.py; I might have overlooked a few
> tests.
>
> This ticket is meant to track all of them; each time a test is updated,
> we can strike it out in the list above and once there is no item left, we
> can close this. The point is to make the test suite help developers as
> much as possible.

New description:

 There's quite a lot of unit tests that have been rewritten 1:1 from
 doctests. These tests tend to verify all aspects of a certain feature at
 once, they modify the state of the database throughout the whole test and
 by the end of the test no one really knows what the database state is
 supposed to be.

 For example,
 `modeltests.generic_relations.GenericRelationsTests.test_generic_relations`
 walks through most of the features supported by `GenericForeignKeys`, it
 is 130 lines long and in case the last assertion fails, you'll have to
 spend ridiculous amounts of time figuring out what happened.

 A likely incomplete list of similar tests:[[BR]]
 ~~modeltests.basic.ModelTest.test_lookup~~[[BR]]
 `modeltests.basic.ModelTest.test_object_creation`[[BR]]
 `modeltests.custom_columns.CustomColumnsTests.test_db_column`[[BR]]
 `modeltests.custom_managers.CustomManagerTests.test_manager`[[BR]]
 `modeltests.custom_pk.CustomPKTests.test_custom_pk`[[BR]]
 `modeltests.defer.DeferTests.test_defer`[[BR]]
 `modeltests.expressions.ExpressionsTests.test_filter`[[BR]]
 `modeltests.field_subclassing.CustomField.test_custom_field`[[BR]]
 `modeltests.files.FileStorageTests.test_files`[[BR]]
 `modeltests.get_or_create.GetOrCreateTests.test_get_or_create`[[BR]]
 `modeltests.m2m_recursive.RecursiveM2MTests.test_recursive_m2m`[[BR]]
 `modeltests.m2m_signals.ManyToManySignalsTest`[[BR]]
 `modeltests.m2m_through.M2mThroughTests`[[BR]]
 `modeltests.model_formsets.ModelFormsetTests`[[BR]]
 `modeltests.model_forms.OldFormForXTests.test_with_data` (This one has
 more than 500 lines!)[[BR]]
 `modeltests.model_inheritance.ModelInheritanceTests`[[BR]]
 `modeltests.model_package.ModelPackageTests.test_model_packages`[[BR]]
 `modeltests.order_with_respect_to.OrderWithRespectToTests.test_basic`[[BR]]
 `modeltests.signals.SignalTests.test_basic`

 I only went through modeltests/*/tests.py; I might have overlooked a few
 tests.

 This ticket is meant to 

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by Carl Meyer ):

 In [changeset:"483e1b807e7a3c9e49fe5fcbf9b1300ef98a381c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="483e1b807e7a3c9e49fe5fcbf9b1300ef98a381c"
 Refs #18586 -- Split out long custom_columns lookup test into multiple
 tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by claudep):

 I'd just like to note that cutting single tests in multiple tests has a
 cost for the test suite, as the database is flushed between tests. So it's
 right and fine to separate tests when testing different features, but
 don't just create test methods for each single database request.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by modi.konark@…):

 Tried Merging the pull request by koniiik, there were lot of conflicts.
 The test directory layout has changed and also the conventions used needed
 to be re-worked.


 Will be re-writing the tests and issue a pull request as and when they are
 done.

 https://github.com/django/django/pull/923 , for the test " Custom Columns
 " .

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Testing framework |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by aaugustin):

 * component:  Uncategorized => Testing framework


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by konk):

 Found another candidate:
 `regressiontests.defer_regress.DeferRegressionTest.test_basic`

 IMO, this test is broken because its results depend on the order of
 execution of tests as it accesses the global model class storage. This
 means it won't be that easy to rewrite this test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by judy2k):

 * status:  new => assigned


Comment:

 Basic test refactorings now committed at
 https://github.com/bedmondmark/django/tree/test_refactor - I'll issue a
 Pull Request when I've finished the whole lot.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
--+
 Reporter:  konk  |Owner:  judy2k
 Type:  Cleanup/optimization  |   Status:  new
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  unit tests| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by judy2k):

 * owner:  anonymous => judy2k
 * status:  assigned => new


Comment:

 Last attempt to get the status of this ticket correct.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Uncategorized|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  unit tests   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by judy2k):

 * owner:  judy2k => anonymous
 * status:  new => assigned
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:  judy2k
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Uncategorized|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  unit tests   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by judy2k):

 * owner:  anonymous => judy2k
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18586: Rewrite unit tests migrated from doctests

[Django]

#18586: Rewrite unit tests migrated from doctests
-+-
 Reporter:  konk |Owner:  anonymous
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Uncategorized|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  unit tests   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by anonymous):

 * owner:  nobody => anonymous
 * needs_docs:   => 0
 * status:  new => assigned
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.