Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-29 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ffdd6595ea2220f8e8a6fb3aacd3213b751d982f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ffdd6595ea2220f8e8a6fb3aacd3213b751d982f"
 Fixed #18919 -- Stopped dropping Z attribute when transforming geometries

 Previously, the wkb of geometries was dropping the Z attribute.
 Thanks luizvital for the report and tests and georger.si...@gmail.com
 for the tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-25 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by claudep):

 I think it's important to find out if the Z dimension should be included
 in the WKB or not.

 I've just been able (at last!) to download a PDF copy of the latest
 !OpenGis Standard (Simple feature access) version 1.2.1, 2011-05-28. The
 WKB does include the 3D/4D (Z/M) dimensions. See also
 http://en.wikipedia.org/wiki/Well-known_text#Well-known_binary The
 original spec from 1999 did not include it, which probably explains the
 current implementation.

 So if tests are positive (and noone opposes with good arguments), I will
 proceed with the current patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-25 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by luizvital):

 The patch worked like a charm for me!

 I think the way it's implemented has a better performance than reconstruct
 the Z coordinates of geometries at point level.

 But I really don't know if there are possible side-effects of updating
 `thread_context.wkb_w.outdim` depending on a method argument.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-25 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by georger.silva@…):

 Hi Claude,

 I don't think the patch needs to be too invasive. I did not test this (yet
 - I'll let you know in a few), but I think the solution is as simple as:

 1) identify if the geometry has a z coordinate;
 2) copy the points z coordinates;
 3) set the z coordinates after the conversion is done;

 PostGIS does not touch Z values:


 {{{!python
 SELECT ST_AsEWKT(ST_Transform(ST_GeomFromText('POLYGON((0 0 10,0 1 10,1 1
 10,1 0 10,0 0 10))',4326),31981))

 "SRID=31981;POLYGON((8234117.01325455 1000 10,8231607.63895047
 10201616.0688736 10,8432755.23239255 10206800.1025772 10,8435402.30459162
 1000 10,8234117.01325455 1000 10))"
 }}}

 Nevertheless, I'll test your most welcome patch.

 I'll let you know soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-22 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * needs_better_patch:  1 => 0


Comment:

 While working on #16594, I realized that the 3D dimension was stripped out
 from the wkb of geometries. I think that difference between wkb and ewkb
 should only be the srid, not the Z dimension. Unfortunately, I'm unable to
 download the latest OGC spec to confirm this, but at least the PostGIS
 documentation for ST_AsBinary mentions that it supports 3D.

 The patch is then more invasive that initially thought. Please test and
 comment!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-22 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * needs_better_patch:  0 => 1


Comment:

 You are totally right, the test of my current patch is broken (Z should
 not be changed to 0).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-21 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by georger.silva@…):

 I've just tested this and this is giving me an absurd result:


 {{{#!python
 from django.contrib.gis.geos import *
 p = Point(x=604567.28, y=8615808.59, z=221.14, srid=31980)
 print p.x,p.y,p.z
 # 604567.28 8615808.59 221.14
 p.transform(4674)
 print p.x
 # Out[12]: -62.986
 p.y
 # Out[13]: -89.97
 int(p.z))
 # Out[15]:
 
-41614946576139420832491006031366654402922094247483221784079256392454853820736417123190160119685530720854980944546305785406432088872556911665447459015376718790656L
 }}}

 This is how PostGIS processes it:
 {{{#!sql
 SELECT
 
ST_AsEWKT(ST_Transform(ST_SetSRID(ST_MakePoint(604567.28,8615808.59,221.14),31980),4674));
 -- "SRID=4674;POINT(-62.0375842938472 -12.5195091838259 221.14)"
 }}}

 This is a windows box, GEOS 3.3.5, python 2.7.

 My linux box is broken, so I can't test that on linux. I could screwed
 something up while merging, but I don't think so...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-21 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by georger.silva@…):

 Hi guys!

 I'll test this and let you know! This bug has been bothering me and the
 original reporter for some time :D

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-17 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-17 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by charettes):

 * needs_better_patch:  0 => 1


Comment:

 Included tests could use the `assertIsInstance` and `assertIsNone` methods
 for clarity.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-17 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 Testing welcome

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-15 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * stage:  Unreviewed => Accepted


Comment:

 I've been able to reproduce. I made some encouraging tests in providing
 ewkb to OGRGeometry. Hopefully I can provide a patch soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries

2012-09-10 Thread Django 
#18919: GEOSGeometry transform method is dropping Z attribute on 3D geometries
---+--
 Reporter:  luizvital  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  GIS|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by DavidEklund):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 See also ticket #16594. The reason for the missing z-coordinate in the
 admin discussed there is due to the above problems, or related ones.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.