Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2013-09-30 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by Ramiro Morales ):

 In [changeset:"47a65ad40e6b6ee282a46473977b774837950961"]:
 {{{
 #!CommitTicketReference repository=""
 revision="47a65ad40e6b6ee282a46473977b774837950961"
 [1.6.x] Force Unix-style line-endings for some helper files in
 staticfiles_tests.

 This fixes eight failures in the cached storage tests under Windows.

 Refs #18920 and 978d4476cf.

 4372718e83 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.73b8874658293a8b0021699da549e5f9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2013-09-30 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by Ramiro Morales ):

 In [changeset:"4372718e839d15c707d50cc78274a355258cf36a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="4372718e839d15c707d50cc78274a355258cf36a"
 Force Unix-style line-endings for some helper files in staticfiles_tests.

 This fixes eight failures in the cached storage tests under Windows.

 Refs #18920 and 978d4476cf.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2400a12d9e60b28a9512c0c30d71976b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-11-21 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by Julien Phalip ):

 In [changeset:"49484b54bc26122257ac73b059897870d6ef716f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="49484b54bc26122257ac73b059897870d6ef716f"
 [1.5.x] Fixed #18920 -- Added `.gitattributes` to normalize line endings
 in HTML templates and avoid spurious failures in the core test suite on
 Windows. Many thanks to manfre, Claude Paroz, Karen Tracey, MaxV and
 Daniel Langer for their advising and testing.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-11-21 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Julien Phalip ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"978d4476cf1956fe91a2a6b3b5d2157005560c33"]:
 {{{
 #!CommitTicketReference repository=""
 revision="978d4476cf1956fe91a2a6b3b5d2157005560c33"
 Fixed #18920 -- Added `.gitattributes` to normalize line endings in HTML
 templates and avoid spurious failures in the core test suite on Windows.
 Many thanks to manfre, Claude Paroz, Karen Tracey, MaxV and Daniel Langer
 for their advising and testing.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-11-18 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by MaxV):

 Tested and confirmed that adding .gitattributes file to repo before clone
 fixes aforementioned unit tests. Used Windows Git-1.8.0-preview20121022
 and Django master.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-11-17 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by MaxV):

 * needs_docs:  0 => 1


Comment:

 I figured that if #18926 is a duplicate, then the suggested .gitattributes
 file that dlanger added and tested there seems like a possible solution
 here. I will test the solution on Windows shortly. If we do add the
 .gitattributes file, I think it is necessary to document the change
 somewhere and possibly adding a note about Windows Git and line endings to
 the [https://docs.djangoproject.com/en/1.5/topics/install/#installing-the-
 development-version installation docs].

 Does anyone think that it would be very intrusive to force LF line endings
 on all html files in Django? Seems to be a reasonable way to ensure a
 consistent user testing experience with regards to line endings.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-10 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by julien):

 Adding a .gitattributes file to the repository, as suggested in #18926,
 would seem like the best approach, as this is clearly an issue with
 git/github, not the code or tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-09 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by kmtracey):

 Which, now that you mention it, is another reason to not change the tests.
 If we change the tests to expect CRLF line endings when running on Windows
 then people who download the tarball to Windows and run tests from that
 install will see errors, because going that route doesn't auto-convert
 line endings to CRLF.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-09 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by kmtracey):

 Those don't have any problem...the problem is introduced by git
 configurations which change LF in the files in the repo to CRLF on
 Windows.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-09 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by claudep):

 What about tests run not from git checkout but with a downloaded tarball?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-09 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by kmtracey):

 I do run the test suite on Windows, and have not run into this issue.
 Apparently when I installed git on Windows (git --version reports for me
 `git version 1.7.10.msysgit.1`), it either defaulted to setting
 `core.autocrlf` to `input` or I told it to do so. Ultimately I think that
 is the right approach: tell git to NOT alter line endings. If the
 .gitattributes file can help with that, we should add that as well. I
 don't think we should change the tests to account for different line
 endings on !Windows/Linux/Mac (does Mac still have yet a different
 convention or have they changed to LF only?) because that is fragile:
 people will add new tests without remembering to account for line ending
 differences across platforms and those tests will break on non-Linux
 platforms. Instead we should document that if you are using git on Windows
 you should configure git to have `core.autocrlf` set to `input` and/or
 include a .gitattbutes file that prevents the "wrong" setting for this
 value from causing problems.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-07 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by claudep):

 #18926 was a duplicate, but it suggests another way of solving this (at
 git level with .gitattributes).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-07 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by anonymous):

 * needs_better_patch:  1 => 0


Comment:

 Updated pull and now using force_bytes for the last three. I don't have a
 Python 3 environment to test it out right now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-06 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by claudep):

 * needs_better_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 On Python 3, you cannot concatenate bytes and str, so you will need to
 encode linesep (last three in your patch).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18920: Regresssiontests.template tests fail on windows due to expected '\n'

2012-09-06 Thread Django 
#18920: Regresssiontests.template tests fail on windows due to expected '\n'
---+--
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by manfre):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Pull request.

 https://github.com/django/django/pull/330

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.