Re: [Django] #19204: Python2-style exception syntax is still used in django.utils.unittest (and should be updated)

[Django]

#19204: Python2-style exception syntax is still used in django.utils.unittest 
(and
should be updated)
-+---
 Reporter:  garrison |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Python 3 |  Version:  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  py3k | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+---

Comment (by Aymeric Augustin ):

 In [changeset:"7f264e02f4480c49d1440be882416a10951c2165"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7f264e02f4480c49d1440be882416a10951c2165"
 Fixed #20680 -- Deprecated django.utils.unittest.

 Refs #19204.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3e657a5152bc4ec28ae3f376e7700c84%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19204: Python2-style exception syntax is still used in django.utils.unittest (and should be updated)

[Django]

#19204: Python2-style exception syntax is still used in django.utils.unittest 
(and
should be updated)
-+---
 Reporter:  garrison |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Python 3 |  Version:  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  py3k | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+---

Comment (by Florian Apolloner ):

 In [changeset:"ef98ae2910a6b5c86e1e0b003110455778e63324"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ef98ae2910a6b5c86e1e0b003110455778e63324"
 [1.5.X] Fixed #19204 -- Replaced python2-style exception syntax.

 Thanks to garrison for the report and patch.

 Backport of 4a71b842662162e0892a9269179421ff2191adba from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19204: Python2-style exception syntax is still used in django.utils.unittest (and should be updated)

[Django]

#19204: Python2-style exception syntax is still used in django.utils.unittest 
(and
should be updated)
-+---
 Reporter:  garrison |Owner:  aaugustin
 Type:  Bug  |   Status:  closed
Component:  Python 3 |  Version:  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  py3k | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+---
Changes (by Florian Apolloner ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4a71b842662162e0892a9269179421ff2191adba"]:
 {{{
 #!CommitTicketReference repository=""
 revision="4a71b842662162e0892a9269179421ff2191adba"
 Fixed #19204 -- Replaced python2-style exception syntax.

 Thanks to garrison for the report and patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19204: Python2-style exception syntax is still used in django.utils.unittest (and should be updated)

[Django]

#19204: Python2-style exception syntax is still used in django.utils.unittest 
(and
should be updated)
-+---
 Reporter:  garrison |Owner:  aaugustin
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  py3k | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+---

Comment (by claudep):

 The required changes are really minor, go for it!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19204: Python2-style exception syntax is still used in django.utils.unittest (and should be updated)

[Django]

#19204: Python2-style exception syntax is still used in django.utils.unittest 
(and
should be updated)
-+---
 Reporter:  garrison |Owner:  aaugustin
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  py3k | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+---
Changes (by aaugustin):

 * owner:  nobody => aaugustin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19204: Python2-style exception syntax is still used in django.utils.unittest (and should be updated)

[Django]

#19204: Python2-style exception syntax is still used in django.utils.unittest 
(and
should be updated)
-+---
 Reporter:  garrison |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Python 3 |  Version:  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  py3k | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+---
Changes (by aaugustin):

 * severity:  Normal => Release blocker


Comment:

 Eventually I've changed my mind on this.

 There are only 4 except statements to change. And the backport of
 unittest2 will go away as soon as we drop support for Python 2.6.

 If we agree to make this change, let's do it before 1.5 final.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19204: Python2-style exception syntax is still used in django.utils.unittest (and should be updated)

[Django]

#19204: Python2-style exception syntax is still used in django.utils.unittest 
(and
should be updated)
--+---
 Reporter:  garrison  |Owner:  nobody
 Type:  Bug   |   Status:  new
Component:  Python 3  |  Version:  1.5-alpha-1
 Severity:  Normal|   Resolution:
 Keywords:  py3k  | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+---
Changes (by ptone):

 * needs_better_patch:  0 => 1
 * type:  Uncategorized => Bug
 * component:  Testing framework => Python 3
 * stage:  Unreviewed => Accepted


Comment:

 We are not alone here

 https://github.com/kennethreitz/requests/issues/738

 I tried a really quick warnings.filterwarnings but didn't work on my first
 attempt, but I think that route may still bear fruit

 I agree that we should not be patching the vendored unittest here - this
 may be a bug in the way py3 packaging and the way it handles split
 projects with the bytecompiling done at install.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19204: Python2-style exception syntax is still used in django.utils.unittest (and should be updated)

[Django]

#19204: Python2-style exception syntax is still used in django.utils.unittest 
(and
should be updated)
---+---
 Reporter:  garrison   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Testing framework  |  Version:  1.5-alpha-1
 Severity:  Normal |   Resolution:
 Keywords:  py3k   | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 The backport of unittest2 is only there for Python 2.6.

 I avoid modifying vendored library unless I absolutely need to.

 I wasn't aware it would trigger warnings during installation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.