Re: [Django] #19276: ORM performance regression between 1.4.x and 1.5.x

2012-11-13 Thread Django 
#19276: ORM performance regression between 1.4.x and 1.5.x
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  Database layer   |  1.5-alpha-1
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akaariai):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 OK, it seems the regressions are now fixed, see:
 http://users.tkk.fi/~akaariai/djbench/query_select_related/ and
 http://users.tkk.fi/~akaariai/djbench/query_annotate/ (the last commits
 are barely visible in the right, but they are there...).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19276: ORM performance regression between 1.4.x and 1.5.x

2012-11-13 Thread Django 
#19276: ORM performance regression between 1.4.x and 1.5.x
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Database layer   |  1.5-alpha-1
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Anssi Kääriäinen ):

 In [changeset:"538d6c0fcd7e0a5505aa4d0424edc823ce2f511f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="538d6c0fcd7e0a5505aa4d0424edc823ce2f511f"
 Some changes to SortedDict to make it faster under py2

 Refs #19276
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19276: ORM performance regression between 1.4.x and 1.5.x

2012-11-13 Thread Django 
#19276: ORM performance regression between 1.4.x and 1.5.x
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Database layer   |  1.5-alpha-1
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Anssi Kääriäinen ):

 In [changeset:"fe21c233d44a5cafff0766eb17ed3df20e08b70f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="fe21c233d44a5cafff0766eb17ed3df20e08b70f"
 Removed use of SortedDict for query.alias_refcount

 This will have a smallish impact on performance. Refs #19276.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19276: ORM performance regression between 1.4.x and 1.5.x

2012-11-13 Thread Django 
#19276: ORM performance regression between 1.4.x and 1.5.x
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Database layer   |  1.5-alpha-1
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Anssi Kääriäinen ):

 In [changeset:"ce1af8d7023f02e4521cce3bcdbc9fd13d76c5f8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ce1af8d7023f02e4521cce3bcdbc9fd13d76c5f8"
 Removed use of SortedDict for query.alias_refcount

 This will have a smallish impact on performance. Refs #19276.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19276: ORM performance regression between 1.4.x and 1.5.x

2012-11-13 Thread Django 
#19276: ORM performance regression between 1.4.x and 1.5.x
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Database layer   |  1.5-alpha-1
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Anssi Kääriäinen ):

 In [changeset:"fa18b0ac89723f4ed6e46e744039bf375c8945a5"]:
 {{{
 #!CommitTicketReference repository=""
 revision="fa18b0ac89723f4ed6e46e744039bf375c8945a5"
 Some changes to SortedDict to make it faster under py2

 Refs #19276
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19276: ORM performance regression between 1.4.x and 1.5.x

2012-11-13 Thread Django 
#19276: ORM performance regression between 1.4.x and 1.5.x
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Database layer   |  1.5-alpha-1
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akaariai):

 * stage:  Accepted => Ready for checkin


Comment:

 I did a little more work, and now I have RFC stuff in
 https://github.com/akaariai/django/compare/ticket_19276

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19276: ORM performance regression between 1.4.x and 1.5.x

2012-11-11 Thread Django 
#19276: ORM performance regression between 1.4.x and 1.5.x
-+-
 Reporter:  akaariai |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Database layer   |  1.5-alpha-1
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by akaariai):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 One more regression spotted - query_select_related got hit by the above
 regressions + another change made for fixing Oracle in select_related
 cases. Commit: c159d9cec0baab7bbd04d5d51a92a51e354a722a, graph here:
 http://users.tkk.fi/~akaariai/djbench/query_select_related/

 A patch for the select_related case is available here:
 https://github.com/akaariai/django/compare/fix_select_related_perf (the
 reason for the regression was the repeated access to connections[using],
 the fix dodges this and makes the code a little cleaner, too).

 I am elevating this to release blocker. While the regressions aren't
 really that severe, it is a good idea to check if we can easily fix the
 performance regressions before the final release. If not, then lets just
 close this ticket. So, release blocker as in "lets not forget to check
 this before release".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.