subject:"Re\: \[Django\] #19368\: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page"

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-15 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  custom user, | Triage Stage:  Ready for
  USERNAME_FIELD, username   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Russell Keith-Magee ):

 In [changeset:"06b5f5fcb6db2fc20e2d455a34f3f4b0293cfd8c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="06b5f5fcb6db2fc20e2d455a34f3f4b0293cfd8c"
 [1.5.X] Corrected tests depending on the error message on the
 AuthenticationForm.

 Refs #19368, and the fix introduced in
 27f8129d64292868f6a328f7bf9a1bed67967ff3.

 Backport of 9facca28b619ad94680cf07774ee7a377034ca42 from trunk.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-15 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  custom user, | Triage Stage:  Ready for
  USERNAME_FIELD, username   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Russell Keith-Magee ):

 In [changeset:"9facca28b619ad94680cf07774ee7a377034ca42"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9facca28b619ad94680cf07774ee7a377034ca42"
 Corrected tests depending on the error message on the AuthenticationForm.

 Refs #19368, and the fix introduced in
 27f8129d64292868f6a328f7bf9a1bed67967ff3.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-15 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  custom user, | Triage Stage:  Ready for
  USERNAME_FIELD, username   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by Russell Keith-Magee ):

 In [changeset:"9534192c107aeaa1920408c0127920a4c61d9ca1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9534192c107aeaa1920408c0127920a4c61d9ca1"
 [1.5.X] Fixed #19368 -- Ensured that login error messages adapt to changes
 in the User model.

 Thanks to un33k for the report.

 Backport of 27f8129d64292868f6a328f7bf9a1bed67967ff3 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-15 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  custom user, | Triage Stage:  Ready for
  USERNAME_FIELD, username   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Russell Keith-Magee ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"27f8129d64292868f6a328f7bf9a1bed67967ff3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="27f8129d64292868f6a328f7bf9a1bed67967ff3"
 Fixed #19368 -- Ensured that login error messages adapt to changes in the
 User model.

 Thanks to un33k for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-15 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  custom user, | Triage Stage:  Ready for
  USERNAME_FIELD, username   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by russellm):

 Rather than try to find a generic term, we can substitute the name of the
 username field as an argument to the error message. The patch isn't that
 complicated, either; I'll commit shortly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-08 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  custom user, | Triage Stage:  Ready for
  USERNAME_FIELD, username   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-

Comment (by ptone):

 I'd only add that the language should be changed to say "Note that fields
 *may* be case-sensitive" which is sort of a cop out - but we now can't
 know the implementation, and it at least gives the user a heads up if they
 are forgetting that  - esp for hidden PW field.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-08 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  custom user, | Triage Stage:  Ready for
  USERNAME_FIELD, username   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by aaugustin):

 * severity:  Normal => Release blocker


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-08 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Normal   |   Resolution:
 Keywords:  custom user, | Triage Stage:  Ready for
  USERNAME_FIELD, username   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by aaugustin):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


Comment:

 Trivial patch attached, I'll just wait for a few days to see in case
 Russell disagrees.

 This should be committed before the string freeze.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

2012-12-08 Thread Django

#19368: Custom User without username and with USERNAME_FIELD = 'email', but 
still
see username error message at the admin login page
-+-
 Reporter:  un33k|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  contrib.admin|  1.5-alpha-1
 Severity:  Normal   |   Resolution:
 Keywords:  custom user, | Triage Stage:  Accepted
  USERNAME_FIELD, username   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  1
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 This message is hardcoded in
 `django.contrib.admin.forms.AdminAuthenticationForm`.

 `AdminAuthenticationForm` inherits
 `django.contrib.auth.forms.AuthenticationForm`. That class is aware of
 custom user models: it sets an appropriate label on the username field.

 `AdminAuthenticationForm` should reflect this. Replacing "username and
 password" by "credentials" should suffice.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

Re: [Django] #19368: Custom User without username and with USERNAME_FIELD = 'email', but still see username error message at the admin login page

9 matches

Site Navigation

Mail list logo

Footer information