Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

[Django]

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+-
 Reporter:  aleray |Owner:  pyriku
 Type:  New feature|   Status:  closed
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:  duplicate
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => duplicate


Comment:

 Duplicate of #9739

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.716f62ea9db4d3a257e622b9ec3611ab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

[Django]

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+
 Reporter:  aleray |Owner:  pyriku
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * needs_tests:  1 => 0
 * easy:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1f66c48bb07da7cf06daec645c979d14%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

[Django]

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+
 Reporter:  aleray |Owner:  pyriku
 Type:  New feature|   Status:  assigned
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by pyriku):

 * status:  new => assigned
 * owner:  nobody => pyriku


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

[Django]

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+
 Reporter:  aleray |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+

Comment (by pyriku):

 Just updated the pull request using ISO format instead:
 https://github.com/django/django/pull/589

 I can see your point ptone, but I think that adding those extra checks
 into the current logic (inside `ModelAdmin.add_view`) makes sense, even if
 we move the entire chunk of logic for prepopulate fields somewhere else
 eventually. Also, as I said on the PR, I'm not really sure where to add
 the documentation for this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

[Django]

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+
 Reporter:  aleray |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+

Comment (by ptone):

 I'd make the comment that because the querystring is presumably being
 generated by some code, and not a locale-based human form, that we
 simplify this by just using a standardized ISO format.

 But a broader and stickier question is how and where would you document
 this? This is adding API, and I would argue adding partial API probably to
 the wrong place.

 We have a rich system for the POST side of things when something is
 submitted, where you can provide your own ModelForm and all its associated
 validation.

 We have a special case for M2M on the GET/form-creation side because of
 #7738, but that doesn't mean we should have a public way of handling
 ModelForm initial data from a querystring generally, should we support all
 field types?

 The current, not super friendly, way of handling this would be to
 preprocess the initial values inside your ModelForm's __init__ - perhaps
 using the formfield's widget's _format_value method, which is what
 ModelForms do for POST values.

 I'm just not sure this kind of value prep work belongs in
 ModelAdmin.add_view

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

[Django]

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+
 Reporter:  aleray |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by slurms):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

[Django]

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+
 Reporter:  aleray |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by pyriku):

 Implementation without using dateutil and using DATETIME_INPUT_FORMATS
 submitted on this pull request: https://github.com/django/django/pull/589

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19431: Prepopulate modeladmin forms datetime fields using querystrings

[Django]

#19431: Prepopulate modeladmin forms datetime fields using querystrings
---+
 Reporter:  aleray |Owner:  nobody
 Type:  New feature|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by apollo13):

 * needs_better_patch:   => 0
 * has_patch:  1 => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Makes sense to me since we have explicit support for M2M field too, so why
 not DatetimeFields. Using dateutil is not an option though since we don't
 want a hard dependency there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.