Re: [Django] #19668: Form enhancement: `Form.set_data` to set data and files

[Django]

#19668: Form enhancement: `Form.set_data` to set data and files
-+-
 Reporter:  bruth|Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  1|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  1
 |UI/UX:  0
-+-
Changes (by claudep):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 This proposal received mostly negative opinions until now (also on django-
 developers). I also think that this would be an important change in the
 contract that Form data are set at initialization time, for few benefits
 but a high risk of triggering bugs in the form stack.
 Anyway, thanks for taking the time to make the proposal.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19668: Form enhancement: `Form.set_data` to set data and files

[Django]

#19668: Form enhancement: `Form.set_data` to set data and files
-+-
 Reporter:  bruth|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  1|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  1
 |UI/UX:  0
-+-

Comment (by rafales):

 -1, and you can make it even shorter:
 {{{
 form = Form(request.POST or None, request.FILES or None)
 if request.method == 'POST':
 # code
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19668: Form enhancement: `Form.set_data` to set data and files

[Django]

#19668: Form enhancement: `Form.set_data` to set data and files
-+-
 Reporter:  bruth|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  1|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  1
 |UI/UX:  0
-+-

Comment (by anonymous coward):

 -1


 You don't save a single line of code (unless you copy the provided
 example, which doesn't complete the antithesis version), are adding
 another method to maintain, and are creating the potential for internal
 problems (as mentioned above), not to mention making {{{Form}}} less
 extensible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19668: Form enhancement: `Form.set_data` to set data and files

[Django]

#19668: Form enhancement: `Form.set_data` to set data and files
-+-
 Reporter:  bruth|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  1|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  1
 |UI/UX:  0
-+-
Changes (by anonymous):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * stage:  Unreviewed => Design decision needed


Comment:

 I'm -0 on this change, but i'm not a core dev.

 The argument against this would be that much of a form's functionality
 changes based on data, fields, valid/invalid, cleaned data, errors etc..
 Changing the data at the wrong time could cause a lot of problems.
 Changing set_data to raise an error if the form is already bound may be
 enough to address some of those concerns. I'd suggest raising the issue on
 django-developers to get some opinions from core devs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19668: Form enhancement: `Form.set_data` to set data and files (was: Form enhancement: `Form.set_data` to set data an files)

[Django]

#19668: Form enhancement: `Form.set_data` to set data and files
-+--
 Reporter:  bruth|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.