Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
+-
 Reporter:  julien  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-

Comment (by Ramiro Morales ):

 In [changeset:"362dd68fb20be195462af22448416c9895ce7df7"]:
 {{{
 #!CommitTicketReference repository=""
 revision="362dd68fb20be195462af22448416c9895ce7df7"
 Added new 'srtext' spatialite 4.x SpatialRefSys column to its model.

 This is for general consistency in the GeoDjango DB backends.
 Thanks Claude for the fix.

 Refs #19678.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8955aadc97a992584a936a1404700ba5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
+-
 Reporter:  julien  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Ramiro Morales ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9a73e7f40c851cef262dd36da444c81492632ee5"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9a73e7f40c851cef262dd36da444c81492632ee5"
 Fixed #19678 -- GeoDjango test failure with spatialite >= 3.0.

 Thanks Julien for the report and Claude for the fix.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.55318c5b06d6a3c93407435eeef65ea0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
+-
 Reporter:  julien  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by claudep):

 * stage:  Accepted => Ready for checkin


Comment:

 Ramiro, please go ahead. I can confirm that the `srtext` column is 4.x
 only (was previously named `srs_wkt`, but not used in !GeoDjango).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f8b67ea1cd6a6cbe5f5aa21a66f40711%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
+
 Reporter:  julien  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by ramiro):

 I've uploaded a modified version of Claude's patch that works for me
 (spatialite 3.x here, note how the version conditional was changed to only
 in version 4.x otherwise most of the GIS tests fail becuase AFAICS
 libspatialite 3 doesn't create the new srtex column).

 Perhaps this can be divided in two different commits?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.6ec8e917790de600d162a19063b7b57f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
+
 Reporter:  julien  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by timo):

 I can reproduce this using djangocore-box:
 {{{
 vagrant@djangocore:~$ runtests2.7-spatialite django.contrib.gis
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 
..s..sssss..FEs...
 ==
 ERROR: django.contrib.gis.tests.geoapp.tests
 (unittest.loader.ModuleImportFailure)
 --
 ImportError: Failed to import test module:
 django.contrib.gis.tests.geoapp.tests
 Traceback (most recent call last):
   File "/usr/lib/python2.7/unittest/loader.py", line 252, in _find_tests
 module = self._get_module_from_name(name)
   File "/usr/lib/python2.7/unittest/loader.py", line 230, in
 _get_module_from_name
 __import__(name)
   File "/django/django/contrib/gis/tests/geoapp/tests.py", line 207, in
 
 class GeoLookupTest(TestCase):
   File "/django/django/contrib/gis/tests/geoapp/tests.py", line 307, in
 GeoLookupTest
 if postgis_bug_version():
   File "/django/django/contrib/gis/tests/geoapp/tests.py", line 27, in
 postgis_bug_version
 spatial_version = getattr(connection.ops, "spatial_version", (0,0,0))
   File "/django/django/utils/functional.py", line 49, in __get__
 res = instance.__dict__[self.func.__name__] = self.func(instance)
   File "/django/django/contrib/gis/db/backends/spatialite/operations.py",
 line 133, in spatial_version
 six.reraise(ImproperlyConfigured, ImproperlyConfigured(new_msg),
 sys.exc_info()[2])
   File "/django/django/contrib/gis/db/backends/spatialite/operations.py",
 line 127, in spatial_version
 version = self.spatialite_version_tuple()[1:]
   File "/django/django/contrib/gis/db/backends/spatialite/operations.py",
 line 273, in spatialite_version_tuple
 version = self.spatialite_version()
   File "/django/django/contrib/gis/db/backends/spatialite/operations.py",
 line 264, in spatialite_version
 return self._get_spatialite_func('spatialite_version()')
   File "/django/django/contrib/gis/db/backends/spatialite/operations.py",
 line 242, in _get_spatialite_func
 cursor = self.connection._cursor()
   File "/django/django/db/backends/__init__.py", line 131, in _cursor
 self.ensure_connection()
   File "/django/django/db/backends/__init__.py", line 126, in
 ensure_connection
 self.connect()
   File "/django/django/db/backends/__init__.py", line 113, in connect
 conn_params = self.get_connection_params()
   File "/django/django/db/backends/sqlite3/base.py", line 322, in
 get_connection_params
 "settings.DATABASES is improperly configured. "
 ImproperlyConfigured: Cannot determine the SpatiaLite version for the ""
 database (error was "settings.DATABASES is improperly configured. Please
 supply the NAME value.").  Was the SpatiaLite initialization SQL loaded on
 this database?


 ==
 FAIL: test02_osr
 (django.contrib.gis.tests.test_spatialrefsys.SpatialRefSysTest)
 Testing getting OSR objects from SpatialRefSys model objects.
 --
 Traceback (most recent call last):
   File "/django/django/contrib/gis/tests/test_spatialrefsys.py", line 77,
 in test02_osr
 six.assertRegex(self, srs.proj4, sd['proj4_re'])
   File "/django/django/utils/six.py", line 430, in assertRegex
 return getattr(self, _assertRegex)(*args, **kwargs)
 AssertionError: Regexp didn't match: '\\+proj=longlat (\\+ellps=WGS84
 )?\\+datum=WGS84 \\+no_defs ' not found in u'+proj=longlat +ellps=WGS84
 +towgs84=0,0,0,0,0,0,0 +no_defs '

 --
 Ran 266 tests in 2.289s

 FAILED (failures=1, errors=1, skipped=23)
 }}}


 After the patch is applied, none of the GIS tests run:
 {{{
 vagrant@djangocore:~$ runtests2.7-spatialite django.contrib.gis
 Traceback (most recent call last):
   File "/django/tests/runtests.py", line 364, in 
 options.failfast, args)
   File "/django/tests/runtests.py", line 193, in django_tests
 state = 

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
+
 Reporter:  julien  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 I've finally been able to reproduce the issue after upgrading my main
 system to Debian wheezy (using Spatialite 3). This has nothing to do with
 `spatial_ref_sys` data in Spatialite, but rather a consequence of the way
 the `gdal.SpatialReference` is initialized with a pseudo srs WKT.

 Julien, would you be able to test the attached patch?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cc4c00e34f6819aff9c8f55676d50023%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
+
 Reporter:  julien  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by claudep):

 * severity:  Release blocker => Normal


Comment:

 Quoting Anssi:
 ''+1 for not holding 1.5 for this one. Spatialite isn't exactly the most
 used DB for gis, and the failure doesn't look like data corruption or
 crashing type.''

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
-+
 Reporter:  julien   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 I've just compiled libspatialite 4.0.0 and ran the gis tests without
 errors. I have really no clue what your failure comes from.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
-+
 Reporter:  julien   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by julien):

 This is what I get when running that query:

 {{{
 [(4326, u'epsg', 4326, u'WGS 84', u'+proj=longlat +datum=WGS84 +no_defs',
 u'GEOGCS["WGS 84",DATUM["WGS_1984",SPHEROID["WGS
 
84",6378137,298.257223563,AUTHORITY["EPSG","7030"]],AUTHORITY["EPSG","6326"]],PRIMEM["Greenwich",0,AUTHORITY["EPSG","8901"]],UNIT["degree",0.0174532925199433,AUTHORITY["EPSG","9122"]],AUTHORITY["EPSG","4326"]]')]
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
-+
 Reporter:  julien   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 That's strange. When reading libspatialite 4.0.0 sources, I can see the
 proper definition of the 4326 epsg definition
 (src/srsinit/epsg_inlined_wgs84_00.c):

 {{{
 p = add_epsg_def (filter, first, last, 4326, "epsg", 4326,
 "WGS 84");
 add_proj4text (p, 0,
 "+proj=longlat +datum=WGS84 +no_defs");
 }}}

 What's the result of:
 {{{SELECT * FROM spatial_ref_sys WHERE srid=4326;}}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
-+
 Reporter:  julien   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by julien):

 Hi Claude, this is the updated error message:

 {{{
 ==
 FAIL: test02_osr
 (django.contrib.gis.tests.test_spatialrefsys.SpatialRefSysTest)
 Testing getting OSR objects from SpatialRefSys model objects.
 --
 Traceback (most recent call last):
   File "/django/django/contrib/gis/tests/test_spatialrefsys.py", line 76,
 in test02_osr
 self.assertIn(srs.proj4, sd['proj4'])
 AssertionError: u'+proj=longlat +ellps=WGS84 +towgs84=0,0,0,0,0,0,0
 +no_defs ' not found in ['+proj=longlat +ellps=WGS84 +datum=WGS84 +no_defs
 ', '+proj=longlat +datum=WGS84 +no_defs ']
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
-+
 Reporter:  julien   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 Julien, could you replace the `assertTrue` by an `assertIn` so as we can
 plainly see the strings involved in the comparison?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19678: Test failure with spatialite

[Django]

#19678: Test failure with spatialite
-+
 Reporter:  julien   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  GIS  |  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by julien):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Marking as blocker to be sure 1.5 doesn't ship with a test failure.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.