Re: [Django] #19689: Deprecate `Options.module_name` in favor of `model_name`

[Django]

#19689: Deprecate `Options.module_name` in favor of `model_name`
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:  fixed
  (models, ORM)  | Triage Stage:  Ready for
 Severity:  Normal   |  checkin
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Tim Graham ):

 In [changeset:"f6c1f05fbf8fdf980c91666d1c14990632e18503"]:
 {{{
 #!CommitTicketReference repository=""
 revision="f6c1f05fbf8fdf980c91666d1c14990632e18503"
 Removed Model._meta.module_name per deprecation timeline.

 refs #19689.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.967b148b73299a81a62d08945e445588%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #19689: Deprecate `Options.module_name` in favor of `model_name`

[Django]

#19689: Deprecate `Options.module_name` in favor of `model_name`
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:  fixed
  (models, ORM)  | Triage Stage:  Ready for
 Severity:  Normal   |  checkin
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Simon Charette ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ec469ade2b04b94bfeb59fb0fc7d9300470be615"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ec469ade2b04b94bfeb59fb0fc7d9300470be615"
 Fixed #19689 -- Renamed `Model._meta.module_name` to `model_name`.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19689: Deprecate `Options.module_name` in favor of `model_name`

[Django]

#19689: Deprecate `Options.module_name` in favor of `model_name`
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Ready for
 Severity:  Normal   |  checkin
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by charettes):

 Alright, I'll update documentation and commit this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19689: Deprecate `Options.module_name` in favor of `model_name`

[Django]

#19689: Deprecate `Options.module_name` in favor of `model_name`
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Ready for
 Severity:  Normal   |  checkin
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * stage:  Accepted => Ready for checkin


Comment:

 Looks good. I'd suggest the following wording:

 Deprecation timeline:

 > `Model._meta.module_name` was renamed to `model_name`.

 Release notes:

 > `Model._meta.module_name` was renamed to `model_name`. Despite being a
 private API, it will go through a regular deprecation path.

 The release notes are for our users. The deprecation timeline is just a
 list for advancing deprecations and usually more concise.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19689: Deprecate `Options.module_name` in favor of `model_name`

[Django]

#19689: Deprecate `Options.module_name` in favor of `model_name`
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by charettes):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0


Comment:

 Added a patch with release note and deprecation timeline entry. I'd
 appreciate if someone could take a look at my wording.

 All tests pass on Python 2.7.3 SQLite3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19689: Deprecate `Options.module_name` in favor of `model_name` (was: Use `Options.module_name` instead of `object_name.lower()`)

[Django]

#19689: Deprecate `Options.module_name` in favor of `model_name`
-+-
 Reporter:  charettes|Owner:  charettes
 Type:   |   Status:  assigned
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  1
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by charettes):

 * needs_docs:  0 => 1
 * needs_tests:  0 => 1


Comment:

 Added a patch that raises a warning when accessing `module_name` and
 returns the newly introduced `model_name`.

 Also made some cleanup in `django/contrib/auth/context_processors.py`
 since it was manipulating `app_label`s using a variable/parameter named
 `module_name`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.