Re: [Django] #20346: cache middleware should vary on full URL

2013-12-28 Thread Django 
#20346: cache middleware should vary on full URL
-+-
 Reporter:  jamey|Owner:  Tim
 Type:  Bug  |  Graham 
Component:  Core (Cache system)  |   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:  fixed
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  1
 |UI/UX:  0
-+-
Changes (by Tim Graham ):

 * owner:   => Tim Graham 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"71a03e01aa19cbde08e915d156abf39b67d904ef"]:
 {{{
 #!CommitTicketReference repository=""
 revision="71a03e01aa19cbde08e915d156abf39b67d904ef"
 Fixed #20346 -- Made cache middleware vary on the full URL.

 Previously, only the URL path was included in the cache key.

 Thanks jamey for the suggestion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.bf607b9e15caf0d2f2a9fd9b0e4ae8af%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-10-30 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * needs_docs:  1 => 0


Comment:

 Docs still need some minor tweaks. Please uncheck "Patch needs
 improvement" when you have a chance to update it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8c8caaa33145c7713f665ce78d3a3739%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-10-17 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by ijl):

 I've documented the changes in the 1.7 release notes. I'm at a loss for
 backwards-compatible changes using the keys, given that existing cache
 keys use a hash.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0277bb761c2144a7791659b1bf4e7bd9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-10-17 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * version:  1.3 => master
 * needs_tests:  1 => 0
 * needs_docs:  0 => 1


Comment:

 Here's an [https://code.djangoproject.com/ticket/20346 updated PR] with
 tests. I left some minor comments for improvement.

 One concern is that upgrading Django will change cache keys for all the
 existing pages now that the domain name is part of the key. At a minimum,
 this needs to be documented in the release notes. Ideas for how we might
 be able to do this in a backwards compatible fashion would also be
 welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.17026273d825f00c156e4a095977789f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-07-12 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timo):

 This needs a test to demonstrate the change in behavior.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7c07b395d118a7dc0a98b45438dd4bb3%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-07-07 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by susan):

 * owner:  susan =>
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a70b61bb7b4fb224ad0549326c000b9d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-07-07 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by susan):

 * cc: susan.tan.fleckerl@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.377ff0e9647bd2d68f6f3b49018929ae%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-07-07 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:  susan
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by anonymous):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.b4cd327f038dd1ebe9b64dc75d0ba26b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-07-07 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:  susan
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by susan):

 * status:  new => assigned
 * owner:  nobody => susan


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c471d8a85172d570aa5f715e18cf5bef%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-07-07 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by susan):

 PR is here: https://github.com/django/django/pull/1341 Feel free to code
 review. Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.9ffb1441ef245b93e93f8766beb8bf71%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20346: cache middleware should vary on full URL

2013-05-19 Thread Django 
#20346: cache middleware should vary on full URL
-+
 Reporter:  jamey|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by ludw):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 This seems like a reasonable idea. Can't find any reasons why we shouldn't
 do this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.