Re: [Django] #20348: Consistently handle `Promise` objects assigned to model fields.

[Django]

#20348: Consistently handle `Promise` objects assigned to model fields.
-+-
 Reporter:  mrmachine|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Anssi Kääriäinen ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"31e6d58d46894ca35080b4eab7967e4c6aae82d4"]:
 {{{
 #!CommitTicketReference repository=""
 revision="31e6d58d46894ca35080b4eab7967e4c6aae82d4"
 Fixed #20348 -- Consistently handle Promise objects in model fields.

 All Promise objects were passed to force_text() deep in ORM query code.
 Not only does this make it difficult or impossible for developers to
 prevent or alter this behaviour, but it is also wrong for non-text
 fields.

 This commit changes `Field.get_prep_value()` from a no-op to one that
 resolved Promise objects. All subclasses now call super() method first
 to ensure that they have a real value to work with.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.68e3e2594d338b4374aa861416034523%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20348: Consistently handle `Promise` objects assigned to model fields.

[Django]

#20348: Consistently handle `Promise` objects assigned to model fields.
-+-
 Reporter:  mrmachine|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by akaariai):

 * stage:  Unreviewed => Ready for checkin


Comment:

 I like this. This means that lazy values are always evaluated at the time
 they are needed by the DB and one can customize the way the promise object
 is evaluated per field.

 Ill mark this as ready for checkin. The issues keeping me from committing
 this straight ahead:
   - Is this too risky to commit in alpha stage?
   - Could this lead to incompatibilities for custom fields?
   - It seems get_prep_lookup() doesn't always use get_prep_value(). I
 wonder if this could be fixed...

 But, like the "ready for checkin" triage stage indicates I don't see any
 of the above as blockers for commit. Waiting a bit to see if any other
 opinions arise.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c46209b3dca2b5aa10f835e0148bb7ab%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20348: Consistently handle `Promise` objects assigned to model fields.

[Django]

#20348: Consistently handle `Promise` objects assigned to model fields.
-+-
 Reporter:  mrmachine|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by mrmachine):

 * has_patch:  0 => 1


Comment:

 https://github.com/django/django/pull/1040

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20348: Consistently handle `Promise` objects assigned to model fields.

[Django]

#20348: Consistently handle `Promise` objects assigned to model fields.
-+-
 Reporter:  mrmachine|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by mrmachine):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Refs #10498.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.