Re: [Django] #20349: Don't load test suite when not testing

[Django]

#20349: Don't load test suite when not testing
--+
 Reporter:  CollinAnderson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by claudep):

 The problem when moving the signal definition in
 `django/contrib/auth/tests` is that many test cases outside of auth tests
 are overriding the PASSWORD_HASHERS setting (see [8fad77da9597e0dd9fc]),
 and then the signal is not installed for those tests.

 An argument for moving auth to core?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.196ed0e9ca1c59864611dccbfe78193c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20349: Don't load test suite when not testing

[Django]

#20349: Don't load test suite when not testing
--+
 Reporter:  CollinAnderson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by aaugustin):

 `setting_changed` is only targeted at tests for the time being.

 Maybe we can put this code under `django/contrib/auth/tests`? If that
 doesn't work, let's just live with the status quo.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20349: Don't load test suite when not testing

[Django]

#20349: Don't load test suite when not testing
--+
 Reporter:  CollinAnderson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by carljm):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20349: Don't load test suite when not testing

[Django]

#20349: Don't load test suite when not testing
--+
 Reporter:  CollinAnderson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by carljm):

 This pull request clearly can't work as written, since `HASHERS` and
 `PREFERRED_HASHER` don't exist in `django.test.signals`, so they can't be
 `global`ed there.

 We need to decide if `settings_changed` is meant to be a generally-
 supported framework feature, or a test-only feature. If the former, then
 it should be moved out of `django.test.signals`. If the latter, then
 fixing this bug is complicated; we'd need a hook in the test runner to
 allow apps to contribute stuff (like `settings_changed` signal
 registrations) to `setup_test_environment`. Or an `UNDER_TEST` setting, so
 that code like this can make the import and signal registration
 conditional on `UNDER_TEST`. Or just live with the fact that `django.test`
 is imported in production.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20349: Don't load test suite when not testing

[Django]

#20349: Don't load test suite when not testing
--+
 Reporter:  CollinAnderson|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Testing framework |  Version:  1.5
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by aaugustin):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20349: Don't load test suite when not testing

[Django]

#20349: Don't load test suite when not testing
-+-
 Reporter:  CollinAnderson   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.5
Component:  Testing framework|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by CollinAnderson):

 here's where the import was originally added:
 
https://github.com/django/django/commit/2a09404792f9d369718143fdfbe9530fe2e60912

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20349: Don't load test suite when not testing

[Django]

#20349: Don't load test suite when not testing
-+-
 Reporter:  CollinAnderson   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.5
Component:  Testing framework|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by CollinAnderson):

 * cc: cmawebsite@… (added)
 * needs_docs:   => 0
 * has_patch:  0 => 1
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 https://github.com/django/django/pull/1041

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.