Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
-+-
 Reporter:  tudor.prodan@…   |Owner:  susan
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.5
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Baptiste Mispelon ):

 In [changeset:"0946aac61d0da2aceafe6179cdb64ccad583d924"]:
 {{{
 #!CommitTicketReference repository=""
 revision="0946aac61d0da2aceafe6179cdb64ccad583d924"
 [1.5.x] Fixed #20659 -- Fixed PublisherDetail in CBV topic documentation.

 Thanks to tudor.prodan, susan, and Tim Graham for the report and reviews.

 Backport of 88de53d4a86548016f245a1413b856aa334bc737 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.e1160e660b51ea6cd4253201e513c22b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
-+-
 Reporter:  tudor.prodan@…   |Owner:  susan
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.5
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Baptiste Mispelon ):

 In [changeset:"e03a88ba217006fbd7618e3f836c2f6210638aaf"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e03a88ba217006fbd7618e3f836c2f6210638aaf"
 [1.6.x] Fixed #20659 -- Fixed PublisherDetail in CBV topic documentation.

 Backport of 88de53d4a86548016f245a1413b856aa334bc737 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.5389cc6aff4cfc0ebb58d7d30fd710ac%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
-+-
 Reporter:  tudor.prodan@…   |Owner:  susan
 Type:  Bug  |   Status:  closed
Component:  Documentation|  Version:  1.5
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Baptiste Mispelon ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"88de53d4a86548016f245a1413b856aa334bc737"]:
 {{{
 #!CommitTicketReference repository=""
 revision="88de53d4a86548016f245a1413b856aa334bc737"
 Fixed #20659 -- Fixed PublisherDetail in CBV topic documentation.

 Thanks to tudor.prodan, susan, and Tim Graham for the report and reviews.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.fd1a3a4c279158e07ddba4be05900c13%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
-+-
 Reporter:  tudor.prodan@…   |Owner:  susan
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  1.5
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by tudor.prodan@…):

 I've tested it, and it works.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.42ff5ee04418c92f68526011b8000e31%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
-+-
 Reporter:  tudor.prodan@…   |Owner:  susan
 Type:  Bug  |   Status:  assigned
Component:  Documentation|  Version:  1.5
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by timo):

 * stage:  Accepted => Ready for checkin


Comment:

 @susan: thanks, but I don't think simply creating pull requests from
 patches is necessary (don't want you to waste your time).

 Besides a typo ("explicitly") this looks good (although I haven't tested
 it).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.b0c2427ccf81632c326f4a2d9aca8dce%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
+
 Reporter:  tudor.prodan@…  |Owner:  susan
 Type:  Bug |   Status:  assigned
Component:  Documentation   |  Version:  1.5
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  1   |UI/UX:  0
+
Changes (by susan):

 * owner:  nobody => susan
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.9d83ee266fa7ff6ed4fea2eda4eab38d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
+
 Reporter:  tudor.prodan@…  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Documentation   |  Version:  1.5
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  1   |UI/UX:  0
+

Comment (by susan):

 Baptiste, I've just applied your patch, see PR here:
 https://github.com/django/django/pull/1318

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.d44a6d8bbcc8073349f73ad425a97b91%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
+
 Reporter:  tudor.prodan@…  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Documentation   |  Version:  1.5
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  1   |UI/UX:  0
+
Changes (by bmispelon):

 * has_patch:  0 => 1


Comment:

 I'm starting to wonder if it wouldn't be easier to remove the
 `SingleObjectMixin` and just go with `self.object =
 get_object_or_404(Publisher, pk=self.kwargs['pk'])` in the `get` method of
 the view.

 I find it much cleaner but it defeats the purpose of this part of the
 documentation.

 In any case, here's the patch that fixes the current documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.331ab90482a2f519cdf8a8a8ab8941ff%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20659: Error in the example for Using SingleObjectMixin with ListView

[Django]

#20659: Error in the example for Using SingleObjectMixin with ListView
+
 Reporter:  tudor.prodan@…  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Documentation   |  Version:  1.5
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  1   |UI/UX:  0
+
Changes (by bmispelon):

 * cc: bmispelon@… (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 I believe I'm the one who introduced this issue with commit
 c6862d57c1e987f0f98a77826d19358b9040bad1.

 I think the amount of bugs related to this page shows why you should keep
 your class-based views simple: it's very hard to anticipate the
 interactions of mixins which are not meant to work together.

 Thanks for catching this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.aa307fd8a6c622ae178cc9becff8f749%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.