Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-10-24 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Tim Graham ):

 In [changeset:"382d324ccc0753962ec31ac23a4bde4fb2b9454e"]:
 {{{
 #!CommitTicketReference repository=""
 revision="382d324ccc0753962ec31ac23a4bde4fb2b9454e"
 Added missing newline in docstring; refs #20945.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7ffd4a91945ccb063e83fd0ab773fbaf%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-10-23 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8688f03eef9cf5fd763ba35481ddcff933a60c30"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8688f03eef9cf5fd763ba35481ddcff933a60c30"
 Fixed #20945 -- Allowed cache tag to use a specific cache.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4fea3415be0775fa0f4954596bdf8d08%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-09-18 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * easy:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8c77242b3728c39b147b5cb78941eedb%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-28 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by timo):

 If other people like the implicit default, it's ok with me. My concern is
 hardcoding a setting that isn't configurable - seems like a small smell,
 but not too bad as it seems quite unlikely that someone would be using a
 cache_name of 'template_fragments' for another purpose.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.aa9f00674b3adad813d106689d93cb63%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-23 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by mjtamlyn):

 Just to clarify my viewpoint - I'm happy for there to be a new implicit
 default, I'm not happy for there to be a new setting. So overall I'm happy
 with both parts of the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.768128a5a195a61d05515611adfae35f%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-23 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by apollo13):

 @timo: can you say why and if that's a 0 or -1? I think that having an
 implicit default for the cache with a fallback to 'default' isn't that
 bad…

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7899b7b2c785115d45640d5eda37bd40%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-23 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by FunkyBob):

 *bump*

 So, the PR is now ready, adding the following:

 1) Allow specifying which cache backend a use of {% cache %} will store in
 by adding a using="cachename" to its args.

 2) Having {% cache %} tags use the cache 'template_fragments' if it's
 configured, otherwise use 'default'

 I see comments against (2), but I'd like to understand why people are
 against it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.89380c0f69dc815759dc1ec4685bff2e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-21 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by timo):

 From IRC, mjtamlyn and I favor carljm's approach of a custom wrapper to
 the cache tag rather than always defaulting to a "template_fragments"
 cache.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0e622d13f7d51d3feb66f3592299274c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-21 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by FunkyBob):

 Timo,

 I missed your comment there...  yes, I have considered if it should be a
 hard error or not to specify a cache that doesn't exist.

 I can see a case either way, to be honest.  But I guess since there's now
 a fallback approach for "template_fragments" -> "default", when you define
 one explicitly we probably should go splodey if it's not there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.439f8c049a5476bb04d90f569862b51a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-20 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by FunkyBob):

 Code, tests and docs are now ready in that PR

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f185830cf8176b0e90b6740002971838%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-20 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by FunkyBob):

 Cool... already done the patch and am working on tests and docs now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f0b2119674e282b9412a376feaae58e1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-20 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by carljm):

 Hmm. In this case, given we apply the tag-argument part of this patch, it
 could be easily handled in your project with a simple custom wrapper to
 the cache tag that passes along a different cache name by default. But if
 we're going to add support directly in Django for redirecting all
 template-tag caching away from the default cache, I definitely prefer the
 staticfiles approach to a setting.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.66ccabbd06f8470188daa45d6b3cfc92%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-20 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by FunkyBob):

 Well, yes, and no... I was basing it off the fact staticfiles, by default,
 will try to use a different cache backend and fall-back to default.  I
 think this is a good pattern for more of Django to follow, allowing people
 to differentiate if they want.

 In our current project we'd like to move all the template fragment caching
 to a specific backend.

 Perhaps a middle ground solution, and have it look for a fixed name [as
 staticfiles does -- I got confused and thought it had a setting] such as
 "fragments", and fall back to default otherwise?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f3441170ef00a5f411275f83fd27aa9a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-20 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+

Comment (by carljm):

 I don't think it makes sense to introduce a new dedicated default-cache
 setting just for the `cache` template tag. The default cache is so named
 because it is, well, the default.

 Being able to specify a cache in the tag syntax makes sense, though.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5d1f9b068e5e6f050957a334c669799e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #20945: Allow cache tag to use specified cache config.

2013-08-20 Thread Django 
#20945: Allow cache tag to use specified cache config.
-+
 Reporter:  FunkyBob |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by timo):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 You should probably raise the idea of adding a new setting on django-
 developers as we are averse to more settings and I'm not sure using a
 different cache than the "default" cache would be common enough to warrant
 it. If you have a use case for it, it would be helpful to describe it so
 we have some justification.

 It may also be better if `using="cache name"` throws an error if the given
 cache doesn't exist (i.e. "fail loudly") -- what do you think?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9ee8baab0b11c5cb00af3c858ba728c2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.