Re: [Django] #20989: Remove useless list comprehensions

2013-08-30 Thread Django
#20989: Remove useless list comprehensions
-+-
 Reporter:  jeroen.pulles@…  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Uncategorized|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"11cd7388f77aa9d12ab6b57285c3801b237e241b"]:
 {{{
 #!CommitTicketReference repository=""
 revision="11cd7388f77aa9d12ab6b57285c3801b237e241b"
 Fixed #20989 -- Removed useless explicit list comprehensions.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.12926b7183638d79da6f29ead37aeee2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [Django] #20989: Remove useless list comprehensions

2013-08-30 Thread Django
#20989: Remove useless list comprehensions
-+-
 Reporter:  jeroen.pulles@…  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Uncategorized|   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


Comment:

 As far as tests are green, I'd say go ahead.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.c7fbaf386474448279c2d10972edb605%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.


Re: [Django] #20989: Remove useless list comprehensions (was: tuple() and dict() accept iterators)

2013-08-29 Thread Django
#20989: Remove useless list comprehensions
--+
 Reporter:  jeroen.pulles@…   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Uncategorized |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by charettes):

 Added a patch which remove the missed ones and also consider the following
 cases:

 1. `set` and `set.update`
 2. `OrderedDict`
 3. `list.extend`
 4. `join`
 5. `min`,`max`,`sum` and `any`
 6. `sorted`

 All tests pass on py2/py3 SQlite and Postgres.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.55cfde074c2ecc048a43edb95f01c2de%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.