Re: [Django] #21064: The add_view and change_view code in contrib.admin.options share the same code and need to be refactored

[Django]

#21064: The add_view and change_view code in contrib.admin.options share the 
same
code and need to be refactored
--+
 Reporter:  kamni |Owner:  kamni
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:  admin | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"390001ce52802a7fa1fceeabfb646e6b32911fb9"]:
 {{{
 #!CommitTicketReference repository=""
 revision="390001ce52802a7fa1fceeabfb646e6b32911fb9"
 Fixed #21064 -- Refactored common logic in ModelAdmin.add_view and
 change_view.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.79bacdb00e68cf6df68430aa265c6598%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21064: The add_view and change_view code in contrib.admin.options share the same code and need to be refactored

[Django]

#21064: The add_view and change_view code in contrib.admin.options share the 
same
code and need to be refactored
--+
 Reporter:  kamni |Owner:  kamni
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  admin | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


Comment:

 Comments for improvement on the
 [https://github.com/django/django/pull/2256 PR].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e7500697a6d905066b9c0262cf7ffafc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21064: The add_view and change_view code in contrib.admin.options share the same code and need to be refactored

[Django]

#21064: The add_view and change_view code in contrib.admin.options share the 
same
code and need to be refactored
--+
 Reporter:  kamni |Owner:  kamni
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  admin | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by kamni):

 * owner:  nobody => kamni
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c92e44128dee068ad5c94b7ee4fe77d6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21064: The add_view and change_view code in contrib.admin.options share the same code and need to be refactored

[Django]

#21064: The add_view and change_view code in contrib.admin.options share the 
same
code and need to be refactored
--+
 Reporter:  kamni |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  admin | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by russellm):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Agreed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.870f36b7a04d5987c562cd5219fd8176%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.