Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+-
 Reporter:  dimyur27@…   |Owner:  Claude
 |  Paroz 
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin logs i18n  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"4a03e6f27207ec7d9bb12d229da570633c086a92" 4a03e6f2]:
 {{{
 #!CommitTicketReference repository=""
 revision="4a03e6f27207ec7d9bb12d229da570633c086a92"
 Refs #21113 -- Updated test to allow for bad MySQL time resolution
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.cd2a8a7ac296470f14cef6500783f72a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+-
 Reporter:  dimyur27@…   |Owner:  Claude
 |  Paroz 
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin logs i18n  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 Probably an issue with `.latest()`, on MySQL, not by chance! We may find
 another way to get the target logentry based on another criterion...

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.d8691fa3d78569b30c35ee1fd8fb6225%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+-
 Reporter:  dimyur27@…   |Owner:  Claude
 |  Paroz 
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin logs i18n  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 Possible flaky test seen [http://djangoci.com/job/django-master/1754/ on
 Jenkins]:
 {{{
 admin_utils.test_logentry.LogEntryTests.test_logentry_change_message

 Stacktrace

 Traceback (most recent call last):
   File "/mnt/jenkinsdata/workspace/django-
 master/database/mysql/python/python3.5/tests/admin_utils/test_logentry.py",
 line 65, in test_logentry_change_message
 self.assertEqual(logentry.get_change_message(), 'Changed title and
 hist.')
 AssertionError: 'Changed something' != 'Changed title and hist.'
 - Changed something
 + Changed title and hist.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.43186d4aa74999c333eeabde730e56b9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+-
 Reporter:  dimyur27@…   |Owner:  Claude
 |  Paroz 
 Type:  New feature  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  admin logs i18n  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * owner:   => Claude Paroz 
 * resolution:   => fixed


Comment:

 In [changeset:"cf7894be88f6c27680ef80796b883f6e3b709b8b" cf7894be]:
 {{{
 #!CommitTicketReference repository=""
 revision="cf7894be88f6c27680ef80796b883f6e3b709b8b"
 Fixed #21113 -- Made LogEntry.change_message language independent

 Thanks Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.45dffc9fcef933162909b8cfd339a278%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+-
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.eb4201df3553703fbb958e662f920c82%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timgraham):

 From a bit of searching, I guess the "good form" is to mitigate
 [http://haacked.com/archive/2009/06/25/json-hijacking.aspx/ JSON
 hijacking]? Those concerns probably aren't relevant here.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.334930c64fc08765589e227988ac9775%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 Changing the entire patch is not an issue at all.

 I would appreciate though if you could find some reference about this
 design issue.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.32ad6e57ccdfb3490d43813887dedd29%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by chmarr):

 I know this is very late to the party, and it's not that critical of an
 issue, but generally it is considered good form [citation-needed] to
 ensure the top level of a JSON structure is an object/dictionary, rather
 than a list, string, int, etc. `django.http.response.JsonResponse` for
 example considers anything except a dict to be 'unsafe'.

 The change is simple... just use `{'changes':[ ...]}` rather than simply
 `[...]`, but this does involve changing the entire patch. 

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.6c8cd2818363eea0a89179218eef95b9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.092db6e993eeb6c89aad86a9ff11a548%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by Claude Paroz ):

 In [changeset:"35c41987ecfaad849019d09468ce322fec86cd39" 35c4198]:
 {{{
 #!CommitTicketReference repository=""
 revision="35c41987ecfaad849019d09468ce322fec86cd39"
 Moved LogEntry-related tests to their own test case

 Thanks Tim Graham for reviewing and contributing to the patch.
 Refs #21113.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.07bbee5127b4c5dce81f94f096765ab0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Left comments for improvement on the pull request.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.e258d21cd23db336ced265385e3080df%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by claudep):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


Comment:

 [https://github.com/django/django/pull/5879 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.4daa07ad25a442991b2252a69bfe06f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 Replying to [comment:9 jooyous]:
 (...)
 > If having history messages displayed in different languages is a
 priority, I would recommend restructuring the logging functionality
 entirely, and have the messages be saved in an unambiguously delimited
 format (yaml? json? something!) so that they can be formed into
 translatable sentences after they are extracted from the database. I would
 be willing to work on this if an issue gets made!

 Yes, I think that this would be the right approach.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.8a0a6223ce933065c011aba9026d7d50%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by jooyous):

 * status:  assigned => new
 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * needs_tests:  0 => 1
 * owner:  jooyous =>


Comment:

 https://github.com/django/django/pull/3345

 Here's a partial fix for this bug. It changes the log messages so that
 they're saved in the database in English and then parsed and translated
 when they need to be displayed. However, due to the way the change
 messages were written upon being entered into the database, I wasn't able
 to properly distinguish between different types of save messages. For
 example, if an object (for example, a Poll or Choice) contained a period
 or quotation marks in the body, I could not tell the difference between
 the end of the message and the punctuation within the message body. So I'm
 only submitting a partial fix. From what I could test, it works pretty
 well for Users. I was also having some trouble getting certain words to
 translate.

 If having history messages displayed in different languages is a priority,
 I would recommend restructuring the logging functionality entirely, and
 have the messages be saved in an unambiguously delimited format (yaml?
 json? something!) so that they can be formed into translatable sentences
 after they are extracted from the database. I would be willing to work on
 this if an issue gets made!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.21f21038608b0586519bbe64a7101169%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:  jooyous
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jooyous):

 Hellooo I am still working on this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.4265f005aa68ab450819e14c78e7ee19%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:  jooyous
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jooyous):

 Replying to [comment:6 anonymous]:
 > I can't get ugettext to translate "Changed" for some reason, even though
 there are bits of code where it does it successfully and I'm not sure what
 I'm doing wrong.

 Whoops, that was me. Didn't realize I was logged out.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.0991b5d256eadc2871c17dae9fb9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:  jooyous
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by anonymous):

 I can't get ugettext to translate "Changed" for some reason, even though
 there are bits of code where it does it successfully and I'm not sure what
 I'm doing wrong.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.25c2cb21922a7144d866c2789536a8d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:  jooyous
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 Fixing existing history might be impossible to achieve. I wouldn't set
 that as a goal for this ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.c9b65c674dcc72d4b2b068f944aa2ed5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:  jooyous
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jooyous):

 So at this point I understand how to change this so all subsequent log
 entries behave correctly. But currently the translated strings are being
 saved away as part of the object, and I think (?) this means we've lost
 the information of the starting language, so the only way I can think of
 fixing *existing* histories is by writing a script and having the user run
 it, specifying their relevant languages?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.30c42acb6d2f97bd22c2c67c337c46d0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:  jooyous
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by jooyous):

 * owner:  nobody => jooyous
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.8f8ab9df15aaeb4cebc55a7a831cbdef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * type:  Uncategorized => New feature


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.0e160e7bfda9a71a78a9a01c78ec0625%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21113: django_admin_log table stores messages in different languages depending on which language was active while editing.

[Django]

#21113: django_admin_log table stores messages in different languages depending 
on
which language was active while editing.
-+
 Reporter:  dimyur27@…   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  admin logs i18n  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by wim@…):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * version:  1.6-beta-1 => master
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Accepted. I'd like messages to be language-agnostic and translatable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.544bfced579558f9fa9a575c50eb7c33%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.