Re: [Django] #21235: 1.6: Suggest installing standalone pysqlite2 on Windows when using Python 2.6

2013-10-07 Thread Django 
#21235: 1.6: Suggest installing standalone pysqlite2 on Windows when using 
Python
2.6
---+--
 Reporter:  ramiro |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  1.6-beta-1
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Aymeric Augustin ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"b42f0665a8cc25869c8dbc7bb71927b7ea61f81c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b42f0665a8cc25869c8dbc7bb71927b7ea61f81c"
 [1.6.x] Fixed #21235 -- Disabled savepoints for old versions of SQLite.

 Thanks Ramiro for the report.

 Backport of 91547772 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9e446626ecca168b4fce06130eee2d46%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21235: 1.6: Suggest installing standalone pysqlite2 on Windows when using Python 2.6

2013-10-07 Thread Django 
#21235: 1.6: Suggest installing standalone pysqlite2 on Windows when using 
Python
2.6
---+--
 Reporter:  ramiro |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Documentation  |  Version:  1.6-beta-1
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Aymeric Augustin ):

 In [changeset:"91547772e04e456f45c7ef86e1f76d087821c89d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="91547772e04e456f45c7ef86e1f76d087821c89d"
 Fixed #21235 -- Disabled savepoints for old versions of SQLite.

 Thanks Ramiro for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d9bea89891bad06fffe52d88e22a5dd5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21235: 1.6: Suggest installing standalone pysqlite2 on Windows when using Python 2.6

2013-10-06 Thread Django 
#21235: 1.6: Suggest installing standalone pysqlite2 on Windows when using 
Python
2.6
---+--
 Reporter:  ramiro |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.6-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by ramiro):

 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Tes, the proposed patch solves the reported problems.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5348d9803a82e35b7563a6c08b920263%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21235: 1.6: Suggest installing standalone pysqlite2 on Windows when using Python 2.6

2013-10-06 Thread Django 
#21235: 1.6: Suggest installing standalone pysqlite2 on Windows when using 
Python
2.6
---+--
 Reporter:  ramiro |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  1.6-beta-1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by aaugustin):

 Are you able to test the following patch?
 {{{
 diff --git a/django/db/backends/sqlite3/base.py
 b/django/db/backends/sqlite3/base.py
 index ac2376a..ef21423 100644
 --- a/django/db/backends/sqlite3/base.py
 +++ b/django/db/backends/sqlite3/base.py
 @@ -393,12 +393,16 @@ class DatabaseWrapper(BaseDatabaseWrapper):
  BaseDatabaseWrapper.close(self)

  def _savepoint_allowed(self):
 +# Two conditions are required here:
 +# - A sufficiently recent version of SQLite to support
 savepoints,
 +# - Being in a transaction, which can only happen inside
 'atomic'.
 +
  # When 'isolation_level' is not None, sqlite3 commits before each
  # savepoint; it's a bug. When it is None, savepoints don't make
 sense
 -# because autocommit is enabled. The only exception is inside
 atomic
 -# blocks. To work around that bug, on SQLite, atomic starts a
 +# because autocommit is enabled. The only exception is inside
 'atomic'
 +# blocks. To work around that bug, on SQLite, 'atomic' starts a
  # transaction explicitly rather than simply disable autocommit.
 -return self.in_atomic_block
 +return self.features.uses_savepoints and self.in_atomic_block

  def _set_autocommit(self, autocommit):
  if autocommit:
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ef00960ac2ba3255b6c263a407f5774b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.