Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
-+-
 Reporter:  Tim Graham   |Owner:  Tim
 |  Graham 
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"194ca77092a2507a57c288c35b279eb2cb4a64fb" 194ca770]:
 {{{
 #!CommitTicketReference repository=""
 revision="194ca77092a2507a57c288c35b279eb2cb4a64fb"
 Refs #21275 -- Added more tests for @deconstructible decorator.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.1fdd48907bbd0b4564a921e8521ddbf9%40djangoproject.com.

Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
-+-
 Reporter:  timo |Owner:  Tim
 Type:  Bug  |  Graham 
Component:  Migrations   |   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:  fixed
Has patch:  1| Triage Stage:
  Needs tests:  0|  Unreviewed
Easy pickings:  0|  Needs documentation:  0
 |  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by erikr):

 I've included this in the release notes with
 
https://github.com/django/django/commit/4d0c5f61427a8e67552ee2d777fffbadc7aff3b2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a46b6d52427b4450f734a7fc14512bbc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
-+-
 Reporter:  timo |Owner:  Tim
 Type:  Bug  |  Graham 
Component:  Migrations   |   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:  fixed
Has patch:  1| Triage Stage:
  Needs tests:  0|  Unreviewed
Easy pickings:  0|  Needs documentation:  0
 |  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by blueyed):

 Please note that there is #22255, which is about adding a new `flags`
 kwarg.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ab21a0d392c36ed520d38b23d1ed117c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
-+-
 Reporter:  timo |Owner:  Tim
 Type:  Bug  |  Graham 
Component:  Migrations   |   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:  fixed
Has patch:  1| Triage Stage:
  Needs tests:  0|  Unreviewed
Easy pickings:  0|  Needs documentation:  0
 |  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by erikr):

 Shouldn't this also be added to the release notes? If anyone has their own
 model with a custom RegexValidator where they currently pass a compiled
 regex, they'll need to pass a string now, or they will also hit this
 issue, right?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d561446971032cf830ab3cd2f99b227c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
-+-
 Reporter:  timo |Owner:  Tim
 Type:  Bug  |  Graham 
Component:  Migrations   |   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:  fixed
Has patch:  1| Triage Stage:
  Needs tests:  0|  Unreviewed
Easy pickings:  0|  Needs documentation:  0
 |  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Tim Graham ):

 * owner:   => Tim Graham 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e565e1332ddfbb44fe7e6139375e3c243af7398d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="e565e1332ddfbb44fe7e6139375e3c243af7398d"
 Fixed #21275 -- Fixed a serializer error when generating migrations for
 contrib.auth.

 The migration serializer now looks for a deconstruct method on any object.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b1ee6f74b0a22d2db332f6bcb33a8474%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
+--
 Reporter:  timo|Owner:
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by loic84):

 * needs_tests:  1 => 0


Comment:

 PR https://github.com/django/django/pull/1783.

 Note that this will be needed if/when #21295 is merged.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d09d3de2edfbe7782ccc1a4bdd2ec70d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
+--
 Reporter:  timo|Owner:
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by loic84):

 Another POC around the concept of a `deconstructible` decorator.

 https://github.com/loic/django/tree/ticket21275_take2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.72a939528680397ad7a3bac6f3b52c8e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
+--
 Reporter:  timo|Owner:
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by loic84):

 * cc: loic@… (added)
 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 POC https://github.com/loic/django/compare/ticket21275.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.132e30c325c398f9b3ca52b3698fc062%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21275: Cannot use migrations if model field specifies validators

[Django]

#21275: Cannot use migrations if model field specifies validators
+--
 Reporter:  timo|Owner:
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by timo):

 After discussion with loic84 in #django-developers, it appears that
 validators should be serializable and that this error is due to the regex
 used by the username field of `contrib.auth.models.AbstractUser` not being
 serializable. Loic says validators may be useful for data migrations,
 hence a possible reason not to exclude them entirely.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.5c6e6f6f2b70773fd7333ae1cb2b6f8a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.