Re: [Django] #21476: Cache tests make an incorrect use of `HttpRequest`

[Django]

#21476: Cache tests make an incorrect use of `HttpRequest`
-+-
 Reporter:  unaizalakain |Owner:
 Type:   |  unaizalakain
  Cleanup/optimization   |   Status:  closed
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  tests, cache,| Triage Stage:  Accepted
  request|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by unaizalakain):

 Thanks for the review!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.7874db38b3798c9b396027de00c76e19%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21476: Cache tests make an incorrect use of `HttpRequest`

[Django]

#21476: Cache tests make an incorrect use of `HttpRequest`
-+-
 Reporter:  unaizalakain |Owner:
 Type:   |  unaizalakain
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  tests, cache,| Triage Stage:  Accepted
  request|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by unaizalakain):

 * needs_better_patch:  1 => 0


Comment:

 PR updated, all the `_get_request` mess has been substituted by
 `django.test.client.RequestFactory` ;)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.b344042d136115b5703b67093f5dab6b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21476: Cache tests make an incorrect use of `HttpRequest`

[Django]

#21476: Cache tests make an incorrect use of `HttpRequest`
-+-
 Reporter:  unaizalakain |Owner:
 Type:   |  unaizalakain
  Cleanup/optimization   |   Status:  closed
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  tests, cache,| Triage Stage:  Accepted
  request|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Baptiste Mispelon ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2b4bed6dbd864ce78e9300f28b05045c386cd248"]:
 {{{
 #!CommitTicketReference repository=""
 revision="2b4bed6dbd864ce78e9300f28b05045c386cd248"
 Fixed #21476 -- Cache tests make an incorrect use of `HttpRequest`

 Using `django.test.client.RequestFactory` solves the problem and cleans up
 all
 the `get_request` mess.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.82369fe05dfe4b99047f3c36dac5122e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21476: Cache tests make an incorrect use of `HttpRequest`

[Django]

#21476: Cache tests make an incorrect use of `HttpRequest`
-+-
 Reporter:  unaizalakain |Owner:
 Type:   |  unaizalakain
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  tests, cache,| Triage Stage:  Accepted
  request|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by bmispelon):

 * cc: bmispelon (added)
 * needs_better_patch:  0 => 1
 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Yes, it seems that the tests have accumulated some cruft over the years
 and they could use some cleaning up.
 I'm accepting the ticket on this basis.

 In particular (though the list is probably not exhaustive):
 * Use `django.test.RequestFactory` instead of manually constructing
 `HttpRequest` objects
 * Get rid of the various inconsistent `_get_request` method on the test
 cases (they have different signatures, some prepend `self.path` and others
 don't, ...)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.e77c4487bb85e9adfa0bcae294ba6657%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21476: Cache tests make an incorrect use of `HttpRequest`

[Django]

#21476: Cache tests make an incorrect use of `HttpRequest`
-+-
 Reporter:  unaizalakain |Owner:
 Type:  Bug  |  unaizalakain
Component:  Core (Cache system)  |   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  tests, cache,|   Resolution:
  request| Triage Stage:
Has patch:  1|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by unaizalakain):

 * has_patch:  0 => 1


Comment:

 PR sent: https://github.com/django/django/pull/1950

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.ef7287f691c7f318180f2de7905bd91a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21476: Cache tests make an incorrect use of `HttpRequest`

[Django]

#21476: Cache tests make an incorrect use of `HttpRequest`
-+-
 Reporter:  unaizalakain |Owner:
 Type:  Bug  |  unaizalakain
Component:  Core (Cache system)  |   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  tests, cache,|   Resolution:
  request| Triage Stage:
Has patch:  0|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by unaizalakain):

 * owner:  nobody => unaizalakain
 * needs_docs:   => 0
 * status:  new => assigned
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.756531d05aedf95272781a2b49b9655c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.