Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+-
 Reporter:  timo |Owner:  berkerpeksag
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Baptiste Mispelon ):

 In [changeset:"a9215b7c36bff232bcc9416309726290dc74a9e8" a9215b7c]:
 {{{
 #!CommitTicketReference repository=""
 revision="a9215b7c36bff232bcc9416309726290dc74a9e8"
 Refs #21548 -- Skipped tests that rely on pillow when it's not installed
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ef480a3278b0ab3104747702e09d68d1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+-
 Reporter:  timo |Owner:  berkerpeksag
 Type:  New feature  |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"12b4280444b58c94197255655e284e4103fe00a9" 12b4280]:
 {{{
 #!CommitTicketReference repository=""
 revision="12b4280444b58c94197255655e284e4103fe00a9"
 Fixed #21548 -- Added FileExtensionValidator and
 validate_image_file_extension.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.33dcad538d3c2d5c189e6b7676a0b550%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+-
 Reporter:  timo |Owner:  berkerpeksag
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.2aab29bff8e422cad15067a1663152cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+
 Reporter:  timo |Owner:  berkerpeksag
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Left some comments for improvement.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a694b323d537519f05f1c089d94bd85f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+
 Reporter:  timo |Owner:  berkerpeksag
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by berkerpeksag):

 * cc: berker.peksag@… (added)
 * needs_better_patch:  1 => 0
 * owner:  jfilipe => berkerpeksag
 * needs_docs:  1 => 0


Comment:

 Pull request: https://github.com/django/django/pull/6343

 Changes:

 * Added two validators: FileExtensionValidator and validate_image_file
 (this one uses FileExtensionValidator with default values from
 PIL.Image.EXTENSION).
 * Added validate_image_file to ImageField as a default validator.
 * Added tests for FileExtensionValidator, model and form validations.
 * Added documentation and release notes. I probably need to add some note
 for ImageField docs too.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3b5566444862fd2b19990d71903fd075%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+
 Reporter:  timo |Owner:  jfilipe
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by anubhav9042):

 * cc: anubhav9042@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a585a0e6fa6892675640d6932f7f46fb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+
 Reporter:  timo |Owner:  jfilipe
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by anubhav9042):

 The patch looks good but the validator must be like others as Tim
 suggested on your PR.
 Also adding it to `ImageField` by default sounds good. I hope we can fix
 #18543 with it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.9a55c6aaf61c8ee194d1adc27c05db2a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+
 Reporter:  timo |Owner:  jfilipe
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 Hi, I left a comment for improvement on the PR, although it's better to
 open a PR against Django itself instead of your fork.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b92043682747c185e493a4374930%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+
 Reporter:  timo |Owner:  jfilipe
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by jfilipe):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a7d2f6b1138256f991f35045f7573734%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+
 Reporter:  timo |Owner:  jfilipe
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jfilipe):

 I have a work in progress PR here:
 https://github.com/jfilipe/django/pull/2

 Wanted to get some feedback on the approach before I added some docs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a79edfdd59de08ff8f5fcc3859ed1ea8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21548: Add the ability to limit file extensions for ImageField and FileField

[Django]

#21548: Add the ability to limit file extensions for ImageField and FileField
-+
 Reporter:  timo |Owner:  jfilipe
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by jfilipe):

 * owner:  nobody => jfilipe
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b84091198ebb55c2cedf26f29e6265a5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.