Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  multiple-| Triage Stage:  Accepted
  inheritance|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I guess this issue has since been fixed (unless the regression tests in
 the second pull request don't capture the issue). Please open a new ticket
 if issues remain, thanks!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d94511365fbe4ae45d31471567c202db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  multiple-| Triage Stage:  Accepted
  inheritance|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"7eb513ab0f761fe88aa4d3579fdf8706741f2239" 7eb513ab]:
 {{{
 #!CommitTicketReference repository=""
 revision="7eb513ab0f761fe88aa4d3579fdf8706741f2239"
 Refs #21554 -- Added some assertions to a model_inheritance_regress test.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.18ae0fa924141884e00506c95efba24a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  multiple-|  Needs documentation:  0
  inheritance|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by timo):

 I left comments for improvement on PR. Please uncheck "Patch needs
 improvement" when you update it, thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0b14be93e318a8b3d4376868ea713734%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  multiple-|  Needs documentation:  0
  inheritance|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by mitchell):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 Test needs to be extended to test that the title is correct. Currently the
 patch replaces all fields from non-primary classes with the ID. Also, the
 second base was not being joined to the query correctly.

 Second pull request here: https://github.com/django/django/pull/2059

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5e9aaa58ea4f5141b9656c48e4b2465b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  multiple-|  Needs documentation:  0
  inheritance|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by Simon Charette ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"38e24d680d28b92997def9ab46a961d09bb81dce"]:
 {{{
 #!CommitTicketReference repository=""
 revision="38e24d680d28b92997def9ab46a961d09bb81dce"
 Fixed #21554 -- Incorrect SQL generated when using multiple inheritance.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3e0ff97aee8cf897efcc8ac86397%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  multiple-|  Needs documentation:  0
  inheritance|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by pegler):

 Thanks for reviewing.  I made the suggested changes.  Tests continue to
 pass fully.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d469b53695a5d9031f434c62bc3184e9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  multiple-|  Needs documentation:  0
  inheritance|  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by charettes):

 * needs_better_patch:  0 => 1


Comment:

 I added comments on PR. Apart from the minor suggested changes the patch
 looks RFC; full test suite passes on SQLite3 Py2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.005c8a1c5f9a083d07c12e3a9da98f08%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  multiple-|  Needs documentation:  0
  inheritance|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by pegler):

 * has_patch:  0 => 1


Comment:

 I packaged up mitchell's patch into a pull request here:
 https://github.com/django/django/pull/2034

 I don't know enough about Django to know the implications of making that
 change to get_default_columns, but I guess that's why I don't have that
 commit bit.  The test suite did pass after the change:

 {{{
 Ran 6295 tests in 325.761s

 OK (skipped=419, expected failures=8)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ab8809cc47a9fefee12a85dbe6cf7820%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  multiple-|  Needs documentation:  0
  inheritance|  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * stage:  Unreviewed => Accepted


Comment:

 I haven't investigated but the report looks legitimate. Obviously a proper
 patch with tests will help get this fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0059124cf1780b0cd26fb5cfcb265f4d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  multiple-|  Unreviewed
  inheritance|  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by pegler):

 I can confirm that patch works on 1.6.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.671114ab3ce5a2a2c5d40dc7edd81dcc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21554: incorrect SQL generated when using multiple inheritance

[Django]

#21554: incorrect SQL generated when using multiple inheritance
-+-
 Reporter:  pegler   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  multiple-|  Unreviewed
  inheritance|  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by mitchell):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I've also stumbled onto this one today.

 I've made [https://gist.github.com/mitchellrj/7792290 a gist] of a
 rudimentary module with a quick and dirty monkey patch for Django 1.6.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e265c30f29715b3e28d18dacda8c505d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.