Re: [Django] #21734: Admin doesn't catch ProtectedError

[Django]

#21734: Admin doesn't catch ProtectedError
---+-
 Reporter:  sander@…   |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  needsinfo
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by timo):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Closing as needsinfo absent additional details from the reporter.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.9bb4c38d0bc398119231b4117c8ba61b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21734: Admin doesn't catch ProtectedError

[Django]

#21734: Admin doesn't catch ProtectedError
---+
 Reporter:  sander@…   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by anubhav9042):

 As far as I know that intermediate page has nothing to do here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.bf8b2f1e436cdf84d55597e856be25dd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #21734: Admin doesn't catch ProtectedError

[Django]

#21734: Admin doesn't catch ProtectedError
---+
 Reporter:  sander@…   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by afuna):

 It does not appear to the be the same as #19838; this ticket looks like
 it's for  "delete all selected" dropdown from the top of the page.

 The good thing is, there does appear to be some protection in place
 already. You have to go through an intermediate page to confirm, and if a
 protected (nested) object is detected, then the button to confirm deletion
 is simply not there, so you normally can't do a delete.

 You can still trigger the ProtectedError by skipping the intermediate
 page, that might be what happened here. The other possibility is that the
 check for protected via get_deleted_objects is missing something (but
 without more information that'll be harder to track down)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.6ff240e5a6fd0465d54c22abb0525941%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21734: Admin doesn't catch ProtectedError

[Django]

#21734: Admin doesn't catch ProtectedError
---+
 Reporter:  sander@…   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by anubhav9042):

 Replying to [comment:2 timo]:
 > Is this error present on 1.6 and/or master? Is the issue different from
 #19838? A regression test will be required in order to commit the fix.

 I can't see ProtectedError being handled anywhere in actions.py in master.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.894d30b0cbf4b71bebf9460393f493f8%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21734: Admin doesn't catch ProtectedError

[Django]

#21734: Admin doesn't catch ProtectedError
---+
 Reporter:  sander@…   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * stage:  Unreviewed => Accepted


Comment:

 Tentatively accepting pending an answer to the above question.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.373a11b334379628aa44c49d5a5d4f37%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21734: Admin doesn't catch ProtectedError

[Django]

#21734: Admin doesn't catch ProtectedError
---+--
 Reporter:  sander@…   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by timo):

 * needs_tests:  0 => 1
 * easy:  1 => 0


Comment:

 Is this error present on 1.6 and/or master? Is the issue different from
 #19838? A regression test will be required in order to commit the fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.3f9b7a94b7cf11086369e6a0fd953e32%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #21734: Admin doesn't catch ProtectedError

[Django]

#21734: Admin doesn't catch ProtectedError
---+--
 Reporter:  sander@…   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by steffann):

 * cc: steffann (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.cb38e6d5898ba089f73fa6e8a930add3%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.