Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"45edb9d2359c60952fd791616df887eb95f75746"]:
 {{{
 #!CommitTicketReference repository=""
 revision="45edb9d2359c60952fd791616df887eb95f75746"
 Fixed #22057 -- Ensured reverse_lazy can be used in settings

 And without causing a circular import. Thanks Akis Kesoglou for
 the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.442f3a5dbe0b95276bb4558039453675%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by claudep):

 I think the problem is caused by two lines here:
 
https://github.com/django/django/blob/master/django/db/models/sql/aggregates.py#L14-15

 It shouldn't be too difficult to defer these instanciations. I'll attach a
 patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.46b5ad6ceaa0bcbd382376e7202162ab%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by aaugustin):

 Such patches are fragile. We try to keep imports properly ordered at the
 top of modules. After a few years it becomes unclear why a specific import
 doesn't happen at module level, and if it's still needed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f398aef7ce68ae5a9f41b996b97712c9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by dfunckt):

 Added another patch, fixing the issue by lazily importing
 {{{DjangoJSONEncoder}}} inside {{{JSONResponse.__init__}}}.

 I'm not sure how to go about testing for this regression in order to
 provide a complete patch, so if anyone has any pointers it would help.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a43d77d52a4d9abf780b9c11c206de55%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by anonymous):

 I think it's better to just move the !DjangoJSONEncoder into the
 JSONResponse

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.75efa2c110482a7fec1b2eedd12239ab%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by dfunckt):

 Added a quick patch that fixes the issue. Run tests with sqlite, all pass.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e906fd2003cdef8d4babf6137baa45b5%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by dfunckt):

 I attached a test project. Using Django@master, Python 3.3.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.965c62090e8459ee805c671c040b0adb%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by gnosek):

 Cannot reproduce even though there is a clear circular import. Does
 anybody have a self-contained app showing the problem?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.896f7a9009275066420f37bf5bdbff74%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22057: Importing `reverse_lazy` in settings.py leads to ImportError

[Django]

#22057: Importing `reverse_lazy` in settings.py leads to ImportError
-+
 Reporter:  dfunckt  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by dfunckt):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Marking as accepted as discussed with apollo13

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.497e1a28960a4197c5824ed3c6537a8e%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.