Re: [Django] #22087: ModelForm Meta overrides are ignored by AdminReadonlyField

[Django]

#22087: ModelForm Meta overrides are ignored by AdminReadonlyField
---+
 Reporter:  bendavis78 |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by timo):

 We could backport the fix to 1.6.x as it's a bug in a new feature, but I
 haven't done so because there were several conflicts. Feel free to send a
 PR for that along with a note in the 1.6.3 release notes if you'd like.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.112ae109dc5e98c458f70275be332f3d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22087: ModelForm Meta overrides are ignored by AdminReadonlyField

[Django]

#22087: ModelForm Meta overrides are ignored by AdminReadonlyField
---+
 Reporter:  bendavis78 |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"24604844866a0b28122a1c47ac85072ea05b9b71"]:
 {{{
 #!CommitTicketReference repository=""
 revision="24604844866a0b28122a1c47ac85072ea05b9b71"
 [1.7.x] Fixed #22087 -- Made AdminReadonlyField respect ModelForm Meta
 overrides.

 Backport of 16afe8 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2ea83ea3f719552556dcd191161513f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22087: ModelForm Meta overrides are ignored by AdminReadonlyField

[Django]

#22087: ModelForm Meta overrides are ignored by AdminReadonlyField
---+
 Reporter:  bendavis78 |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"16afe87bf8b7de6403329937433ac5096697"]:
 {{{
 #!CommitTicketReference repository=""
 revision="16afe87bf8b7de6403329937433ac5096697"
 Fixed #22087 -- Made AdminReadonlyField respect ModelForm Meta overrides.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.112ee6ba69219ffc4b6fecd320591d9f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22087: ModelForm Meta overrides are ignored by AdminReadonlyField

[Django]

#22087: ModelForm Meta overrides are ignored by AdminReadonlyField
---+
 Reporter:  bendavis78 |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by anonymous):

 Has there been any update on this?

 Thanks,
 Dan

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a7db579a618d0628e7203218bcd46461%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22087: ModelForm Meta overrides are ignored by AdminReadonlyField

[Django]

#22087: ModelForm Meta overrides are ignored by AdminReadonlyField
---+
 Reporter:  bendavis78 |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by bendavis78):

 * has_patch:  0 => 1


Comment:

 Hmm, I'm not sure how you could avoid custom logic in the
 AdminReadonlyField for this. This bug is only relevant to the admin, which
 already creates wrappers around every field. The bug is in the wrapper
 itself, not with the forms.

 At any rate, I've created a pull request for a fix, with tests. Let me
 know what you think.

 https://github.com/django/django/pull/2323

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0c4acb098727be83e158c69f2bafb4a9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22087: ModelForm Meta overrides are ignored by AdminReadonlyField

[Django]

#22087: ModelForm Meta overrides are ignored by AdminReadonlyField
---+
 Reporter:  bendavis78 |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by timo):

 * stage:  Unreviewed => Accepted


Comment:

 I think the ideal solution would be to get rid of custom logic in
 `AdminReadonlyField` as much as possible, adding functionality to
 `django.forms` as necessary.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.758e5f6aaf702599dac00bd25e5a8f5b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22087: ModelForm Meta overrides are ignored by AdminReadonlyField

[Django]

#22087: ModelForm Meta overrides are ignored by AdminReadonlyField
---+--
 Reporter:  bendavis78 |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by bendavis78):

 * cc: bendavis78 (added)
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9e4b8dde00a6179c4a570e28dcbb9ba0%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.