Re: [Django] #22168: Sqlite3 backend fails during _remake_table with column named "order"

2014-03-01 Thread Django 
#22168: Sqlite3 backend fails during _remake_table with column named "order"
-+-
 Reporter:  netwamp@…|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Baptiste Mispelon ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c679cb7f600b13646a1a2b5fc8a03dfcc2e413f2"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c679cb7f600b13646a1a2b5fc8a03dfcc2e413f2"
 Fixed #22168 -- Fixed migrations failing on sqlite when column names are
 SQL keywords

 Thanks to trac user fallen_flint for the report and initial patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.1cad7632bc5c2c646ce0b1c80dfb8d44%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22168: Sqlite3 backend fails during _remake_table with column named "order"

2014-02-28 Thread Django 
#22168: Sqlite3 backend fails during _remake_table with column named "order"
-+-
 Reporter:  netwamp@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by timo):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.10926b33c53e10642f135e05ed45ae80%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22168: Sqlite3 backend fails during _remake_table with column named "order"

2014-02-28 Thread Django 
#22168: Sqlite3 backend fails during _remake_table with column named "order"
-+
 Reporter:  netwamp@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by bmispelon):

 * needs_tests:  1 => 0


Comment:

 Tentative pull request (with tests) here:
 https://github.com/django/django/pull/2378

 Reviews welcome.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.47c71fb6d1a723f507ff0a7058d67e43%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22168: Sqlite3 backend fails during _remake_table with column named "order"

2014-02-28 Thread Django 
#22168: Sqlite3 backend fails during _remake_table with column named "order"
-+
 Reporter:  netwamp@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by claudep):

 * component:  Database layer (models, ORM) => Migrations


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.90fdef25640ebc689a0ee0bf4fc4084b%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22168: Sqlite3 backend fails during _remake_table with column named "order"

2014-02-28 Thread Django 
#22168: Sqlite3 backend fails during _remake_table with column named "order"
-+-
 Reporter:  netwamp@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by bmispelon):

 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Hi,

 I can reproduce the issue by doing the following:

 1) Create a model with a field called `order`.
 2) Run `makemigrations`. This creates a first migration file.
 3) Add another field to the model created in 1)
 4) Run `makemigrations` again. This creates a second migration file.
 5) Attempt to run `migrate`. This fails with the reported error.

 Your proposed fix looks sensible and it works for the reported issue but a
 full patch should have some tests too.

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.09e96769218f8a16ef297a603b0b01bd%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #22168: Sqlite3 backend fails during _remake_table with column named "order"

2014-02-28 Thread Django 
#22168: Sqlite3 backend fails during _remake_table with column named "order"
-+-
 Reporter:  netwamp@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by fallen_flint):

 * needs_better_patch:   => 0
 * type:  Uncategorized => Bug
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.1f662ebe4565d35a59ed013690bc122c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.