Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  closed
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Tim Graham ):

 In [changeset:"aba74d6f1e221c10be2798f55971d710521cb404"]:
 {{{
 #!CommitTicketReference repository=""
 revision="aba74d6f1e221c10be2798f55971d710521cb404"
 [1.8.x] Fixed escaping regression in urlize filter.

 Now that the URL is always unescaped as of refs #22267,
 we should re-escape it before inserting it into the anchor.

 Backport of 7b1a67cce52e5c191fbfa1bca501c6f0222db019 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.aec020ed290dfc6add5393e741b84c55%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  closed
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Tim Graham ):

 In [changeset:"7b1a67cce52e5c191fbfa1bca501c6f0222db019"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7b1a67cce52e5c191fbfa1bca501c6f0222db019"
 Fixed escaping regression in urlize filter.

 Now that the URL is always unescaped as of refs #22267,
 we should re-escape it before inserting it into the anchor.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.61ce665f1c9ad9c60de103f31effca65%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  closed
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Claude Paroz ):

 In [changeset:"ac07890f959c467b3fc9c6dd6d36aafc2eff1fcc"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ac07890f959c467b3fc9c6dd6d36aafc2eff1fcc"
 [1.8.x] Fixed urlize regression with entities in query strings

 Refs #22267.
 Thanks Shai Berger for spotting the issue and Tim Graham for the
 initial patch.
 Backport of ec808e807 from master.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.08d8ab557862425db9553a009a22d493%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  closed
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Claude Paroz ):

 In [changeset:"ec808e807ad711b993f199f6b4165ac6d0e1125b"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ec808e807ad711b993f199f6b4165ac6d0e1125b"
 Fixed urlize regression with entities in query strings

 Refs #22267.
 Thanks Shai Berger for spotting the issue and Tim Graham for the
 initial patch.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.8874c8923a86af2030f28361a93aa082%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  closed
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Claude Paroz ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"4b8a1d2c0d1a8c5107f3aef01597db78d2a2a5ce"]:
 {{{
 #!CommitTicketReference repository=""
 revision="4b8a1d2c0d1a8c5107f3aef01597db78d2a2a5ce"
 Fixed #22267 -- Fixed unquote/quote in smart_urlquote

 Thanks Md. Enzam Hossain for the report and initial patch, and
 Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.4cb5d88054542f999a4c4d8771c3d05e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  closed
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Claude Paroz ):

 In [changeset:"b9d9287f59eb5c33dd8bc81179b4cf197fd54456"]:
 {{{
 #!CommitTicketReference repository=""
 revision="b9d9287f59eb5c33dd8bc81179b4cf197fd54456"
 Fixed urlize after smart_urlquote rewrite

 Refs #22267.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.381ba81fd97cb2ed737d0e2c4d465a14%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by kevin-brown):

 * cc: kevin-brown (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.1e18ec74e9c44d09de5b9a4bc1c1497d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by claudep):

 Interesting case, but I think this should be a separate issue. This ticket
 is fixing the query string problem.

 Your example might be solved by short-circuiting the `unquote` part if the
 URL contains any non-safe character.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.ab7a861e5b2e94538986989f1f2aa721%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by ienzam):

 Thank you for doing this. This patch fixes all of the problems I was
 facing.

 One concern is though about the url: {{{ http://example.com/%C3%B6/ä/ }}}
 The last part of the url {{{ ä }}} implies that this url is not quoted so
 the full url should be quoted - {{{ http://example.com/%25C3%25B6/%C3%A4/
 }}}
 Currently it becomes: {{{ http://example.com/%C3%B6/%C3%A4/ }}}
 But maybe this is not a real life scenario (hopefully).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.dde9600827304a5f7af790344985cfe3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by ienzam):

 I will test the with the tests from here tomorrow -
 
https://github.com/ienzam/django/commit/be378e404bedd169bb48ab945e5fd90e90a00d1e

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.4d922c3310a2bb6263b44399c9a80e98%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+-
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Ready for checkin
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


Comment:

 @meenzam, perhaps you'd like to review this as well before we merge it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.162441d6b523c6e18e7c43453c2e8f28%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.647b0c39b4f753d7e79f43d29b5189c7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * needs_better_patch:  0 => 1


Comment:

 PR has some test failures.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.bb2f20a242f18d3da751a8727d5a5ff4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


Comment:

 I have chosen a slightly different approach, keeping the unquote/quote
 process but on the separate parts as ienzam proposed.
 https://github.com/django/django/pull/2902

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.6ef4ca6e112ccffd9264cf4a171fe571%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by ienzam):

 If None is returned then
 
https://github.com/ienzam/django/blob/be378e404bedd169bb48ab945e5fd90e90a00d1e/django/utils/html.py#L274
 "if url:" will be false and the invalid url will be treated as text.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.8b5bf505811121a572de5e534ea95321%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by bendavis78):

 I'm just curious, is there a precedent for returning None when there's an
 error? Normally if there's an exception, it should bubble up, or a more
 specific one should be raised.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.381852b89caea9de51713a14e9ae50e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by meenzam@…):

 Any update?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.0ed7e27fee7a3d13eba367b9a35ed627%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  ienzam
 Type:  Bug|   Status:  assigned
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by ienzam):

 * status:  new => assigned
 * owner:  nobody => ienzam
 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 Can you look at my patch? Merged all the changes into this one -
 
https://github.com/ienzam/django/commit/be378e404bedd169bb48ab945e5fd90e90a00d1e

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.0878cf0331a679d61169cc4a1f432dab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by ienzam):

 Read the bug and ticket.
 From RFC 2396 ([http://www.ietf.org/rfc/rfc2396.txt]), valid characters
 for different parts of the url are following:
 path => {{{Alphanumeric and /;-_.!~*'():@&=+$,}}}
 query and fragment => {{{Alphanumeric and /;-_.!~*'():@&=+$,?}}} (only
 differs from path with an extra {{{?}}})

 Can we not unquote and quote again because it can introduce some corner
 cases.
 We can check if the url is already quoted or not (which was done till
 v1.4).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.a26fcfab46a411ad57922ffae5fd55eb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by erikr):

 You might want to have a look at #3 and
 http://bugs.python.org/issue2637 regarding which characters should be safe
 for which segments of the URL.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.8a4fe02add321d9f426484978bd12ed5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
---+
 Reporter:  meenzam@…  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Utilities  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by erikr):

 * component:  Template system => Utilities


Comment:

 That commit is built upon your previous patch, so it's very hard for me to
 review. At first sight, I don't think that inline function is really
 necessary, given how simple it is. But the rest I can't really review in
 this way. Also, it would be good to have some tests for how urlize handles
 the invalid URLs for which you now want to return None, as that behaviour
 should not change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.7068c2b063634ad21cc626e5a781734e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by ienzam):

 Wrote a new patch -
 
https://github.com/ienzam/django/commit/c22ce94588243da76b01e064ca36c9e63b0b54a2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.3f8ab3eedf7f7e5dbab1823991fd4e5c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by meenzam@…):

 Then I will suggest to return None from {{{smart_urlquote()}}} in case of
 any exception, then {{{urlize()}}} will not think the string as an url and
 will show text only.
 Also not only path, but also query parameter and fragment should be quoted
 (because they may contain ").

 For query string, we may first {{{parse_qs()}}} and then individually
 encode each key value pairs and remake the query string.
 For fragment, We can do the same as path (unquoting and quoting again).
 Not perfect solution though because some sites store query parameters in
 fragments.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.8a3c59ef90152d0361c33e979e9e1ce1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by erikr):

 By which I don't mean that this particular issue should not be fixed
 anymore, in case I was ambiguous - it is definitely a bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.be4a3f4d9838d4822419b9a7456a0f14%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by erikr):

 The formal description is whatever is documented. However, developers may
 depend on other details of its behaviour, which we should not change if it
 is not necessary.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.428c1e7c4e86937d070daae3dfaa77a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by meenzam@…):

 * has_patch:  1 => 0


Comment:

 Hmm, yes the commit is wrong, urlize() will not always escape.

 Can you provide the intended behaviour of urlize()? It will then be easier
 to fix when we have a set goal. Currently it is not totally clear what is
 the correct behaviour of urlize() and smart_urlquote().

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.316c56a234950df971edef953812f1bc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by erikr):

 * needs_better_patch:  0 => 1


Comment:

 In that patch however, the conditions are altered: quoting is not
 performed if any exception is raised and caught. This does not appear to
 be part of the tests, so they still all succeed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.435d7ff0a8e120a9936337cc0a54b47c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by meenzam@…):

 * cc: meenzam@… (added)
 * has_patch:  0 => 1


Comment:

 The simple fix will be to unquote and quote only the path of the url, I
 have

 
https://github.com/ienzam/django/commit/692ac89689dd9ddf5895bfaf0181434c5daf81e9

 This passes the current unit tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.1e005894e045bda3d6a72bf031d9d946%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by anonymous):

 This is the commit which introduced unquote
 
https://github.com/django/django/commit/b70c371fc1f18ea0c43b503122df3f311afc7105

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.3bd32d9a1ec78bdb6caa6d02897caadb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url

[Django]

#22267: django.utils.html.smart_urlquote() is incorrectly unquoting the url
-+
 Reporter:  meenzam@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by erikr):

 * needs_better_patch:   => 0
 * version:  1.5 => master
 * needs_tests:   => 0
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 It would seem the purpose of its current implementation is that a URL
 which is already quoted is not quoted again, but an unquoted URL will be
 quoted. The context in which this is applied, is django.utils.html.urlize.
 This was added in #9655
 
(https://github.com/django/django/commit/e3a7bfccbb83712caf0645e4e33f5c03d9dc462b),
 although at that time with a little more code than it's current version.

 The characters you are expecting to be escaped are currently marked as
 safe. Otherwise, even `http://example.com?q=` would already have the URL
 encoding applied to it. At first sight, a solution seems to be to make
 `smart_urlquote` even smarter, and only consider the currently listed
 characters safe if they are not within a URL parameter themselves. I agree
 that this is a bug after all.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/075.d8b8dfe1c4e27f49a0e6ebb271696af3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.