Re: [Django] #22343: select_for_update should not be executed outside of transactions

2016-08-08 Thread Django 
#22343: select_for_update should not be executed outside of transactions
-+-
 Reporter:  timo |Owner:  shai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette ):

 In [changeset:"29a3f8b4bb1c4174a2b63766018b9106593b8ab6" 29a3f8b]:
 {{{
 #!CommitTicketReference repository=""
 revision="29a3f8b4bb1c4174a2b63766018b9106593b8ab6"
 Refs #22343 -- Corrected a test for missing select_for_update(nowait=True)
 support.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.481ae56ad988cb2dee00220889d68f0b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22343: select_for_update should not be executed outside of transactions

2014-04-09 Thread Django 
#22343: select_for_update should not be executed outside of transactions
-+-
 Reporter:  timo |Owner:  shai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shai Berger ):

 In [changeset:"59b1d3098f393f0754b60ebb710450cba9891e6e"]:
 {{{
 #!CommitTicketReference repository=""
 revision="59b1d3098f393f0754b60ebb710450cba9891e6e"
 Documentation fixes for the select_for_update change.

 Refs #22343; thanks Tim Graham for the fixes.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a9b6456e1481f42d46b05dab24216224%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22343: select_for_update should not be executed outside of transactions

2014-04-09 Thread Django 
#22343: select_for_update should not be executed outside of transactions
-+-
 Reporter:  timo |Owner:  shai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shai Berger ):

 In [changeset:"941f947bfd8d8f1a608634cf42f212b3a5a1933c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="941f947bfd8d8f1a608634cf42f212b3a5a1933c"
 [1.7.x] Documentation fixes for the select_for_update change.

 Refs #22343; thanks Tim Graham for the fixes.

 Backport of 59b1d30 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ce0c131c39ac0e04bd21bd55929c6846%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22343: select_for_update should not be executed outside of transactions

2014-04-09 Thread Django 
#22343: select_for_update should not be executed outside of transactions
-+-
 Reporter:  timo |Owner:  shai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shai Berger ):

 In [changeset:"690a5984a3c0a706b8cc296bdcccd524b2079559"]:
 {{{
 #!CommitTicketReference repository=""
 revision="690a5984a3c0a706b8cc296bdcccd524b2079559"
 [1.6.x] Fixed #22343 -- Disallowed select_for_update in autocommit mode

 The ticket was originally about two failing tests, which are
 fixed by putting their queries in transactions.

 Thanks Tim Graham for the report, Aymeric Augustin for the fix,
 and Simon Charette, Tim Graham & Loïc Bistuer for review.

 Backport of b990df1d63 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.09e6cda379cdbbb0ce66d164b519b66c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22343: select_for_update should not be executed outside of transactions

2014-04-09 Thread Django 
#22343: select_for_update should not be executed outside of transactions
-+-
 Reporter:  timo |Owner:  shai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Shai Berger ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f095356ba2244f6ed48463bac0b46d3c3e671204"]:
 {{{
 #!CommitTicketReference repository=""
 revision="f095356ba2244f6ed48463bac0b46d3c3e671204"
 Fixed #22343 -- Disallowed select_for_update in autocommit mode

 The ticket was originally about two failing tests, which are
 fixed by putting their queries in transactions.

 Thanks Tim Graham for the report, Aymeric Augustin for the fix,
 and Simon Charette, Tim Graham & Loïc Bistuer for review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.5b1d45744d85eaebbf112288dd183844%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22343: select_for_update should not be executed outside of transactions

2014-04-09 Thread Django 
#22343: select_for_update should not be executed outside of transactions
-+-
 Reporter:  timo |Owner:  shai
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:  fixed
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Shai Berger ):

 In [changeset:"3a9a4570efc933a50efec27bdd06af11877eeac6"]:
 {{{
 #!CommitTicketReference repository=""
 revision="3a9a4570efc933a50efec27bdd06af11877eeac6"
 [1.7.x] Fixed #22343 -- Disallowed select_for_update in autocommit mode

 The ticket was originally about two failing tests, which are
 fixed by putting their queries in transactions.

 Thanks Tim Graham for the report, Aymeric Augustin for the fix,
 and Simon Charette, Tim Graham & Loïc Bistuer for review.

 Backport of b990df1d63 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e9f15685428f391a97c931370c09fa2c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22343: select_for_update should not be executed outside of transactions

2014-04-09 Thread Django 
#22343: select_for_update should not be executed outside of transactions
-+-
 Reporter:  timo |Owner:  shai
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timo):

 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


Comment:

 [https://github.com/django/django/pull/2533 PR] looks good.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.a26f78146340588fecea33730de4351d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22343: select_for_update should not be executed outside of transactions (was: Two Oracle test failures since the removal of legacy transaction management)

2014-03-30 Thread Django 
#22343: select_for_update should not be executed outside of transactions
-+-
 Reporter:  timo |Owner:  shai
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Release blocker  | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Old description:

> Seeing these test failures after
> 0f9560855e5ed203b8c911c23237826e28a62a38:
> {{{
> $ ./runtests.py --settings=test_oracle select_for_update
> Testing against Django installed in '/home/tim/code/django/django'
> Creating test database for alias 'default'...
> Creating test user...
> Creating test database for alias 'other'...
> Creating test user...
> .EE...s
> ==
> ERROR: test_for_update_sql_generated
> (select_for_update.tests.SelectForUpdateTests)
> --
> Traceback (most recent call last):
>   File "/home/tim/code/django/django/test/testcases.py", line 916, in
> skip_wrapper
> return test_func(*args, **kwargs)
>   File "/home/tim/code/django/tests/select_for_update/tests.py", line 80,
> in test_for_update_sql_generated
> list(Person.objects.all().select_for_update())
>   File "/home/tim/code/django/django/db/models/query.py", line 141, in
> __iter__
> self._fetch_all()
>   File "/home/tim/code/django/django/db/models/query.py", line 961, in
> _fetch_all
> self._result_cache = list(self.iterator())
>   File "/home/tim/code/django/django/db/models/query.py", line 265, in
> iterator
> for row in compiler.results_iter():
>   File "/home/tim/code/django/django/db/models/sql/compiler.py", line
> 694, in results_iter
> for rows in self.execute_sql(MULTI):
>   File "/home/tim/code/django/django/db/models/sql/compiler.py", line
> 1150, in cursor_iter
> sentinel):
>   File "/home/tim/code/django/django/db/models/sql/compiler.py", line
> 1149, in 
> for rows in iter((lambda: cursor.fetchmany(GET_ITERATOR_CHUNK_SIZE)),
>   File "/home/tim/code/django/django/db/utils.py", line 101, in inner
> return func(*args, **kwargs)
>   File "/home/tim/code/django/django/db/utils.py", line 94, in __exit__
> six.reraise(dj_exc_type, dj_exc_value, traceback)
>   File "/home/tim/code/django/django/db/utils.py", line 101, in inner
> return func(*args, **kwargs)
>   File "/home/tim/code/django/django/db/backends/oracle/base.py", line
> 905, in fetchmany
> return tuple(_rowfactory(r, self.cursor) for r in
> self.cursor.fetchmany(size))
> DatabaseError: ORA-01002: fetch out of sequence
>

> ==
> ERROR: test_for_update_sql_generated_nowait
> (select_for_update.tests.SelectForUpdateTests)
> --
> Traceback (most recent call last):
>   File "/home/tim/code/django/django/test/testcases.py", line 916, in
> skip_wrapper
> return test_func(*args, **kwargs)
>   File "/home/tim/code/django/tests/select_for_update/tests.py", line 89,
> in test_for_update_sql_generated_nowait
> list(Person.objects.all().select_for_update(nowait=True))
>   File "/home/tim/code/django/django/db/models/query.py", line 141, in
> __iter__
> self._fetch_all()
>   File "/home/tim/code/django/django/db/models/query.py", line 961, in
> _fetch_all
> self._result_cache = list(self.iterator())
>   File "/home/tim/code/django/django/db/models/query.py", line 265, in
> iterator
> for row in compiler.results_iter():
>   File "/home/tim/code/django/django/db/models/sql/compiler.py", line
> 694, in results_iter
> for rows in self.execute_sql(MULTI):
>   File "/home/tim/code/django/django/db/models/sql/compiler.py", line
> 1150, in cursor_iter
> sentinel):
>   File "/home/tim/code/django/django/db/models/sql/compiler.py", line
> 1149, in 
> for rows in iter((lambda: cursor.fetchmany(GET_ITERATOR_CHUNK_SIZE)),
>   File "/home/tim/code/django/django/db/utils.py", line 101, in inner
> return func(*args, **kwargs)
>   File "/home/tim/code/django/django/db/utils.py", line 94, in __exit__
> six.reraise(dj_exc_type, dj_exc_value, traceback)
>   File "/home/tim/code/django/django/db/utils.py", line 101, in inner
> return func(*args, **kwargs)
>   File "/home/tim/code/django/django/db/backends/oracle/base.py", line
> 905, in fetchmany
> return tuple(_rowfactory(r, self.cursor) for r in
> self.curs