Re: [Django] #22540: .save() called in multiple "creation" queryset functions

[Django]

#22540: .save() called in multiple "creation" queryset functions
-+-
 Reporter:  craig.labenz@…   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:  fixed
  (models, ORM)  | Triage Stage:  Ready for
 Severity:  Normal   |  checkin
 Keywords:  creation |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by Claude Paroz ):

 In [changeset:"faa8c71fd9e97794e73f7e7564446846d72d8bb2"]:
 {{{
 #!CommitTicketReference repository=""
 revision="faa8c71fd9e97794e73f7e7564446846d72d8bb2"
 Moved misplaced transaction.atomic from 0dce44e16b

 Thanks Florian Apolloner for noticing the issue and Aymeric
 Augustin for the expertise.
 Refs #22540.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.581bfeeb3bff1f03e0875b74bcc80430%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22540: .save() called in multiple "creation" queryset functions

[Django]

#22540: .save() called in multiple "creation" queryset functions
-+-
 Reporter:  craig.labenz@…   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:  fixed
  (models, ORM)  | Triage Stage:  Ready for
 Severity:  Normal   |  checkin
 Keywords:  creation |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0dce44e16be2d4850120cd80ab9171c5964a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="0dce44e16be2d4850120cd80ab9171c5964a"
 Fixed #22540 -- Made _create_object_from_params() call create()

 So as the save step is centralized in create(), especially useful
 when customizing behavior in subclasses.
 Thanks craig.lab...@gmail.com for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.11070da27a8800195a6bb8ee00663019%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22540: .save() called in multiple "creation" queryset functions

[Django]

#22540: .save() called in multiple "creation" queryset functions
-+-
 Reporter:  craig.labenz@…   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Ready for
 Severity:  Normal   |  checkin
 Keywords:  creation |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.d809b8f57f1a13c3c86fa6f6d3e35f23%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22540: .save() called in multiple "creation" queryset functions

[Django]

#22540: .save() called in multiple "creation" queryset functions
-+-
 Reporter:  craig.labenz@…   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:  creation |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/2626

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.3e7f8feead8690f0f4451bea46561962%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22540: .save() called in multiple "creation" queryset functions

[Django]

#22540: .save() called in multiple "creation" queryset functions
-+-
 Reporter:  craig.labenz@…   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  master
Component:  Database layer   |   Resolution:
  (models, ORM)  | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:  creation |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 Looking at the code briefly I think it might be possible.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/080.6acc5a3563e94fb88195e99e0a1ddc08%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.