Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"cbcb7c010bdc015c79b4b8a0ba2955abb23aee82"]:
 {{{
 #!CommitTicketReference repository=""
 revision="cbcb7c010bdc015c79b4b8a0ba2955abb23aee82"
 [1.7.x] Fixed #22857 -- Reset translations when only .mo file changed

 No need to restart the server when a translation file changes.
 Refs #9523. Thanks artscoop for the report and Tim Graham for
 the review.

 Backport of 0d363b25b8 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.287076849dca0f3aff39cecd22ff80fd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by timo):

 I would backport this or revert #9523 from 1.7 so we don't ship a buggy
 change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8769237a14a44f04b5ca08fa03fbcbb5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0d363b25b82b0a86b7243512470f364bef92bc3d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="0d363b25b82b0a86b7243512470f364bef92bc3d"
 Fixed #22857 -- Reset translations when only .mo file changed

 No need to restart the server when a translation file changes.
 Refs #9523. Thanks artscoop for the report and Tim Graham for
 the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a0e29de5ec580e0b9c885adc391fa40c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by artscoop):

 @claudep Works flawlessly. Could not test on the master branch since it
 breaks many third party apps, but copied the autoreload.py file into the
 working 1.7b4. the server did not restart on .mo file changes, yet the new
 translation was properly taken into account.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.6a13e5f2631bf4cabb5a97a8dc676cad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by artscoop):

 To be done in the next 8 hours, I'll keep you informed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.56ca45cb6dc8a85fe05691acd100e213%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by claudep):

 I'd like at least the reporter to review and check the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.18bba4f2d169adc3279bbd8ad8661207%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by timo):

 * stage:  Accepted => Ready for checkin


Comment:

 Patch seems okay to me, although I'm not really familiar with this stuff
 so a second pair of eyes wouldn't hurt.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a0e9bca0dd6bde2b62a9938745098b53%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/2837

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cee3f82d22658d0e69a46d478f0aa87e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * severity:  Release blocker => Normal


Comment:

 I agree that this change of behaviour is annoying for rosetta but I don't
 think we should delay 1.7 for this edge case.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.60a06a3d481fea3e39e1a3b649d34e0e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by andrewgodwin):

 If we can reset the translation cache then let's try that, but I'm really
 pushed to define this as a release blocker (it is not breaking any part of
 Django directly, and the behaviour it produces can be worked around with
 ``--noreload`` if you need to file translations), so if we get down to the
 release time and this is what's left... it might not make it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.87378cbd916e5c481d714782826a7c9b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by artscoop):

 @claudep I didn't know it was possible to reset/reload translations
 separately (even though it makes perfect sense), but I think it's better
 than the --noreload-translations, because the command option would have to
 be officially documented, and maybe deprecated very quickly.
 The suggestion about AJAXing a view until the server comes back is good
 but a bit hacky.

 I do think resetting translation cache on .mo change is the best idea, and
 would be more immediate than reloading the whole dev server (which ideally
 should be reloaded on code changes only). It seems that resetting the
 translation is a simple as in this example:
 https://djangosnippets.org/snippets/1704/

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.864c382c09dadc58b90f0e606d2653c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 Another idea (completely untested) would be to gather mo files in another
 set of files in runserver and only reset translations when one of these
 files changes instead of restarting the server.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c0b93a94b36c2f30f4404d0ef2e10744%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timo):

 I am not sure if it will, but it currently has some issues and even if we
 resolve them, I'm not sure backporting to 1.7 this late in the release
 cycle is acceptable. Currently the "best" solution I am thinking of is
 adding a `--noreload-translations` flag to `runserver`. Open to other
 opinions and ideas!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5edb6b3d31aa5c0b1af58db53411a9d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by CollinAnderson):

 would #18855 solve the problem?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0c3bb80febcaa0c684a02630cab4c99f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by andrewgodwin):

 Not entirely sure this is a release blocker, though - it'd be nice to fix,
 but at the same time I don't think it's a regression from previously
 documented behaviour, just a pattern that happened to work.

 Said app could, for example, use an ajax request to kick off the rebuild
 and then poll the server to see when it reappears before reloading.

 (Not saying we shouldn't land a fix for this in 1.7, just saying that I'm
 not really prepared to hold the entire release up for it...)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3e66950d2046162978237377bd15a1e2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by artscoop):

 In my opinion, the request in #9523 was a very valid one and still is...
 but yes, some django apps help with editing translations. This is one
 category of apps that defeats the purpose of autoreloading on .mo changes.
 :(

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0d25384e39927480afa56a45d961a294%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22857: Django 1.7 runserver auto-reload : setting behaviour by extensions

[Django]

#22857: Django 1.7 runserver auto-reload : setting behaviour by extensions
-+-
 Reporter:  artscoop |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Management |  Version:
  commands)  |  1.7-beta-2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timo):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * severity:  Normal => Release blocker
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I guess this is #9523. One user's feature is another user's bug... I guess
 it's likely possible to add a flag to control the behavior although I'm
 not sure it's ideal to be adding more flags like that to  `runserver`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a7c5281e17ff7a4d1f5330ab63d8da01%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.