Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by CollinAnderson):

 this ticket is closed as "fixed", so here's a new ticket for converting to
 an iterator #23190

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.961828db7d4f2961ecc69bfaf949d936%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Florian Apolloner ):

 In [changeset:"1cb919e408d943cf2fadebb2b12517f523feb718"]:
 {{{
 #!CommitTicketReference repository=""
 revision="1cb919e408d943cf2fadebb2b12517f523feb718"
 [1.7.x] Ensured that Paginator.page_range works the same on Python 2 and
 3.

 This somewhat fixes #23088, refs 23140.

 Backport of 2d542bf60cc37c59872c5a20d6af3bf826038739 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.d3b0fc8fa4a7f9ce62d1c4e7b782d20e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Florian Apolloner ):

 In [changeset:"2d542bf60cc37c59872c5a20d6af3bf826038739"]:
 {{{
 #!CommitTicketReference repository=""
 revision="2d542bf60cc37c59872c5a20d6af3bf826038739"
 Ensured that Paginator.page_range works the same on Python 2 and 3.

 This somewhat fixes #23088, refs 23140.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.30c3d0ca95970cf07ac19a3ff8c6d370%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Florian Apolloner ):

 In [changeset:"40fb6a560139150daa8f231f65b4044d45a97a8d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="40fb6a560139150daa8f231f65b4044d45a97a8d"
 Revert "Fixed #23088 -- Used `six` `range` type in
 `Paginator.page_range`."

 This reverts commit 6508db2ff9fc5be95fec903b3fa7ab8204fe316a.

 Refs #23088.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.d3f32389e78d4e0e94e1a4d0358bf86b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Tim Graham ):

 In [changeset:"ee0208108bd66cec04b28aca76eb506d9a2e1fd3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ee0208108bd66cec04b28aca76eb506d9a2e1fd3"
 Revert "[1.7.x] Fixed #23088 -- Used `six` `range` type in
 `Paginator.page_range`."

 This reverts commit ce95ab8f025cc9f35990f0c2d9a290eec1ece753.

 It caused some backwards compatibility concerns (refs #23140).
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.aa3c3f196391cb46e39f5a815857b85b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by CollinAnderson):

 * cc: cmawebsite@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.1bdd6314ba411ca5353499732837c1c5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by CollinAnderson):

 I've been relying on this being a list. #23140

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.2b23b008e24e61558a1206b43f5df68e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by mardini):

 Hi apollo13,

 Thanks for the feedback. I actually tried a small example in which I used
 the new version of `page_range` twice and didn't face any issues.
 I think the reason for this is that although
 `xrange`(Python2)/`range`(Python3) is a generator in theory, the actual
 implementation is not.
 A couple of links that discuss this behavior:
 http://stackoverflow.com/questions/10776250/why-is-xrange-able-to-go-back-
 to-beginning-in-python
 http://stackoverflow.com/questions/13092267/if-range-is-a-generator-in-
 python-3-3-why-can-i-not-call-next-on-a-range

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.5f6cbffa3ca83f4c2abe0b8405f063ba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by apollo13):

 This might cause problems if someone iterates over `page_range` twice; eg
 to show a list of pages above and below the content. So this change has
 the possibility to break existing code; not sure what the best way to go
 ahead is -- one option would be to also force a list on python3 and tell
 ddt to get smarter :þ

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.a989fa59625e2e9ffa68aff5015db1c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Tim Graham ):

 In [changeset:"ce95ab8f025cc9f35990f0c2d9a290eec1ece753"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ce95ab8f025cc9f35990f0c2d9a290eec1ece753"
 [1.7.x] Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`.

 Backport of 6508db2ff9 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.e60093d15661f4bc4d414044afc4d435%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  closed
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:  fixed
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by Moayad Mardini ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6508db2ff9fc5be95fec903b3fa7ab8204fe316a"]:
 {{{
 #!CommitTicketReference repository=""
 revision="6508db2ff9fc5be95fec903b3fa7ab8204fe316a"
 Fixed #23088 -- Used `six` `range` type in `Paginator.page_range`.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.bd078c61d46438292bc33f898088aaa9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  assigned
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by mardini):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/2954

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.6b79ee20e4133d772e36526598b48c42%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  mardini
   |   Status:  assigned
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by mardini):

 * status:  new => assigned
 * owner:  nobody => mardini


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.e88fd88e731a8759622da6848c5e5e02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23088: Paginator.page_range is of inconsistent type in Py2/Py3

[Django]

#23088: Paginator.page_range is of inconsistent type in Py2/Py3
-+-
 Reporter:  Keryn Knight |Owner:  nobody
   |   Status:  new
 Type:   |  Version:  master
  Cleanup/optimization   |   Resolution:
Component:  Core (Other) | Triage Stage:  Accepted
 Severity:  Normal   |  Needs documentation:  0
 Keywords:   |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/095.914c681a7999283e4e7f3f2614a05448%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.