Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  select_related   | Triage Stage:  Accepted
  defer  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9891c8f5ea573263cea009c0c887a4f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  0
  defer  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timgraham):

 * version:  1.7-rc-2 => 1.7


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.bc31cb414631886a42ef3d4abfe89c31%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  0
  defer  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by akaariai):

 Pull request https://github.com/django/django/pull/3669 fixes this issue.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.05cb40f352e8d2634e548ad3f8122971%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  0
  defer  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Marking as "patch needs improvement" per latest comment from Anssi on the
 PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4b171fe8e28fc681c7271883ea9b4b8b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  0
  defer  |  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0


Comment:

 Patch received another update.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.987bc5e29413ade0a5476dc0c7d10c67%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  0
  defer  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 See PR for comments.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.42d4ff06c7430aa5b517f76d40952bae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  select_related   |  checkin
  defer  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Ready for another review.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.96ce69166da19145f903bb856768e239%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  0
  defer  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Vladimiroff):

 @akaariai, you're right. I was building the field_names wrong. The issue
 was not only that `base_ptr_id` was with the wrong value, but *all* of the
 values was getting mapped to the wrong field.

 The only solution that I found was completely rebuilding the whole list
 from scratch. Was that a good idea?
 
https://github.com/Vladimiroff/django/commit/cfd87b8157bf38ce145758e0251f5c14dfb5e60f

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.85c23e85561977a089aea98695c3b117%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  0
  defer  |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-
Changes (by akaariai):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 The patch doesn't seem to work correctly. The obj.derived.base_ptr_id
 doesn't have correct value of 1 in the test case.
 {{{
 >>> obj.derived.base_ptr_id
 'bar'
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.acd0e19be266cb4cb5b7721403100983%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  select_related   |  checkin
  defer  |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timgraham):

 * needs_docs:  1 => 0
 * has_patch:  0 => 1
 * type:  Uncategorized => Bug
 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Ready for review by ORM experts.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.27dc48d3db4bef3812599e46f9f54852%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  1
  defer  |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-

Comment (by Vladimiroff):

 Ok, my idea was completely wrong. I had to dig a little bit deeper than I
 thought.

 https://github.com/django/django/pull/3067

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.700fb30632a7363af48275efcdd0345c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  1
  defer  |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-

Comment (by Vladimiroff):

 The reason behind this is that `subclassa` (in the given example) is not
 technically a **field**. Which means it won't be returned by
 `Base._meta.get_concrete_fields_with_model`. The only solution I could
 think of is creating `get_all_concrete_fields_with_model` (which should
 use `get_all_field_names` instead of `local_fields`).

 Anyone with better ideas?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4a96ba18a40d42a47add99ac2d438103%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  1
  defer  |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-

Comment (by jarshwah):

 Verified that there is an extra query. Tried the patch from #23001
 thinking it may be related, but same problem there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8059e46c10508eb43caaa364028a639d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23270: select_related on fields pointing to subclasses does not work when using defer

[Django]

#23270: select_related on fields pointing to subclasses does not work when using
defer
-+-
 Reporter:  islavov  |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  1.7-rc-2
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  select_related   |  Needs documentation:  1
  defer  |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by jarshwah):

 * needs_docs:   => 1
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 1
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.67679fe557ce452b073336850b454e05%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.