Re: [Django] #23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets

[Django]

#23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets
-+-
 Reporter:  gabejackson  |Owner:
 Type:  Bug  |  gabejackson
Component:  Database layer   |   Status:  closed
  (models, ORM)  |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0e16c3e3cd61b119e067b369f3ff928a2e4045b4"]:
 {{{
 #!CommitTicketReference repository=""
 revision="0e16c3e3cd61b119e067b369f3ff928a2e4045b4"
 Fixed #23396 -- Ensured ValueQuerySets are not checked by
 check_related_objects.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.c16f80d9993fc3744307d8eeb542b87b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets

[Django]

#23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets
-+-
 Reporter:  gabejackson  |Owner:
 Type:  Bug  |  gabejackson
Component:  Database layer   |   Status:  new
  (models, ORM)  |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by gabejackson):

 Final PR is here: https://github.com/django/django/pull/3154

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ad688124f5b60a55a7396ec237a366a6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets

[Django]

#23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets
-+-
 Reporter:  gabejackson  |Owner:
 Type:  Bug  |  gabejackson
Component:  Database layer   |   Status:  new
  (models, ORM)  |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by gabejackson):

 Thanks for the review. I cleaned it up according to your comments.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.cdbdec7cdfe3406c89e77af7e3a63393%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets

[Django]

#23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets
-+-
 Reporter:  gabejackson  |Owner:
 Type:  Bug  |  gabejackson
Component:  Database layer   |   Status:  new
  (models, ORM)  |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by timgraham):

 * easy:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Left some cosmetic comments, otherwise LGTM.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.9844fba44ed5b2cbfc29eaee430326f5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets

[Django]

#23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets
---+---
 Reporter:  gabejackson|Owner:  gabejackson
 Type:  Bug|   Status:  new
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+---
Changes (by gabejackson):

 * severity:  Release blocker => Normal
 * cc: timgraham (removed)
 * component:  Database layer (models, ORM) => Uncategorized
 * easy:  0 => 1
 * has_patch:  0 => 1
 * stage:  Accepted => Unreviewed


Comment:

 Pull Request is here: https://github.com/django/django/pull/3150

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.e7d0160e5eb915224dce6189a87cae2a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets

[Django]

#23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets
-+-
 Reporter:  gabejackson  |Owner:
 Type:  Bug  |  gabejackson
Component:  Database layer   |   Status:  new
  (models, ORM)  |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by gabejackson):

 * component:  Uncategorized => Database layer (models, ORM)
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.6d9f0788d8ee14f6b1fbe0afb4c5e0f0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets

[Django]

#23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets
---+---
 Reporter:  gabejackson|Owner:  gabejackson
 Type:  Bug|   Status:  new
Component:  Uncategorized  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+---
Changes (by gabejackson):

 * cc: timgraham, gabejackson (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.f1883e5fd37204b0bc6fccf84cc805c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets

[Django]

#23396: Regression in #14334 causes ValueError to be thrown on ValuesQuerySets
-+-
 Reporter:  gabejackson  |Owner:
 Type:  Bug  |  gabejackson
Component:  Database layer   |   Status:  new
  (models, ORM)  |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * severity:  Normal => Release blocker
 * cc: timgraham (added)
 * needs_better_patch:   => 0
 * component:  Uncategorized => Database layer (models, ORM)
 * needs_tests:   => 0
 * easy:  1 => 0
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 (Affects master only)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.adde304ce3b0d7a6936459efd489003d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.