Re: [Django] #23452: Infinite migrations with empty unique_together

[Django]

#23452: Infinite migrations with empty unique_together
+---
 Reporter:  fwkroon |Owner:  Markush2010
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---

Comment (by Tim Graham ):

 In [changeset:"67872bfff12de7dcf22c966970fe21f65fe593c8"]:
 {{{
 #!CommitTicketReference repository=""
 revision="67872bfff12de7dcf22c966970fe21f65fe593c8"
 [1.7.x] Fixed #23452 -- Prevented infinite migrations for empty
 unique/index_together.

 Thanks fwkroon for the report.

 Backport of 6d5958c7a3 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d78e217887b2c274377746d8f7237615%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23452: Infinite migrations with empty unique_together

[Django]

#23452: Infinite migrations with empty unique_together
+---
 Reporter:  fwkroon |Owner:  Markush2010
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6d5958c7a358d8ad0037fdd4922a65e19d12d77c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="6d5958c7a358d8ad0037fdd4922a65e19d12d77c"
 Fixed #23452 -- Prevented infinite migrations for empty
 unique/index_together.

 Thanks fwkroon for the report.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.bf72c621d382c1abb37042d9a7e85e85%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23452: Infinite migrations with empty unique_together

[Django]

#23452: Infinite migrations with empty unique_together
+---
 Reporter:  fwkroon |Owner:  Markush2010
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by Markush2010):

 * has_patch:  0 => 1


Comment:

 I opened a pull request: https://github.com/django/django/pull/3207

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2fc4aa09b805239038a1659b2a28c902%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23452: Infinite migrations with empty unique_together

[Django]

#23452: Infinite migrations with empty unique_together
+---
 Reporter:  fwkroon |Owner:  Markush2010
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by Markush2010):

 * cc: info+coding@… (added)
 * status:  new => assigned
 * owner:  nobody => Markush2010


Comment:

 First of all, this also affects the `index_together` option.

 I'm working on a pull-request. Not sure though, which way I should go.
 Here's what's happening:

 The `CreateModel` doesn't include those two options at all but adds them,
 if they evaluate to `True` (`if model_state.options.get('unique_together',
 None)`) as separate operations. Thus an empty `unique_together`
 declaration is never added initially. The `AlterUniqueTogether` or
 `AlterIndexTogether` on the other side are added if the given value (`()`
 is different to `None`).

 We now have two options:

 1. Always add an `AlterUniqueTogether` or `AlterIndexTogether` operation,
 even if it's empty (`()`).
 2. Never add an `AlterUniqueTogether` or `AlterIndexTogether` operation if
 it's empty (`()`).

 I'd go with 2.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.095207fbee4b60e31cd8f643bf5f783c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23452: Infinite migrations with empty unique_together

[Django]

#23452: Infinite migrations with empty unique_together
+
 Reporter:  fwkroon |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.7
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by timgraham):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * type:  Uncategorized => Bug
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I don't think it needs to raise an error, but it's probably not common so
 not marking as a release blocker. I'd want to backport the fix to 1.7 when
 we have a patch though.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c102dbebe284b408b5e0649d0bf6cfb1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.