Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  closed
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by timgraham):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In 59383f1e3a8ab5a6477dbd5bb1d7c32366a9d8f8:

 Ref #23643 -- Added plain text report of exception chain.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.acbc7ea8991704d3a14361fbfb094da2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by tricoder42):

 * needs_tests:  1 => 0


Comment:

 Tests added, thank you for patience!

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a4ec1cf11453b1ebc887650fd6fe5580%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * needs_tests:  0 => 1


Comment:

 The one item remaining is adding a test for the
 [https://github.com/django/django/pull/4412 plain text exception chain
 report]. Tomas said he will do that soon.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.75767838ccd329889e6af71f87ef7db6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+--

Comment (by Tim Graham ):

 In [changeset:"38eacbde62cd83ffaa64db7719c2c643f69551e0" 38eacbd]:
 {{{
 #!CommitTicketReference repository=""
 revision="38eacbde62cd83ffaa64db7719c2c643f69551e0"
 Refs #23643 -- Fixed debug view regression on Python 2.

 Thanks Tomáš Ehrlich for help with the patch.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a35a48457478bee444c59978ab266d4f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+--

Comment (by fero):

 And the PR https://github.com/django/django/pull/4568

 the __cause__ attribute is set in db/utils.py in wrapping
 DatabaseException

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.326325fec1d68425451bde121b424f79%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+--

Comment (by apollo13):

 See the PR https://github.com/django/django/pull/4530 for more details.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9679e6eb13fb6b14bbeb9a59dee168ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+--
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Here's a view to reproduce `AttributeError: 'IntegrityError' object has no
 attribute '__traceback__'`:
 {{{
 def vote(request, poll_id):
 Question.objects.create(question_text='foobar')
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.1f4cc587ee2ce051db698c8400dd670c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by tricoder42):

 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 1. I've submitted new PR with updated plain-text output
 https://github.com/django/django/pull/4412

 2. I couldn't reproduce the AttributeError. I tried this simple view:

 {{{
 def view(request):
 raise IntegrityError('Error raised')
 }}}

 We could simple replace this line:

 {{{
   tb = self.tb if not exceptions else exc_value.__traceback__
 }}}

 with safer, but longer:

 {{{
 if not exceptions or not hasattr(exc_value, '__traceback__'):
 tb = self.tb
 else:
 tb = exc_value.__traceback__
 }}}

 The point was that `exceptions` should have been already empty in Python
 2, but somewhat it wasn't. Would be great if we could reproduce your
 problem.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.06dd1733f2d278e21ce23c21eaf768cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  new
Component:  Core (Other) |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by timgraham):

 * status:  closed => new
 * has_patch:  1 => 0
 * resolution:  fixed =>
 * severity:  Normal => Release blocker


Comment:

 Ran into a crash (Python 2 only) when a view raised an `IntegrityError`:
 {{{
 Traceback (most recent call last):
   File "/usr/lib/python2.7/wsgiref/handlers.py", line 85, in run
 self.result = application(self.environ, self.start_response)
   File "/home/tim/code/django/django/contrib/staticfiles/handlers.py",
 line 63, in __call__
 return self.application(environ, start_response)
   File "/home/tim/code/django/django/core/handlers/wsgi.py", line 177, in
 __call__
 response = self.get_response(request)
   File "/home/tim/code/django/django/core/handlers/base.py", line 218, in
 get_response
 response = self.handle_uncaught_exception(request, resolver,
 sys.exc_info())
   File "/home/tim/code/django/django/core/handlers/base.py", line 261, in
 handle_uncaught_exception
 return debug.technical_500_response(request, *exc_info)
   File "/home/tim/code/django/django/views/debug.py", line 97, in
 technical_500_response
 html = reporter.get_traceback_html()
   File "/home/tim/code/django/django/views/debug.py", line 387, in
 get_traceback_html
 c = Context(self.get_traceback_data(), use_l10n=False)
   File "/home/tim/code/django/django/views/debug.py", line 332, in
 get_traceback_data
 frames = self.get_traceback_frames()
   File "/home/tim/code/django/django/views/debug.py", line 503, in
 get_traceback_frames
 tb = self.tb if not exceptions else exc_value.__traceback__
 AttributeError: 'IntegrityError' object has no attribute '__traceback__'
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.270c76af47a6b1e55a07a43592436b50%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
--+--
 Reporter:  cool-RR   |Owner:  tricoder42
 Type:  New feature   |   Status:  closed
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8414fcf16b9cfa8d989db913f0961fc4ce18c71b" 8414fcf1]:
 {{{
 #!CommitTicketReference repository=""
 revision="8414fcf16b9cfa8d989db913f0961fc4ce18c71b"
 Fixes #23643 -- Added chained exception details to debug view.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.60841e69bc20cc43fbc1ae22d245da6e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
--+--
 Reporter:  cool-RR   |Owner:  tricoder42
 Type:  New feature   |   Status:  assigned
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by timgraham):

 * component:  Python 3 => Core (Other)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e0d8a68ca86db6faa049f982c011b24b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by tricoder42):

 The easiest way to review, hook up this view into your urlconf:

 {{{
 def chained_exception(request):
 try:
 raise AttributeError('Top level')
 except AttributeError as explicit:
 try:
 raise ValueError('Second exception') from explicit
 except ValueError:
 raise IndexError('Final exception')
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.dc25cc223afef6db8587056298b62b14%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by tricoder42):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c3f2b0709f8d179a9a9ccf4303348a9f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+--
 Reporter:  cool-RR  |Owner:  tricoder42
 Type:  New feature  |   Status:  assigned
Component:  Python 3 |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by tricoder42):

 * owner:  nobody => tricoder42
 * status:  new => assigned
 * version:  1.7 => master


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f22f6216d56b52d17dbcc3afe1bd9bcc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23643: Have debug page show "During handling of this exception, another exception occurred.."

[Django]

#23643: Have debug page show "During handling of this exception, another 
exception
occurred.."
-+
 Reporter:  cool-RR  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Python 3 |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by bmispelon):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I like this idea.

 I find that it really helps with debugging (especially when Django has a
 bad habit of masking exceptions).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7a64b418541eaa74b7d0514396d1d62c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.