Re: [Django] #23676: FileField documentation is confusing about database column representation

[Django]

#23676: FileField documentation is confusing about database column 
representation
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c1b9f99a812d01124ba4ddefcafaa90dcb5b05ae"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c1b9f99a812d01124ba4ddefcafaa90dcb5b05ae"
 Fixed #23676 -- Rearranged sentence; "by default" applies only to max
 length
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6ff142ad96a9502d39cfa9bcce8b3605%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23676: FileField documentation is confusing about database column representation

[Django]

#23676: FileField documentation is confusing about database column 
representation
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"7d90fed1a073318defbb7cf80015530a38a09bbc"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7d90fed1a073318defbb7cf80015530a38a09bbc"
 [1.6.x] Fixed #23676 -- Rearranged sentence; "by default" applies only to
 max length

 Backport of c1b9f99a81 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6cdf481b8f3af1adc18027801f2f5484%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23676: FileField documentation is confusing about database column representation

[Django]

#23676: FileField documentation is confusing about database column 
representation
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Tim Graham ):

 In [changeset:"37ab955d69ea541b4c66e225cc24dc0a2ee057be"]:
 {{{
 #!CommitTicketReference repository=""
 revision="37ab955d69ea541b4c66e225cc24dc0a2ee057be"
 [1.7.x] Fixed #23676 -- Rearranged sentence; "by default" applies only to
 max length

 Backport of c1b9f99a81 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.79903f9fd526cbbf133f338cb381284c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23676: FileField documentation is confusing about database column representation

[Django]

#23676: FileField documentation is confusing about database column 
representation
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by jdufresne):

 Thanks. I've incorporated your suggestions in a pull request
 .

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0a20f65cfd29099cf9ae6ddb8e2121bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23676: FileField documentation is confusing about database column representation

[Django]

#23676: FileField documentation is confusing about database column 
representation
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 Makes sense to me. I'd just change the order a bit: "FileField instances
 are created in your database as varchar columns with a default max length
 of 100 characters."

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0cdb1f64b0d523766ecc3095cad9fdf7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23676: FileField documentation is confusing about database column representation

[Django]

#23676: FileField documentation is confusing about database column 
representation
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by jdufresne):

 What about the following which emphasizes that the "by default" is for the
 length only

 > FileField instances are created as varchar columns with a default length
 100 in your database. As with other fields, you can change the maximum
 length using the max_length argument.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b20dedcf7de5225e1dba026b11270dba%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23676: FileField documentation is confusing about database column representation

[Django]

#23676: FileField documentation is confusing about database column 
representation
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by jdufresne):

 > I think what's trying to be implied is that you can customize the length
 using the max_length option.

 I agree. I think with the "by default" removed the second sentence does a
 fine job of explaining that:

 > FileField instances are created as varchar(100) columns in your
 database. As with other fields, you can change the maximum length using
 the max_length argument.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6bdde687d0b6135eb7644c1cfe50624c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23676: FileField documentation is confusing about database column representation

[Django]

#23676: FileField documentation is confusing about database column 
representation
--+
 Reporter:  jdufresne |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * type:  Uncategorized => Cleanup/optimization
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I think what's trying to be implied is that you can customize the length
 using the `max_length` option.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1d1a2424167712f95e67495c52f3bf46%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.