Re: [Django] #24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with field.many_to_one/field.many_to_many

2016-05-28 Thread Django 
#24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with
field.many_to_one/field.many_to_many
-+-
 Reporter:  coldmind |Owner:
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"f529d0cb5855db2dfc8d0d39850dbb4793bc75c2" f529d0cb]:
 {{{
 #!CommitTicketReference repository=""
 revision="f529d0cb5855db2dfc8d0d39850dbb4793bc75c2"
 [1.10.x] Refs #24227 -- Fixed crash of ManyToManyField.value_from_object()
 on unsaved model instances.

 This behavior was removed in 67d984413c9540074e4fe6aa033081a35cf192bc
 but is needed to prevent a crash in formtools.

 Backport of a4c20ae85b40c49e28d1b2227208e4f00d7820df from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.224037c9eec98ddf32180e6ffccdd6f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with field.many_to_one/field.many_to_many

2016-05-28 Thread Django 
#24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with
field.many_to_one/field.many_to_many
-+-
 Reporter:  coldmind |Owner:
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"a4c20ae85b40c49e28d1b2227208e4f00d7820df" a4c20ae8]:
 {{{
 #!CommitTicketReference repository=""
 revision="a4c20ae85b40c49e28d1b2227208e4f00d7820df"
 Refs #24227 -- Fixed crash of ManyToManyField.value_from_object() on
 unsaved model instances.

 This behavior was removed in 67d984413c9540074e4fe6aa033081a35cf192bc
 but is needed to prevent a crash in formtools.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0ba1b63e8193e5e76716f85e9e260784%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with field.many_to_one/field.many_to_many

2016-05-14 Thread Django 
#24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with
field.many_to_one/field.many_to_many
-+-
 Reporter:  coldmind |Owner:
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * owner:  coldmind =>
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8a3fd00fb82d6e2e4977c4eb1493335e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with field.many_to_one/field.many_to_many (was: isinstance checks on ManyToManyField should be replaced with fie

2016-05-14 Thread Django 
#24227: isinstance checks on ForeignKey/ManyToManyField should be replaced with
field.many_to_one/field.many_to_many
-+-
 Reporter:  coldmind |Owner:  coldmind
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Claude abandoned [https://github.com/django/django/pull/6236 the PR] to
 change instances of `isinstance(field, ForeignKey)` to
 `field.many_to_one`. If someone sees an advantage to those changes, feel
 free to send a new PR.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4e3d7926aabd31c2c6a6bdb71066bc04%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.