Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Andy
 Type:   |  Craze
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"49de4f15413a4f281e835e383a7b1aa202a3dd7e" 49de4f15]:
 {{{
 #!CommitTicketReference repository=""
 revision="49de4f15413a4f281e835e383a7b1aa202a3dd7e"
 [1.11.x] Refs #24423 -- Readded inadvertently deleted i18n tests.

 Mistake in 97c1931c4f610e80053430d0297d51e1bed1e7ae.

 Backport of 357a6428980961b2c5311eb75d16229c7fc0d982 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.d1e2786e93bfd568b9179be78b17c67b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Andy
 Type:   |  Craze
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"a6b5321ce997b899e540bb427cca98cb2b93a106" a6b5321]:
 {{{
 #!CommitTicketReference repository=""
 revision="a6b5321ce997b899e540bb427cca98cb2b93a106"
 Refs #24423 -- Readded inadvertently deleted i18n tests.

 Mistake in 97c1931c4f610e80053430d0297d51e1bed1e7ae.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.19dde7b25888c18b4c7f7fae35eb53f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Andy
 Type:   |  Craze
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"97c1931c4f610e80053430d0297d51e1bed1e7ae" 97c1931c]:
 {{{
 #!CommitTicketReference repository=""
 revision="97c1931c4f610e80053430d0297d51e1bed1e7ae"
 Fixed #24423 -- Reorganized i18n tag tests.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.66516c4807b43a556a0294facca92a93%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Andy
 Type:   |  Craze
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Martin):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.dfb3cfaef7cc7c689882e96cf812fbd1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Andy
 Type:   |  Craze
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Martin):

 * needs_better_patch:  0 => 1


Comment:

 The patch looks good to me, but IIUC you need to squash it into a single
 commit with a message following the correct commit message format.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.d2efb7f4edf996fc9eaa6f58d04be598%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Andy
 Type:   |  Craze
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Andy Craze):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c3074a25d644f15bb95dc167038309b6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Andy
 Type:   |  Craze
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Graham):

 Please uncheck "Patch needs improvement" on the ticket after updating the
 PR for the comments.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.a1eb93ada9fb01585aac3c39c12142a5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Andy
 Type:   |  Craze
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Andy Craze):

 * owner:  (none) => Andy Craze
 * status:  new => assigned


Comment:

 Added a PR with all the i18n template tags reorganized into
 syntax_tests/i18n:
 https://github.com/django/django/pull/7724

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b07be572e6dcd88e4aad95348bb85e05%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
--+
 Reporter:  Preston Timmons   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Aleksandr Sobolev):

 * status:  assigned => new
 * owner:  Aleksandr Sobolev => (none)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.ecd95bf114f1775b5396a03eb636bdc5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Aleksandr
 Type:   |  Sobolev
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b0d4ba1911c620e704ee52fbe9617765%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Aleksandr
 Type:   |  Sobolev
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Aleksandr Sobolev):

 Sorry, my fault. Next time I'll avoid such mistakes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.221040ab71b514eeb6e8d08801e6ef3f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Aleksandr
 Type:   |  Sobolev
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Thanks for the patch. The correct
 [https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
 tickets/ triage action] is to check "Has patch"' when adding a pull
 request. "Ready for checkin" is set by the person who reviews the patch.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2a2e89b144507d51760c09520db91d0a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Aleksandr
 Type:   |  Sobolev
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Aleksandr Sobolev):

 * stage:  Accepted => Ready for checkin


Comment:

 Create pull request with three commits:
 https://github.com/django/django/pull/7363

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.21af7866d33b968d0d5f01dba6eaca14%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests

[Django]

#24423: Combine i18n template tag tests
-+-
 Reporter:  Preston Timmons  |Owner:  Aleksandr
 Type:   |  Sobolev
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Aleksandr Sobolev):

 * owner:  nobody => Aleksandr Sobolev
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.45553d3836942459a4d350f4674cf35a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests (was: Combine i18n template tag tests?)

[Django]

#24423: Combine i18n template tag tests
--+
 Reporter:  Preston Timmons   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Tim Graham):

 * easy:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.d848d3480d06be4943d3e72e9b3967bc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24423: Combine i18n template tag tests?

[Django]

#24423: Combine i18n template tag tests?
--+
 Reporter:  prestontimmons|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Sounds good to me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.5963ee47dab191d0e665d5a27ef2be7e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.