Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
--+
 Reporter:  rednaw|Owner:  rednaw
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:  build_absolute_uri| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Erik Romijn ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"794c3f74c32062d0f2ad021cb2af0e530b40730d"]:
 {{{
 #!CommitTicketReference repository=""
 revision="794c3f74c32062d0f2ad021cb2af0e530b40730d"
 Fixed #24460 -- Extended HttpRequest.build_absolute_uri documentation

 Added explanation on why build_absolute_uri always enforces the
 request's scheme.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.8f29e58ca3b304c7c34f087667b17568%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
--+
 Reporter:  rednaw|Owner:  rednaw
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  build_absolute_uri| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by erikr):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.022c252d6e2dbaf44f17d303f3b5794d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
--+
 Reporter:  rednaw|Owner:  rednaw
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  build_absolute_uri| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by rednaw):

 * status:  new => assigned
 * owner:  nobody => rednaw


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ebcbb5c92903ed21858c95cbef0ac025%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
--+
 Reporter:  rednaw|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  build_absolute_uri| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by bmispelon):

 * needs_docs:  1 => 0
 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.d4a82df238c4fc489968037107f1ea02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
--+
 Reporter:  rednaw|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  build_absolute_uri| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by rednaw):

 Created a pull request for this:

 https://github.com/django/django/pull/4278

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.02e828438d6aaae5336816fdbe59a740%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
--+
 Reporter:  rednaw|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  build_absolute_uri| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by rednaw):

 I couldn't find a good website where they explain the disadvantages
 clearly, and I think the explanation is maybe a bit too much to add in
 this part of the documentation. It could maybe be added somewhere else and
 linked to it, but I wouldn't know a good spot right of the top of my head
 now.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a907a2cdd3d4fae4f721b4fd2b7675ad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
--+
 Reporter:  rednaw|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  build_absolute_uri| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+

Comment (by bpeschier):

 I agree with Erik, otherwise the question "why does Django discourage it?"
 arises quickly. Referencing some documentation about why it is a bad idea
 might be a nice addition.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2c30f533c7f50fa41be3e34626ffe05e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
--+
 Reporter:  rednaw|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:  build_absolute_uri| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by erikr):

 * component:  HTTP handling => Documentation
 * stage:  Unreviewed => Accepted


Comment:

 As we discussed, this seems like a good idea to me. I would change it to
 passive tense though, as the "Django recommends ..." looks a little odd to
 me. Site also seems more appropriate than domain to me. So I suggest:
 `Mixing HTTP and HTTPS on the same site is discouraged.`

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fac22eefa136964ee26efeb0f5d79b57%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24460: Update documentation to explain why `HttpRequest.build_absolute_uri` doesn't have a scheme option

[Django]

#24460: Update documentation to explain why `HttpRequest.build_absolute_uri`
doesn't have a scheme option
-+-
 Reporter:  rednaw   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  build_absolute_uri   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by rednaw):

 * needs_better_patch:   => 0
 * component:  Uncategorized => HTTP handling
 * needs_tests:   => 0
 * version:  1.7 => master
 * easy:  0 => 1
 * keywords:   => build_absolute_uri
 * needs_docs:   => 1
 * type:  Uncategorized => Cleanup/optimization


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cb9dd2184a2a1980a69d4676cd2b9628%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.