Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:  Tim
 |  Graham 
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  migrations test  | Triage Stage:  Accepted
  keepdb |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * owner:   => Tim Graham 
 * resolution:   => fixed


Comment:

 In [changeset:"80e3444eca045799cc40e50c92609e852a299d38" 80e3444]:
 {{{
 #!CommitTicketReference repository=""
 revision="80e3444eca045799cc40e50c92609e852a299d38"
 Fixed #24483 -- Prevented keepdb from breaking with generator choices.

 If Field.choices is provided as an iterator, consume it in __init__
 instead
 of using itertools.tee (which ends up holding everything in memory
 anyway). Fixes a bug where deconstruct() was consuming the iterator but
 bypassing the call to `tee`.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.59aa7ee1886a19db15b68e9aba4ef5f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:  Accepted
  keepdb |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.5407a2829aa6dc6e6f6af94fea5692d4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:  Accepted
  keepdb |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  assigned => new
 * needs_better_patch:  0 => 1
 * owner:  timgraham =>


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.a9b4db61668afc2cc65dfa6f51b9843c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:  Accepted
  keepdb |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"247251c2e1702831b7ab80a69a3f7f5831be3b96" 247251c]:
 {{{
 #!CommitTicketReference repository=""
 revision="247251c2e1702831b7ab80a69a3f7f5831be3b96"
 [1.8.x] Refs #24483 -- Added a test for deconstruction of Field.choices

 Backport of b4a56ed4f55502239cb11b57f0fa75baa0a97640 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.87abc491fe6de8364d294cd5a328054b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:  Accepted
  keepdb |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"b4a56ed4f55502239cb11b57f0fa75baa0a97640" b4a56ed]:
 {{{
 #!CommitTicketReference repository=""
 revision="b4a56ed4f55502239cb11b57f0fa75baa0a97640"
 Refs #24483 -- Added a test for deconstruction of Field.choices
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.fcf249e2b92b59b4fce6609766358dce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:  Accepted
  keepdb |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * owner:  davidszotten => timgraham
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.ed99fb83c22aabf2cea7f291839f168b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:
 |  davidszotten
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:
  keepdb |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by davidszotten):

 not sure what you mean by "Does this even work on a live website?" I have
 a generator providing choices in an app i've had in production for a good
 few years now (though probably using a generator mostly by accident). I
 noticed this issue a few days ago as i was trying out the new 1.8 beta and
 `--keepdb` to speed up my test suite.

 the patch updates code that was definitely put in place to support generic
 iterators, and as you point out, the docs also talk about iterables.

 not sure of the correct protocol, so the pr is raised against 1.8.x, not
 master (i might be going crazy, but every other time i look i can't find
 the pr listed on the ticket, so here's a direct link:
 https://github.com/django/django/pull/4326 )

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.16710d30aaa68a10bc20db12b526b70d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:
 |  davidszotten
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:
  keepdb |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by jarshwah):

 https://code.djangoproject.com/ticket/3490 was specifically added to
 support the use of generators with choices, so we probably should find and
 fix the problem. Though I'm unsure whether or not this should be a
 blocker.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.79e7a1de8d384840a879482048fd3798%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:
 |  davidszotten
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:
  keepdb |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by jarshwah):

 I'm not so sure that django really supports the use of generators for
 choices. The docs do say "An iterable (e.g., a list or tuple) consisting
 itself of iterables of exactly two items (e.g. [(A, B), (A, B) ...])"
 which a generator is, but I can't see the value in having it as a
 generator in the first place as it's going to be consumed in its entirety
 fairly quickly in the load process.

 Does this even work on a live website? If yes, then we should probably fix
 it. But I doubt we'd mark it as a release blocker due to the necessary
 combinations of actually triggering the problem (the impact is small).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.d446d50ed6bb36da30ce81e441108c41%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24483: keepdb migrations break choices as generators

[Django]

#24483: keepdb migrations break choices as generators
-+-
 Reporter:  davidszotten |Owner:
 |  davidszotten
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  1.8beta2
 Severity:  Normal   |   Resolution:
 Keywords:  migrations test  | Triage Stage:
  keepdb |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by davidszotten):

 * status:  new => assigned
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * owner:  nobody => davidszotten
 * needs_docs:   => 0
 * has_patch:  0 => 1
 * type:  Uncategorized => Bug


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.ebd18dd3fdc0ee29197fd431b07f5ddc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.