Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.18efa95d5dfb3d71181f876a0868e933%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Markus Holtermann ):

 In [changeset:"8e631a3175f145dbf3eec269f8e3c59a1520540f" 8e631a3]:
 {{{
 #!CommitTicketReference repository=""
 revision="8e631a3175f145dbf3eec269f8e3c59a1520540f"
 Refs #24590 -- Ensured isolation between autodetector tests

 Fixed a regression introduced in e1427cc609fa6ab247501b101cfb3c0092aba55b
 when running tests in reverse order.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.dec88ba1b20bef013f0b6985e6e1615f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by MarkusH):

 This change isolates the tests in `migrations` that rely on a replaced
 swappable model: https://github.com/django/django/pull/5199

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.38d7c91f9fbd85a1a4d5a60feb7b3946%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  closed => new
 * resolution:  fixed =>


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.198d9c82f7c8e65e07c1f7140e35d695%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * has_patch:  1 => 0
 * stage:  Ready for checkin => Accepted


Comment:

 Looks like the new tests aren't isolated as they fail in reverse: `$
 ./tests/runtests.py --reverse migrations`

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.1496390b67290cd86f31bfd3c3b2a4d9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Markus Holtermann ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"e1427cc609fa6ab247501b101cfb3c0092aba55b" e1427cc6]:
 {{{
 #!CommitTicketReference repository=""
 revision="e1427cc609fa6ab247501b101cfb3c0092aba55b"
 Fixed #24590 -- Cached calls to swappable_setting.

 Moved the lookup in Field.swappable_setting to Apps, and added
 an lru_cache to cache the results.

 Refs #24743

 Thanks Marten Kenbeek for the initial work on the patch. Thanks Aymeric
 Augustin and Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.983172a280eb4e84d1bb0d5efe7118bb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ea5f12070307871d9818700855ef3626%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * needs_docs:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.7effd2a148da3ccc8252bc977c142aa7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * needs_docs:  0 => 1
 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0f9ae1d566732f3d8841f40f6e7fb894%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  MarkusH
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * status:  new => assigned
 * owner:  knbk => MarkusH


Comment:

 I updated the existing PR: https://github.com/django/django/pull/5176

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.ffb93004abc20c57136f20a12004ae05%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.9e37489cdb313e0143fd234d5d42249c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by MarkusH):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.7396726aaf60e3fd37fa1022bc1c4254%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24590: Cache return value of `swappable_setting`

[Django]

#24590: Cache return value of `swappable_setting`
-+-
 Reporter:  knbk |Owner:  knbk
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by knbk):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 PR: https://github.com/django/django/pull/4459

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.64d21cd57cb48568d5c6e44e76243d0f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.