Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+-
 Reporter:  jerivas  |Owner:  timgraham
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 This has been fixed in Django 1.8.3+ so if you can reproduce your problem
 there, please open a new ticket with details. Thanks.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2faf636beafd158d73b42c02fafd5eb7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+-
 Reporter:  jerivas  |Owner:  timgraham
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by hobarrera):

 I'm having an extremely similar issue, but when the reverse OneToOne is in
 the `readonly` list, rather than `fields`. Is it possible it's the same
 issue? The above mentioned test app seems to be gone.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ff79f0f853102b3723e001131bb39603%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+-
 Reporter:  jerivas  |Owner:  timgraham
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"ad0f0daf8c6aa80775d68068a76c5b6d0fff04ec" ad0f0daf]:
 {{{
 #!CommitTicketReference repository=""
 revision="ad0f0daf8c6aa80775d68068a76c5b6d0fff04ec"
 Fixed #24851 -- Fixed crash with reverse one-to-one relation in
 ModelAdmin.list_display

 Forwardport of 2456276b0250c9f21d580ca6c3f3c86345ad6370 from stable/1.8.x
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.916c555802f39013287a3c0ac00da228%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+-
 Reporter:  jerivas  |Owner:  timgraham
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2456276b0250c9f21d580ca6c3f3c86345ad6370" 2456276b]:
 {{{
 #!CommitTicketReference repository=""
 revision="2456276b0250c9f21d580ca6c3f3c86345ad6370"
 [1.8.x] Fixed #24851 -- Fixed crash with reverse one-to-one relation in
 ModelAdmin.list_display
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6a9f6c5f217b8e31bd97461c8c42c148%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+-
 Reporter:  jerivas  |Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/4717 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.bfc734c18c23f23a513edea11f238b6e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+-
 Reporter:  jerivas  |Owner:  timgraham
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => assigned
 * owner:  nobody => timgraham


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.25b9b1e5e0e263a45a6cf69235ff5d69%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+
 Reporter:  jerivas  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timgraham):

 I don't think it could be easily supported in `fields` as that would
 require saving the related instance. `readonly_fields` support might be
 doable. I think a natural suggestion for the error message would be to
 suggest to use an inline.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e2b5cdc0b0932e620f38d76b707030f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+
 Reporter:  jerivas  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by jerivas):

 Whoops, you're right, I was only using `list_display` in 1.6. Sorry about
 that.

 However, wouldn't it be appropriate to support reverse one-to-one
 relations in `fields`? I see three possible scenarios:

 - Reverse one-to-one relations fully supported in `fields`.
 - Supported only when they appear in `readonly_fields`.
 - Unsupported, but they raise a more useful exception and is explained in
 the docs. The current exception says the one-to-one field is unknown to
 the model, which is confusing and gives the impression the user has made a
 typo in `fields`. IMO `ImproperlyConfigured` would be better.

 If you think any of the above have the potential of flying as a feature
 request, I can open a new ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9c2883e14db87eaa3c9235438e65cda8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+
 Reporter:  jerivas  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * Attachment "24851-test.diff" added.


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d46a2082d1e1d02899916cb850146a28%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24851: Regression in reverse one-to-one field in list_display (was: Reverse one-to-one relations break the admin.)

[Django]

#24851: Regression in reverse one-to-one field in list_display
-+
 Reporter:  jerivas  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * severity:  Normal => Release blocker
 * needs_better_patch:   => 0
 * component:  Uncategorized => contrib.admin
 * needs_tests:   => 0
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Reproduced the `list_display` crash and bisected the regression in 1.8 at
 fb48eb05816b1ac87d58696cdfe48be18c901f16. It's fixed in master by
 8f30556329b64005d63b66859a74752a0b261315 but we should fix it in 1.8 too.
 Attaching a regression test.

 As for the change view error, that seems to be reproducible on
 stable/1.6.x and stable/1.4.x so I don't think it's a regression or a bug.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.04446d78624f9f9083b4485db7448369%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.