Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
-+-
 Reporter:  shelldweller |Owner:  quamilek
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  test | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2085d8d5bc2625076983d3be14b30ea684c3f0d5" 2085d8d5]:
 {{{
 #!CommitTicketReference repository=""
 revision="2085d8d5bc2625076983d3be14b30ea684c3f0d5"
 Fixed #25170 -- Made assertXMLEqual()/assertXMLNotEqual() ignore leading
 and trailing whitespace.

 Thanks Jacek Bzdak for indepdently contributing a similar fix.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.6b0d46a1e0581b967e69e07ed9017ae3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
-+-
 Reporter:  shelldweller |Owner:  quamilek
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  test | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by charettes):

 * stage:  Accepted => Ready for checkin


Comment:

 Contained white-space should really be considered significant in the HTML
 case.

 If I remember correctly it affect `display: inline` elements in some way
 (or it did in the past).

 Stripping leading and trailing white space makes sense to me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.23fef707893988d555f207ee5dfdd85e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  quamilek
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by nostalgiaz):

 * needs_better_patch:  1 => 0


Comment:

 The fixed branch is available here:
 https://github.com/nostalgiaz/django/tree/pull_25170
 And the PR is here: https://github.com/django/django/pull/5580

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.d5615c97c355d7aff3bc79005ee4316d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  quamilek
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+

Comment (by nostalgiaz):

 According to https://tools.ietf.org/html/rfc3470#section-4.16
 > In XML instances all white space is considered significant and is by
 default visible to processing applications

 So, I think that @jbzdak is right.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.8416fb4b858833c456d19bc0617c4424%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  quamilek
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+

Comment (by jbzdak):

 Whitespace around tags is indeed siginificant --- technically following
 documents *are* different
 {{{
 
 }}}
 and
 {{{
 
 
 }}}

 however for most practical purposes this difference is insignificant, as
 most of XML-based formats ignore whitespace altogether (like html).
 Despite that I think that in unittesting framework we should rather assume
 pessimistic case that whitespace does matter.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.32ef64498e6b7b0017bc5d9cff1b95aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  quamilek
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.5856b6fbed11d5f02e25ce7f3e0fecb1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
-+-
 Reporter:  shelldweller |Owner:  quamilek
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  test | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.46c7cae768497ecf7d7ce9e4af395e69%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  quamilek
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by timgraham):

 * has_patch:  0 => 1


Comment:

 I think [https://github.com/django/django/pull/5052 PR 5052] is more
 correct in that it will continue to consider whitespace *inside* a tag
 significant; e.g. the following snippets shouldn't be considered equal:
 {{{
 foo 
 foo
 }}}
 Anyone to confirm that? The author of
 [https://github.com/django/django/pull/5049 PR 5049] argues otherwise.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.822418f23bdcf3ac251a48fa2315dae0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  quamilek
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by quamilek):

 I started working on this bug after assigned.
 This is PR for this issue: https://github.com/django/django/pull/5052
 Resolution of this bug is different then @mishunika.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2eace9941240121078752ad3be295994%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  quamilek
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by mishunika):

 At the time of analyzing the issue, I didn't notice that the issue is
 already assigned. Anyway, just because the fix seems so simple, and there
 is no pull request yet, I published my own solution as a PR.

 The fixed branch is available here:
 https://github.com/mishunika/django/tree/ticket_25170
 And the PR is here: https://github.com/django/django/pull/5049

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.8aa5bb333f9584c04e6acd8961a7b406%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  quamilek
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by quamilek):

 * owner:  nobody => quamilek
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.f7b8dfd77d335e86f967352d4bee0b1e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25170: assertXMLEqual fails when white space is present outside XML fragment

[Django]

#25170: assertXMLEqual fails when white space is present outside XML fragment
---+
 Reporter:  shelldweller   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  test   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * version:  1.8 => master
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Seems reasonable as the docstring says "Whitespace in most cases is
 ignored".

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.b37814e80da8c13dd3d59fe891c1970e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.