Re: [Django] #25431: ModelFormset regression in object clean() accessing a FK

[Django]

#25431: ModelFormset regression in object clean() accessing a FK
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  regression   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz ):

 In [changeset:"158b0a28374054b1c3f94a9602b69f93fc980448" 158b0a28]:
 {{{
 #!CommitTicketReference repository=""
 revision="158b0a28374054b1c3f94a9602b69f93fc980448"
 [1.8.x] Fixed #25431 -- Readded inline foreign keys to modelformset
 instances

 Too much field exclusions in form's construct_instance() in _post_clean()
 could lead to some unexpected missing ForeignKey values.
 Fixes a regression from 45e049937. Refs #13776.

 Backport of 65a1055a3 from master.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b14929e0ba175e41ff2299b89c9f72f1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25431: ModelFormset regression in object clean() accessing a FK

[Django]

#25431: ModelFormset regression in object clean() accessing a FK
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.8
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  regression   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"65a1055a36318ff4e21ffeb7c3dd62fa81892269" 65a1055]:
 {{{
 #!CommitTicketReference repository=""
 revision="65a1055a36318ff4e21ffeb7c3dd62fa81892269"
 Fixed #25431 -- Readded inline foreign keys to modelformset instances

 Too much field exclusions in form's construct_instance() in _post_clean()
 could lead to some unexpected missing ForeignKey values.
 Fixes a regression from 45e049937. Refs #13776.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.196d1f0dc4a306c6bd7d0901e64b4583%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25431: ModelFormset regression in object clean() accessing a FK

[Django]

#25431: ModelFormset regression in object clean() accessing a FK
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:  regression   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.19d9ee3809432bf9a056c234d004d5c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25431: ModelFormset regression in object clean() accessing a FK

[Django]

#25431: ModelFormset regression in object clean() accessing a FK
-+
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:  regression   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0a62e98a01a0de86cae08249c468dbe5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25431: ModelFormset regression in object clean() accessing a FK

[Django]

#25431: ModelFormset regression in object clean() accessing a FK
-+--
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:  regression   | Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by claudep):

 * has_patch:  0 => 1


Comment:

 If the patch gets approved, I'd like to tentatively backport this to 1.8.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5d01309208c5b23887909a418d9641e3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25431: ModelFormset regression in object clean() accessing a FK

[Django]

#25431: ModelFormset regression in object clean() accessing a FK
-+--
 Reporter:  claudep  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:  regression   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by claudep):

 Just apply that patch to reproduce the problem in Django's test suite:
 {{{
 #!diff
 diff --git a/tests/model_formsets/models.py
 b/tests/model_formsets/models.py
 index df6a687..7b7337f 100644
 --- a/tests/model_formsets/models.py
 +++ b/tests/model_formsets/models.py
 @@ -37,6 +37,10 @@ class Book(models.Model):
  def __str__(self):
  return self.title

 +def clean(self):
 +# Ensure author is always accessible in clean method
 +assert self.author.name is not None
 +

  @python_2_unicode_compatible
  class BookWithCustomPK(models.Model):
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.42a8843c21baa69822950a1e485be31e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.