Re: [Django] #25551: makemigrations when adding a ForeignKey to a newly created model along with a unique_together constraint must create fields before the unique_together constraint

2015-11-20 Thread Django 
#25551: makemigrations when adding a ForeignKey to a newly created model along 
with
a unique_together constraint must create fields before the unique_together
constraint
+---
 Reporter:  mssnlayam   |Owner:  avojnovicDk
 Type:  Bug |   Status:  closed
Component:  Migrations  |  Version:  1.8
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"73a6ab6382809d5452907dcff5767403d8d66985" 73a6ab63]:
 {{{
 #!CommitTicketReference repository=""
 revision="73a6ab6382809d5452907dcff5767403d8d66985"
 Fixed #25551 -- Fixed migration operations ordering when adding fields and
 a unique_together constraint.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9e908f87bfe9ac37998bd6854daec584%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25551: makemigrations when adding a ForeignKey to a newly created model along with a unique_together constraint must create fields before the unique_together constraint

2015-11-19 Thread Django 
#25551: makemigrations when adding a ForeignKey to a newly created model along 
with
a unique_together constraint must create fields before the unique_together
constraint
+---
 Reporter:  mssnlayam   |Owner:  avojnovicDk
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.8
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by avojnovicDk):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5fedb0dd0d99863b358c23df57625acd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25551: makemigrations when adding a ForeignKey to a newly created model along with a unique_together constraint must create fields before the unique_together constraint

2015-11-18 Thread Django 
#25551: makemigrations when adding a ForeignKey to a newly created model along 
with
a unique_together constraint must create fields before the unique_together
constraint
+---
 Reporter:  mssnlayam   |Owner:  avojnovicDk
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.8
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+---
Changes (by timgraham):

 * needs_better_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.25b748fac29ae756f67c5e0e2b8b1a77%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25551: makemigrations when adding a ForeignKey to a newly created model along with a unique_together constraint must create fields before the unique_together constraint

2015-11-07 Thread Django 
#25551: makemigrations when adding a ForeignKey to a newly created model along 
with
a unique_together constraint must create fields before the unique_together
constraint
+---
 Reporter:  mssnlayam   |Owner:  avojnovicDk
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.8
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by avojnovicDk):

 * has_patch:  0 => 1


Comment:

 This happens for the very specific edge case: If you create a model, make
 migrations for that model, and then add a foreign key to another model
 that didn't exist previously with unique together, the order of the action
 in the new migration will not be correct: it will try to alter unique
 together and then add the field used in unique together.
 I made PR with fix for this.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ad8dbfee20546755d5ef44c2ded5bca2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25551: makemigrations when adding a ForeignKey to a newly created model along with a unique_together constraint must create fields before the unique_together constraint

2015-11-05 Thread Django 
#25551: makemigrations when adding a ForeignKey to a newly created model along 
with
a unique_together constraint must create fields before the unique_together
constraint
+---
 Reporter:  mssnlayam   |Owner:  avojnovicDk
 Type:  Bug |   Status:  assigned
Component:  Migrations  |  Version:  1.8
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+---
Changes (by avojnovicDk):

 * status:  new => assigned
 * owner:  nobody => avojnovicDk


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2bd08d63ce39845a76a3d7b20e302441%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25551: makemigrations when adding a ForeignKey to a newly created model along with a unique_together constraint must create fields before the unique_together constraint

2015-10-13 Thread Django 
#25551: makemigrations when adding a ForeignKey to a newly created model along 
with
a unique_together constraint must create fields before the unique_together
constraint
+
 Reporter:  mssnlayam   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  Migrations  |  Version:  1.8
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Seems similar to #22035 but I can reproduce the issue on master.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.258f8f8c3cdbab65d7446af43f638ced%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.