Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Shai Berger):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Hi Vincent,

 Thanks for your efforts, and sorry for your time, but I agree with Tim:
 This ticket would have been nice to add early in the 1.8 lifecycle, but
 it's become much less valuable now. Most of the people who wanted to
 upgrade from pre-1.8 have already done so. Your latest suggestion is
 indeed simple, but IMO doesn't really add much value, and without the
 "help upgrade to 1.8" motive, indeed sets a bad precedent for adding
 unnecessary details to an error message.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.845e59a9731f8e2e4cd52c04c6db4713%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0
 * stage:  Ready for checkin => Accepted


Comment:

 The "Needs review" status is "Accepted + Has patch", not "Ready for
 checkin".

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7bf6cf0dd94b95a3e16501d1d52ba908%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Vincent Perez):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.003dc74f17585c6a08728b627e8376cf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Vincent Perez):

 I've opened a new simplied PR:
 https://github.com/django/django/pull/7622/files

 If there at least one relational fields amongst the fields given to
 select_related, the message becomes:

 FieldError: Invalid field name(s) given in select_related: 'choice_set'.
 Choices are: (none)". Reverse relations cannot be used in select_related'

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.16b99af4b57766377e5e3ed44facb1c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 I don't know, the ticket's description didn't include the actual message
 so it seems to was tough to evaluate the ticket. We're not going to
 backport a fix at this point.

 If "Invalid field name(s) given in select_related:" isn't specific enough,
 how about something like "Non-single value relation given in
 select_related:".

 Anyway, I'll take another look at the PR however you'd like to amend it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.86ee538bab7660a6a7b7c72bfa84b7b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Vincent Perez):

 I think the message in its current state is confusing, specially when you
 are upgrading from a Django version prior to 1.8, where the select_related
 used to fail silently.  IMHO, the fix as I suggested in my previous
 comment is simple enough to be worth it.

 Btw, Aymeric Augustin found this fix worthy enough to even consider
 backporting it in 1.8 (see comment above), so that makes at least 3 of us
 thinking this fix is worth it :)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.9e8df805f4f3d16d295fcd11049aab94%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 My preference is to close the ticket as wontfix. Do you find the existing
 error message confusing or unclear? I think it's clear that anything that
 doesn't appear in the message's choices isn't allowed, regardless of the
 reason.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.23534744b43b19202c5b0d463dae1e26%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Vincent Perez):

 A simpler alternative could be to simply adjust the error message if there
 is at least one reverse relation amongst the incorrect fields. In that
 case, the error message would be:

 >FieldError: Invalid field name(s) given in select_related: 'choice_set'.
 Choices are: (none)". Reverse relational fields are not allowed in
 select_related.

 This way, the patch will indeed be much simpler .

 But the message won't be more friendly for generic relation and generic
 FK, which are also forbidden. Is it a big deal? If the answer to this last
 question is yes, I could adjust the previous logic and simply do: if there
 is at least one reverse relation, generic FK or generic relation amongst
 the incorrect fields, then I display the message:

 >FieldError: Invalid field name(s) given in select_related: 'choice_set'.
 Choices are: (none)". Reverse relational fields, Generic relations and
 generic foreign keys are not allowed in select_related.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d483fdb9f93bd419222b86359af69854%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 The patch turned out a lot more complicated than I thought it would be,
 and I'm not sure if it's worth it. In the original report, Shai said the
 error message refers to fields as "non-existent" but as far as I see, the
 error message is something like:

  FieldError: Invalid field name(s) given in select_related: 'choice_set'.
 Choices are: (none)".

 Since the choices are there, I think it's already clear whether there's a
 typo or if the field isn't supported by `select_related()`. With the
 patch, the error turns into:

  FieldError: Invalid field name(s) given in select_related: 'choice_set'
 (reason: reverse relational field). Choices are: (none).

 We have similar error messages elsewhere and this might set a precedent
 for doing more work to "improve" them similarly. Other opinions welcome.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8fb6fac7174f20a0026b87a5b4926e84%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Alexandre Hajjar):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 PR looks fine to me.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d9485d3830b837d3bd27f4858ef9e4f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Vincent Perez):

 The PR is updated: https://github.com/django/django/pull/7487/files

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.8a81dc3e2a330e6422de4131c0089194%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0ce8dcbe6831e934fce422e761d35894%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Vincent Perez):

 * stage:  Ready for checkin => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.db4438c65db413b07c0d98e4839722f1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Vincent Perez):

 In fact this still a WIP. I will make a new comment once my PR is updated.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a62a8bb04f647fdf1eb4f2bc0c6d2238%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by mr-bo-jangles):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.986ff7e787b949a4f2b554a21591b52c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Vincent Perez):

 * has_patch:  0 => 1


Comment:

 I have opened a pull request for this:

 https://github.com/django/django/pull/7487/

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.81410eff5d67201a69d8b872d962aa2f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  Shai Berger  |Owner:  Vincent
 |  Perez
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Vincent Perez):

 * status:  new => assigned
 * owner:  nobody => Vincent Perez


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c90b63a2bb70d59d2de484e69c2c145c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  shaib|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.598e2651b835f465d61220bd05a518e4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25569: Add a friendly error report when using select_related() on a reverse relation

[Django]

#25569: Add a friendly error report when using select_related() on a reverse
relation
-+-
 Reporter:  shaib|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.8
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 +1 to backporting to 1.8.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.618255409d621fbe1467d302ea42a509%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.