Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+
 Reporter:  Denis Cornehl|Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Robert Roskam):

 * status:  assigned => new
 * owner:  Robert Roskam => (none)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0b34a4a4e73bc8e0d5d798df5553c3db%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+-
 Reporter:  Denis Cornehl|Owner:  Robert Roskam
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Robert Roskam):

 * status:  new => assigned
 * owner:  nobody => Robert Roskam


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dd3e084c01cc6305ebedeedb1b30be9f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+
 Reporter:  syphar   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * severity:  Release blocker => Normal


Comment:

 Per [https://groups.google.com/d/topic/django-
 developers/BLW5fCTDYHA/discussion discussion on django-developers],
 demoting from a release blocker since `string_if_invalid` is only intended
 for debugging. Inconsistencies in how the `{% if %}` tag silences
 exceptions (#17664) may be related.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c3ec23dd61366b70856ddff707940f8c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+
 Reporter:  syphar   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by felixxm):

 * cc: felisiak.mariusz@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3b1e0320d94ee2a167ad93d93518a192%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+
 Reporter:  syphar   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by timgraham):

 The `RelatedObjectDoesNotExist` exception is a subclass of
 `AttributeError` -- that's why it's hitting that logic added in the commit
 noted in the previous comment. We end up checking `{% if
  %}` which passes for a non-empty `string_if_invalid`.
 I'm not sure we should add special handling of `RelatedObjectDoesNotExist`
 in the template engine to restore the old behavior (and I'm not sure how
 to since `RelatedObjectDoesNotExist` is a dynamically generated exception
 based on the related descriptors).

 I think the usage of `string_if_invalid` is somewhat
 unreliable/unpredictable anyway and therefore discouraged but I'm not too
 sure as I haven't used it myself.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bac0cf85d66162214b98986a4a1e4314%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+
 Reporter:  syphar   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Okay, making that setting a non-empty value is the piece I was missing to
 reproduce. Bisected the change to
 0dd05c9e66ebb5cb97136f84373f43582783e1a6. It's not immediately obvious to
 me what the resolution should be, but at least some documentation could be
 added if we decide not to change the behavior.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bf8e77ae4bc9b73f2dea9fd75c652e52%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+--
 Reporter:  syphar   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by syphar):

 I can still try do write a failing testcase if it helps

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.26319c7ec658e77ee9c7d56b4395647d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+--
 Reporter:  syphar   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by syphar):

 wanted to play around a little to find the point where it stopped working
 (in our codebase).

 I starts happening when we set {{{TEMPLATE_STRING_IF_INVALID}}} to any
 value (with {{{%s}}} or without)

 Out of curiosity I tried if it's related to the old
 ({{{TEMPLATE_STRING_IF_INVALID}}} or the new ({{{string_if_invalid}}}
 option in the {{{TEMPLATES}}} config, but it happens always.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3edc1081e3174ba8a47b8ebef394b931%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25600: Template `if` tag behavior change with 1.8, OneToOneField, RelatedObjectDoesNotExist is True?

[Django]

#25600: Template `if` tag behavior change with 1.8, OneToOneField,
RelatedObjectDoesNotExist is True?
-+--
 Reporter:  syphar   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I can't reproduce that -- I'm always seeing the else branch on master and
 stable/1.8.x. Maybe you could provide a failing test case for Django's
 test suite?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1672474dc10d0398e024a00560c76a76%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.