Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 Type:   |  Fedoseev
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"a0149848f7c068bc8507d3ec6f93cd2b7256098a" a0149848]:
 {{{
 #!CommitTicketReference repository=""
 revision="a0149848f7c068bc8507d3ec6f93cd2b7256098a"
 Refs #25665 -- Removed GEOSGeometry.get/set_srid() per deprecation
 timeline.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c9a2f10e9181e9fbcc6a01b121712012%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 Type:   |  Fedoseev
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"19d8e64ac357271e708f6db377975ee85b7e4342" 19d8e64a]:
 {{{
 #!CommitTicketReference repository=""
 revision="19d8e64ac357271e708f6db377975ee85b7e4342"
 Refs #25665 -- Removed deprecated getters/setters of Point coordinate
 properties.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.903526aaf9cde17b16c2ae6d528c4ef6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  Sergey Fedoseev  |Owner:  Sergey
 Type:   |  Fedoseev
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"997c9f709974ea79d9eb9e83eaf24e7bc0e7f9d4" 997c9f70]:
 {{{
 #!CommitTicketReference repository=""
 revision="997c9f709974ea79d9eb9e83eaf24e7bc0e7f9d4"
 Refs #25665 -- Removed deprecated getter/setter of Point.tuple.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.175cedb4b3ed17a50c822a2a6457bbc8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  closed
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7a452c5ce295679307bd81dd9b5f37b3cf762acf" 7a452c5]:
 {{{
 #!CommitTicketReference repository=""
 revision="7a452c5ce295679307bd81dd9b5f37b3cf762acf"
 Fixed #25665 -- Deprecated getter/setter of Point.tuple.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f7c0665aa973ba32e02fd9f7dee9c94f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"7803f429a4d435623cb7b91dd324d3aadad87380" 7803f42]:
 {{{
 #!CommitTicketReference repository=""
 revision="7803f429a4d435623cb7b91dd324d3aadad87380"
 Refs #25665 -- Deprecated getters/setters of Point coordinate properties.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8b399ca5b443851b2a49ec7ce8fc49c9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.00779c1f9bf1100fd85deb279772c8f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"b7177cc2a422a0183c8f2d56eceb6b9323c6f959" b7177cc]:
 {{{
 #!CommitTicketReference repository=""
 revision="b7177cc2a422a0183c8f2d56eceb6b9323c6f959"
 Refs #25665 -- Deprecated getter/setter of GEOSGeometry.srid.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6b6e86e72f5aa050328e6285cdead023%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by sir-sigurd):

 * needs_better_patch:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.fe279ce86975abfd37f0f50a06c3d7b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 Left comments for improvement.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.2fc24e71dda04a7ad9f83b1578df57a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 Looks good, I'll let Tim make the language review.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c4cb7b1e58d5d76b71c32c7d9d811734%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by sir-sigurd):

 * has_patch:  0 => 1


Comment:

 PR -- https://github.com/django/django/pull/5549

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.92430031392a63c0315691196d6c03f7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #25665: deprecate public getters/setters for properties of `GEOSGeometry` and its subclasses (was: alias members of `GEOSGeometry` (`num_points`, `crs`, `get_srid`, `set_srid`) should be

[Django]

#25665: deprecate public getters/setters for properties of `GEOSGeometry` and 
its
subclasses
-+-
 Reporter:  sir-sigurd   |Owner:  sir-
 Type:   |  sigurd
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Old description:

> I'd prefer to deprecate them because I see no benefit in having them, I
> think they just litter class namespace.

New description:



--

Comment (by sir-sigurd):

 I was motivated to deprecate `num_points` and `crs` because number of
 `GEOSGeometry` members looks disturbing for me.
 {{{
 In [2]: GEOSGeometry.
 In [2]: from django.contrib.gis.geos import GEOSGeometry as Geometry

 In [3]: Geometry.
 Geometry.appendGeometry.geojson   Geometry.prepared
 Geometry.area  Geometry.geom_type Geometry.ptr
 Geometry.boundary  Geometry.geom_typeid   Geometry.ptr_type
 Geometry.bufferGeometry.get_srid  Geometry.relate
 Geometry.centroid  Geometry.has_cs
 Geometry.relate_pattern
 Geometry.clone Geometry.hasz  Geometry.remove
 Geometry.contains  Geometry.hex   Geometry.reverse
 Geometry.convex_hull   Geometry.hexewkb   Geometry.ring
 Geometry.coord_seq Geometry.index Geometry.set_srid
 Geometry.count Geometry.insertGeometry.simple
 Geometry.crosses   Geometry.intersection  Geometry.simplify
 Geometry.crs   Geometry.intersectsGeometry.sort
 Geometry.differenceGeometry.json  Geometry.srid
 Geometry.dims  Geometry.kml   Geometry.srs
 Geometry.disjoint  Geometry.length
 Geometry.sym_difference
 Geometry.distance  Geometry.mro   Geometry.touches
 Geometry.empty Geometry.normalize Geometry.transform
 Geometry.envelope  Geometry.num_coordsGeometry.union
 Geometry.equalsGeometry.num_geom  Geometry.valid
 Geometry.equals_exact  Geometry.num_points
 Geometry.valid_reason
 Geometry.ewkb  Geometry.ogr   Geometry.within
 Geometry.ewkt  Geometry.overlaps  Geometry.wkb
 Geometry.extendGeometry.point_on_surface  Geometry.wkt
 Geometry.extentGeometry.pop
 }}}

 I'll change ticket summary because there are also getters/setters for
 coordinates of `Point` and probably there are others.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.99960c5904b5fa2fb735fcd55a5233b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.